Received-SPF: pass (google.com: domain of linux-kernel+bounces-93510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 6 Mar 2024 09:36:18 +0100
From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>
To: =?utf-8?B?6Im+6LaF?= <aichao@kylinos.cn>
Cc: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>, 
	W_Armin <W_Armin@gmx.de>, hdegoede <hdegoede@redhat.com>, 
	"ilpo.jarvinen" <ilpo.jarvinen@linux.intel.com>, linux-kernel <linux-kernel@vger.kernel.org>, 
	platform-driver-x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v4] platform/x86: add lenovo generic wmi driver
Message-ID: <20240306092652-4ccf20ee-0044-41c8-8712-d8eb30be9ed7@linutronix.de>
References: <2o0aznm5pjb-2o0c9lfkrd4@nsmail7.0.0--kylin--1>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2o0aznm5pjb-2o0c9lfkrd4@nsmail7.0.0--kylin--1>

On Wed, Mar 06, 2024 at 04:17:43PM +0800, 艾超 wrote:
> > I would be interested on which devices this driver was tested and is
> > expected to work with.
> 
> Lenovo A70，it is a Computer integrated machine.

Could you mention this in your next commit message?

Do you have any idea on which other devices this should work?

> >> This looks similar to a switch.
> >> Would it be more useful for the user to report a standard switch
> instead
> >> of a key event which needs to be correlated with the sysfs file?
> > I agree, maybe SW_CAMERA_LENS_COVER might be the right thing to use
> here,
> > if those camera states (open/closed) are meant to symbolize camera
> shutter states.
> > In such a case the initial switch state has to be retrieved, or else
> the input device
> > cannot be registered until the first event is received (similar how
> the hp-wmi driver
> > handles SW_CAMERA_LENS_COVER events).
> > Ai Chao, can you tell us if those two camera states are meant to act
> like a switch (camera switched off,
> > camera switched on) or meant to act like a key (camera button pressed,
> camera button released)?
> 
> The camera button is like a switch.  I can used SW_CAMERA_LENS_COVER to
> report input event , but the OS
> 
>  can't to show camera OSD. OS need a key value  map to the camera OSD.

Why can't the OS do this?

The switch should report its value.