Received-SPF: pass (google.com: domain of linux-kernel+bounces-93527-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 6 Mar 2024 09:46:35 +0100
From: Oscar Salvador <osalvador@suse.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, muchun.song@linux.dev, david@redhat.com,
	linmiaohe@huawei.com, naoya.horiguchi@nec.com, mhocko@kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm: hugetlb: make the hugetlb migration strategy
 consistent
Message-ID: <Zegta2FEb8pkV4vz@localhost.localdomain>
References: <cover.1709041586.git.baolin.wang@linux.alibaba.com>
 <bdca97e6c59f1b58f09e18defac0c47d1e38f44b.1709041586.git.baolin.wang@linux.alibaba.com>
 <Zd38_AYtr9QKp-F6@localhost.localdomain>
 <8d35b8ae-b8d8-4237-bfcf-ed63c0bb4223@linux.alibaba.com>
 <Zd7xnrzGb_8QiqcE@localhost.localdomain>
 <3eda72bd-25ad-4518-b38e-b63f75e5e94d@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3eda72bd-25ad-4518-b38e-b63f75e5e94d@linux.alibaba.com>

On Wed, Mar 06, 2024 at 04:35:26PM +0800, Baolin Wang wrote:
> On 2024/2/28 16:41, Oscar Salvador wrote:

> >   	if (folio_test_hugetlb(src)) {
> >   		struct hstate *h = folio_hstate(src);
> > +		bool allow_fallback = false;
> > +
> > +		if ((1UL << reason) & HTLB_ALLOW_FALLBACK)
> > +			allow_fallback = true;
> 
> IMHO, users also should not be aware of these hugetlb logics.

Note that what I wrote there was ugly, because it was just a PoC.

It could be a helper e.g:

 if (hugetlb_reason_allow_alloc_fallback(reason)) (or whatever)
     allow_fallback_alloc = true

> > 
> >   		gfp_mask = htlb_modify_alloc_mask(h, gfp_mask);
> >   		return alloc_hugetlb_folio_nodemask(h, nid,
> > -						mtc->nmask, gfp_mask);
> > +						mtc->nmask, gfp_mask,
> > +						allow_fallback);
> 
> 'allow_fallback' can be confusing, that means it is 'allow_fallback' for a
> new temporary hugetlb allocation, but not 'allow_fallback' for an available
> hugetlb allocation in alloc_hugetlb_folio_nodemask().

Well, you can pick "alloc_fallback_on_alloc" which is more descriptive I
guess.

Bottomline line is that I do not think that choosing to allow
fallbacking or not here is spreading more logic than having the
htlb_modify_alloc_mask() here and not directly in
alloc_hugetlb_folio_nodemask().

As I said, code-wise looks fine, it is just that having to pass
the 'reason' all the way down and making the decision there makes
me go "meh..".


-- 
Oscar Salvador
SUSE Labs