Received-SPF: pass (google.com: domain of linux-kernel+bounces-93592-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 6 Mar 2024 09:02:01 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Yunhui Cui <cuiyunhui@bytedance.com>
CC: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<ardb@kernel.org>, <xuzhipeng.1973@bytedance.com>, <alexghiti@rivosinc.com>,
	<samitolvanen@google.com>, <bp@alien8.de>, <xiao.w.wang@intel.com>,
	<jan.kiszka@siemens.com>, <kirill.shutemov@linux.intel.com>,
	<nathan@kernel.org>, <linux-riscv@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-efi@vger.kernel.org>
Subject: Re: [PATCH 1/3] Revert "riscv/efistub: Ensure GP-relative addressing
 is not used"
Message-ID: <20240306-zippy-magazine-9a4ecfe1758a@wendy>
References: <20240306085622.87248-1-cuiyunhui@bytedance.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="UQFtTkia6S6WEuRu"
Content-Disposition: inline
In-Reply-To: <20240306085622.87248-1-cuiyunhui@bytedance.com>

--UQFtTkia6S6WEuRu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 06, 2024 at 04:56:20PM +0800, Yunhui Cui wrote:
> This reverts commit afb2a4fb84555ef9e61061f6ea63ed7087b295d5.
>=20
> Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>

Reverts are commits too. You still need to write commit messages
justifying the revert.

Thanks,
Conor.

> ---
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi=
/libstub/Makefile
> index 31eb1e287ce1..475f37796779 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -28,7 +28,7 @@ cflags-$(CONFIG_ARM)		+=3D -DEFI_HAVE_STRLEN -DEFI_HAVE=
_STRNLEN \
>  				   -DEFI_HAVE_MEMCHR -DEFI_HAVE_STRRCHR \
>  				   -DEFI_HAVE_STRCMP -fno-builtin -fpic \
>  				   $(call cc-option,-mno-single-pic-base)
> -cflags-$(CONFIG_RISCV)		+=3D -fpic -DNO_ALTERNATIVE -mno-relax
> +cflags-$(CONFIG_RISCV)		+=3D -fpic -DNO_ALTERNATIVE
>  cflags-$(CONFIG_LOONGARCH)	+=3D -fpie
> =20
>  cflags-$(CONFIG_EFI_PARAMS_FROM_FDT)	+=3D -I$(srctree)/scripts/dtc/libfdt
> --=20
> 2.20.1
>=20

--UQFtTkia6S6WEuRu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZegw/QAKCRB4tDGHoIJi
0ufrAP0fOFW/zftAQMBV1enoDhJMzqNOQWXj+pDwdOj2qTybjwD/exFfXude+jUl
xvXn4DE7ZGib8U52zF+vq1DDE3/XmgM=
=eSX3
-----END PGP SIGNATURE-----

--UQFtTkia6S6WEuRu--