Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp943582lqs; Wed, 6 Mar 2024 01:14:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUqsNnIu9MNulg89LexI3/9TENnLSV1FScI54zyNTbSiZl/Nc7PCwq1El/dLOwJIMQxZTfLt4+0stJro6FMSPP87X7DjUcet/X1d+YhTA== X-Google-Smtp-Source: AGHT+IGQ6sP/f9OJBvH6Up2+S5FDQhwlWdBOYoGMUPxESNZjUwD/WFe3s1ZShQIKwkhSKEbdPiG8 X-Received: by 2002:a25:ab43:0:b0:dd0:97e8:74e6 with SMTP id u61-20020a25ab43000000b00dd097e874e6mr5833574ybi.55.1709716491197; Wed, 06 Mar 2024 01:14:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709716491; cv=pass; d=google.com; s=arc-20160816; b=hSKEdnynz8iEWrnsQEl8H2LOGkoeIW77LdXQjBYvpk8XrG5ZC40lbiR6uAYjbE7psA 0E4OZ3ixu8p7mrqk+UVhg8hwd8GnBQHQpUAVtULSOBpogc2QdxD+ubWt2vBZ5ufZDtzp AKY0VH5E/RBfnCxR5gHfYy/aYU7/2DOqhwRT/Cueh7ft1q+3CR9vsQCAa2jvvHtDkmGO miqthx+DuOaMvJaIpRZjZk5UNZnzRhnTmjqiSNz/cfo64ZOSL78en58g/QL0hXeQ7oRL OcZREL1fG9m+XM1ACFvyyMjoQmMzonz01FVL28k9l/QO5il1pwe3m97fS5qWEasOcBNH jYuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=Qk/DgjzzjMSGlkOr40MEBE4bLbSg4IfJnGTatQO/eMo=; fh=hot54KXWhpMh5GN2pUlCTQfxre07me0HLiOLQChlj70=; b=BOfS3XIui+LgxvlIqTR5r17l4Z3Cgh5dNiCiaybQCK39VfakNTX70v+TRYqMw9JTyv /Jg/sgwPhUTaZB19Hjoayk+4ZDGVJga8d3XHy4u0uQT2B5LN6B/SWwlW6jLR9OxF2t+U /QAjD8YuBPhZvZDpC5uaVRVhcI9+55FfIrql+fykaQJTKcw1Jwj2Nu5U9chp9wUGbFXu VnL99jOre94iGPaoi5Iml7h4HPkL/Xvn4SNr8oRr0k8NMwdJt9CHtOWRPzq9kDKLXX3g nYQ/BOFcBWVertKbYx9y4WBEuihggmnKPZKKw2Ez7Y1gqdMRm0bTmqw6S8DVxSNFuYRZ NyYQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=bhBhU5fN; arc=pass (i=1 spf=pass spfdomain=szeredi.hu dkim=pass dkdomain=szeredi.hu dmarc=pass fromdomain=szeredi.hu); spf=pass (google.com: domain of linux-kernel+bounces-93601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id l19-20020a05622a051300b0042eb8cd1e34si14468305qtx.538.2024.03.06.01.14.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 01:14:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=bhBhU5fN; arc=pass (i=1 spf=pass spfdomain=szeredi.hu dkim=pass dkdomain=szeredi.hu dmarc=pass fromdomain=szeredi.hu); spf=pass (google.com: domain of linux-kernel+bounces-93601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E5ED21C22411 for ; Wed, 6 Mar 2024 09:14:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 662855E068; Wed, 6 Mar 2024 09:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="bhBhU5fN" Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A93C05CDF1 for ; Wed, 6 Mar 2024 09:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709716425; cv=none; b=ZJyBdy7vgdTythNEfKKl8BTpGRuncJth+0VX6UkTfYkS5z060obX8hKXY4zOAy63iII4AHw8ETq4JhmH4nHLBgqP9V/BvO3Oa6C/wgxUXczaAhDDGqJXQRZCq/pcuaRww630qEK/5odTyJ8lG4cNOb88j/pdDwyNx5e1QPAWK3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709716425; c=relaxed/simple; bh=Qk/DgjzzjMSGlkOr40MEBE4bLbSg4IfJnGTatQO/eMo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BNbipkvKxvxIpq9boWGfI025O94RoHdKXFLg86r1mX9RsY9p/7d6uEFTsfLJ9X1FGy4CNd/wsIRYm6uQaTWI0H638WnltInRaTEug6rylCChGCcE1qSH4lAdbMvdnPBXM9zv8ejxBIatM1IPkYoDART97T0XROv830JJ4GABoCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu; spf=pass smtp.mailfrom=szeredi.hu; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b=bhBhU5fN; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=szeredi.hu Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a449c5411e1so662967866b.1 for ; Wed, 06 Mar 2024 01:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1709716421; x=1710321221; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qk/DgjzzjMSGlkOr40MEBE4bLbSg4IfJnGTatQO/eMo=; b=bhBhU5fNwZ5NqT0bjBfmI8yYE8497uLD5ocbat8fgeLSUHkpHADu4CV6Px/N7I7wzg 5mKP+wC8FaeYdcidDoxMNECGlkyX5G9DEE+nGgi0lls+5HPUXm/Opo6mOPt0FA/iIH4H DIBbg1aujcIteGxEv9Zr4ci4GHnXD1eiZHVWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709716421; x=1710321221; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qk/DgjzzjMSGlkOr40MEBE4bLbSg4IfJnGTatQO/eMo=; b=fIk3YKKdwhAHJT3bHN8UOJ+4m6M6s8Wl8eY6Zv8Ru7DDKi7Gmtfi9YuV3E3LiMtlrX qDg/BPqJFbPPIUvz46Rxbdn26ua5Kk1ghB+8eh9q7mV8H3Mo9AJpIFcPEewMnpE6dLxo bSAzKehJlItw3of2UwI3nUbA+Sx5oqHLjANpUQeaawLBSWYRO/YBXYQIl/cfmMNj9+ft gCqJKXJHKbWeMM6X7ZX6p5+x+Ud6UykrDoLph1tGAyk5GmHSTFZu7dTGZBJEU6IUdUsl HssWSPZ3jsHXEIn4/fOozI7g+oo5uORfWfRpn8Qn7G4Vgg63yIDfNurO9SWEt4qTfEsz pdiQ== X-Forwarded-Encrypted: i=1; AJvYcCX38li3EqyTaF199JJzyg5ce4rLTcYYP50FFffL9/zsvvsXR5GrQ3JQAYyiuxSo0/MiNBfWLNhLPHjDHUaYAiWNSMWybEjTaXUFg+PK X-Gm-Message-State: AOJu0Yxn0MHgQO7q7cccdT6Ggm7Cn3Ry8r6Dj7uVPcxCkfqyXE1lTLdr CoVc+qA2WbjQYmDGqiRuJviEH4LMXzIYxrkO1hFUex9ZZ3uu+hHNPYirC/A6Y5sUCrAygD6+jOe uxtjL07JTBws//PNRosPN/4hJpSkZSr8K7QyjfA== X-Received: by 2002:a17:907:20b9:b0:a43:eb29:a293 with SMTP id pw25-20020a17090720b900b00a43eb29a293mr9389627ejb.5.1709716420766; Wed, 06 Mar 2024 01:13:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230608084609.14245-1-zhangjiachen.jaycee@bytedance.com> <20230608084609.14245-3-zhangjiachen.jaycee@bytedance.com> In-Reply-To: <20230608084609.14245-3-zhangjiachen.jaycee@bytedance.com> From: Miklos Szeredi Date: Wed, 6 Mar 2024 10:13:29 +0100 Message-ID: Subject: Re: [PATCH 2/2] fuse: remove an unnecessary if statement To: Jiachen Zhang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , me@jcix.top Content-Type: text/plain; charset="UTF-8" On Thu, 8 Jun 2023 at 10:47, Jiachen Zhang wrote: > > FUSE remote locking code paths never add any locking state to > inode->i_flctx, so the locks_remove_posix() function called on > file close will return without calling fuse_setlk(). > > Therefore, as the if statement to be removed in this commit will > always be false, remove it for clearness. > > Fixes: 7142125937e1 ("[PATCH] fuse: add POSIX file locking support") > Signed-off-by: Jiachen Zhang Applied, thanks. Miklos