Received-SPF: pass (google.com: domain of linux-kernel+bounces-93612-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1fafd225-e647-4a60-bd95-af12ad243182@quicinc.com>
Date: Wed, 6 Mar 2024 14:47:52 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] slimbus: qcom-ngd-ctrl: Add timeout for wait operation
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
        <srinivas.kandagatla@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
CC: <quic_msavaliy@quicinc.com>, <quic_vtanuku@quicinc.com>,
        <quic_anupkulk@quicinc.com>, <quic_cchiluve@quicinc.com>
References: <20240304134228.16627-1-quic_vdadhani@quicinc.com>
 <8dbcd393-580b-4c29-9d6f-42988a5e7655@linaro.org>
Content-Language: en-US
From: Viken Dadhaniya <quic_vdadhani@quicinc.com>
In-Reply-To: <8dbcd393-580b-4c29-9d6f-42988a5e7655@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 3/6/2024 2:49 AM, Konrad Dybcio wrote:
> 
> 
> On 3/4/24 14:42, Viken Dadhaniya wrote:
>> In current driver qcom_slim_ngd_up_worker() indefinitely
>> waiting for ctrl->qmi_up completion object. This is
>> resulting in workqueue lockup on Kthread.
>>
>> Added wait_for_completion_interruptible_timeout to
>> allow the thread to wait for specific timeout period and
>> bail out instead waiting infinitely.
>>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> ---
> 
> Fixes: a899d324863a ("slimbus: qcom-ngd-ctrl: add Sub System Restart 
> support")
> Cc: stable@vger.kernel.org
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
>>   drivers/slimbus/qcom-ngd-ctrl.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c 
>> b/drivers/slimbus/qcom-ngd-ctrl.c
>> index efeba8275a66..c27076d8b7db 100644
>> --- a/drivers/slimbus/qcom-ngd-ctrl.c
>> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
>> @@ -83,6 +83,7 @@
>>   #define QCOM_SLIM_NGD_AUTOSUSPEND    MSEC_PER_SEC
>>   #define SLIM_RX_MSGQ_TIMEOUT_VAL    0x10000
>> +#define SLIM_QMI_TIMEOUT_MS        1000
> 
> This could be inlined instead

Updated in v2.

> 
> Konrad