Received-SPF: pass (google.com: domain of linux-kernel+bounces-93644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <add78cb6-1fa6-4a1f-b846-899a21fc1308@oracle.com>
Date: Wed, 6 Mar 2024 09:41:16 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 04/14] fs: xfs: Make file data allocations observe the
 'forcealign' flag
Content-Language: en-US
To: Dave Chinner <david@fromorbit.com>
Cc: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, axboe@kernel.dk,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, linux-block@vger.kernel.org
References: <20240304130428.13026-1-john.g.garry@oracle.com>
 <20240304130428.13026-5-john.g.garry@oracle.com>
 <ZeZq0hRLeEV0PNd6@dread.disaster.area>
 <f569d971-222a-4824-b5fe-2e0d8dc400cc@oracle.com>
 <ZeeaKrmVEkcXYjbK@dread.disaster.area>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZeeaKrmVEkcXYjbK@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bHNVWW13cVJ3Z0F1QlZVM2ZPZE5hZU5sVEEwbWcwalVwU3B5Vnk2b3VQK2ll?=
 =?utf-8?B?TThhUk1ZNWNQVFVWSkJCM2x0OXhuSjNpSkNGNGRwS3lNSmMxYUJsUmFYOTFY?=
 =?utf-8?B?RFd4UXFFWC9HcytucFZWeDduUGg4NG8zelVFaGlIZXcrT3lCL1I1ajFua2hQ?=
 =?utf-8?B?Y1Z0Z2tLM05QZ2hIUTFUWjVsM2h3YWZsUXZ3V1QzZzdtdjlBSWdBK2FPbzFl?=
 =?utf-8?B?UWxpREI3V0Z6ZXZNL0ZSUEJtVFhBdnp3dnNGdjhka0tmZ3M1VzlCWlBpL0NG?=
 =?utf-8?B?TUdsWlJ1SEZPVWpOMzIzTEpuSXhUQVBkUzdOcWtUVmhIV2ZId3cyQWRJRnZJ?=
 =?utf-8?B?YjcxbFl4eWhSWWZocUFCRlR1S0Z3MEl6TzZUbGhGNnpFSGo0MG5TTmxDdzlY?=
 =?utf-8?B?QlE2UEpPdGZOSk9SSUU5SStkQWdCSCtZYU5lb1ZvOWptWXpPd1FGTXpIUHFN?=
 =?utf-8?B?aWlEZEtTSUtmanF0T0pNRENXRDQ5S0hsTHRVRWw5OWV0WFBXMTBIK0kvUFI5?=
 =?utf-8?B?MmVSN3Q3S3hwcDdUUWwwb0pVVWt4blpCTXhRSGF5TnpicyttWWh5UUV0UUhu?=
 =?utf-8?B?bW5rcmhYWGo4T1pVa2RIbWk1bzBFMStML1h3MnRjUlg0VDZxYUFaM0Rrd2JF?=
 =?utf-8?B?dVRObG41cm5CRW1PZEgrekhMZ0pVK1ViNlVGNVRIV0NCS1h1SHhsQ3FLY1BG?=
 =?utf-8?B?ZWtUTC9tT1ZPTHpUa0VCdXJoV3hWZXpDVG9ZdkhUaUJVY1dRd24rMStpeVBC?=
 =?utf-8?B?Q2RVVDdtL2QvWGQxU2RCSVZEdG1Jd0JtbVY1OUVjUkZNMW9tbGp1SzFPTkxt?=
 =?utf-8?B?OVJPRDluZTBpQUtjU3JJUHRLWml5ZlNmS3ZqSWZnMUpnOVllQ1hHQWtrT01S?=
 =?utf-8?B?UzVoVGpSWXo1QjIxb3Y5VzFPTFA0RHdqOXYyelQzOGFCd0VyWm1LK3lFN05Z?=
 =?utf-8?B?YkluS09kdjg4aFBIU1lsYU16bENKMnV1ZG1LNEo0QUFNaWxIdjBsd1Y2a1ls?=
 =?utf-8?B?c3VjNTRxMlNoRCtISzNYOUZHalFDNXJvWk9SeUxPQWFDemRXaW9DV250T2I0?=
 =?utf-8?B?WGtvVXdtbHJ6aXZOMnJMZG1RN3I1N0RlUmJSVnJPZnFxTzJqMnpuMitMdkVo?=
 =?utf-8?B?bVlvQVdXR3RUV2F6ckl6Qy9DYkFqVFRVN2xVc3RWdDl3K0gxL1pUMjNVV2ho?=
 =?utf-8?B?Y0JmMFVwQU14WjBqMHhTRDk1OFdiSlIzRUEwRHFKalNuaExiUTFCOEptbVQ1?=
 =?utf-8?B?SStTdTFEVCt0d21UaVl6UmxMSDVLNm1DVWxicmMrOUFvSmd2d252TzM1QjIv?=
 =?utf-8?B?YW5vdGk4d0RjQUIwU3VDVmRHa1pqa0h5TUszS2pHWEI3a2RyS2laT0JOcDNB?=
 =?utf-8?B?dEtMQ1QrRTNOaGZjSXhldjllRW0rSFZzWUdxOHVzTm9wbDZad1NQZEtBK28v?=
 =?utf-8?B?V2haYUtkeGFjWWlYQytGZmJXemxQTUxlRWxHQkpQcG5RazZLRU00R2g5NUlR?=
 =?utf-8?B?b3Zjc0hBNE52YXZCRThrK0RoZ3pFRDB5QlpxWGRiYmtvait5Sm5pb1ZKSUp1?=
 =?utf-8?B?R08wemhScTFUMVQwdDYxU0RVQ3ptUEVmTnFMOWM3c0JLNStFREtGQm1ZdXhM?=
 =?utf-8?B?aVhkei9UUHFDMSt3RE9iUktMT3I0ZUpwZnFCbmFmWGIvYXNhc0lJM213VU9O?=
 =?utf-8?B?anN5NHdVLzRpemtYUmk5ek1rbUNCU09jMmFYQmd0c0lHMU00aUo0WThtOVVN?=
 =?utf-8?B?WVlwVmhwbmZobkhlWllDeXJIUGhCUERWVzlKL20vMkhiRWhxL0Q0NzExcldE?=
 =?utf-8?B?QzlpYkpjWHFGZ3NqZnJJaHZHdWZSZko5QUxxNEF1eUpCeGNVeUwweWJpMjRE?=
 =?utf-8?B?NkZ1NkZGMGNrUzd3cHFqS0d3MThBTFB5aFRXM3M1VHNHalFtZkJrbnpJV0FE?=
 =?utf-8?B?V2xaRnRhOW5mNXBFTGRNNVBiOXY1cGNGdnc5SWpReXJzcDJOQ2dKM3FLUmhn?=
 =?utf-8?B?RXdpejJKQnU5NGJsTU5RcWJrNzBYY1RENTU3R3Fpc0RERmZjb1FoWGVSM2Rp?=
 =?utf-8?B?TWRzWnBKa25nTEROU2RsZVFlSjlhS1AzZkpXcWt6MllrcUMrb1JsVzg4blpM?=
 =?utf-8?B?bVVoUFc2Qm5QbXp0eStvRERaWnVwSXI1RTNEWkNWQyt3NWpiZVZlL0pzdnFN?=
 =?utf-8?B?K1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	C8oyzya0gqEgzJx5YzKp3eoYc6o2X503MqstHWkbdButEbWTnVHjGKdv7xvk+HIeLGDtcNGVVuEHg22gEH6QyK1UaqZEphaUB7QCqiPmk/b3/Z2Hm1Ey4VjZh4yDPrkWZ8clc6fyYq+jU1QaGSQH0ft6ChcT6Nc++GWLWp/PfIAVHynz78Muf+aRs0cfwYpxA8R20hEBgwMmEAhm5JPNiRUHuKWcTNSab2y7Nc80h22dnwOww0YhkdYbheB56dN9u0fuD0D4EDnimMeNkd/3gnCZimGGmodgLNgYqPS9jnr9ncf48jMrThYoSPul3NzeeKZZxSC+sQ1z7MG3d0mm82tkV5Msm819/lB3FJ31hGLHC1eZU5Yccydnm5huXRncLAas0CXwf3FH00Ou4AP7sXaGIXr/Gw4C6lhlhXOmAXhCnF8auAKgcWYHS1WWyelZcrs5dgw7p6BFxQT8ec7ONDwy1Ts4KGM6F17GJdMSjMNlzo0rflCXiq7fNcLTxYhX569+xXQJsnVzZhFXsvoFCiUMkOo4E7ywW+VxRlIoWOQ2o8wWnwkweKAV/TBeTfaZepdjT4tUp7gzhHeqCA589BK6vDHOHR6pG34LnGKbH88=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94bd2122-b460-412b-642d-08dc3dc194be
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 09:41:21.5259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S0loEBKkTWNY+7rHZQ+HHmZNIMhEnbdBLFPgjFC7370kP2+HnRujky/JoVZE+RpWq5C37HW2NepUO45ArOIz/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6811
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-06_04,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403060076
X-Proofpoint-ORIG-GUID: jcPJ971ekbqVOW9Oqfc9BoSBdQixAVCa
X-Proofpoint-GUID: jcPJ971ekbqVOW9Oqfc9BoSBdQixAVCa


>> Please note in case missed, I am mandating extsize hint for forcealign needs
>> to be a power-of-2. It just makes life easier for all the sub-extent
>> zero'ing later on.
> 
> That's fine - that will need to be documented in the xfsctl man
> page...
> 
>> Also we need to enforce that the AG count to be compliant with the extsize
>                                        ^^^^^ size?

Yes

> 
>> hint for forcealign; but since the extsize hint for forcealign needs to be
>> compliant with stripe unit, above, and stripe unit would be compliant wth AG
>> count (right?), then this would be a given.
> 
> We already align AG size to stripe unit when a stripe unit is set,
> and ensure that we don't place all the AG headers on the same stripe
> unit.
> 
> However, if there is no stripe unit we don't align the AG to
> anything. 


> So, yes, AG sizing by mkfs will need to ensure that all
> AGs are correctly aligned to the underlying storage (integer
> multiple of the max atomic write size, right?)...

right, this is really important

> 
>>> More below....
>>>
>>>> +	} else {
>>>> +		args->alignment = 1;
>>>> +	}
>>>
>>> Just initialise the allocation args structure with a value of 1 like
>>> we already do?
>>
>> It was being done in this way to have just a single place where the value is
>> initialised. It can easily be kept as is.
> 
> I'd prefer it as is, because then the value is always initialised
> correctly and we only override in the special cases....

ok

>>
>> are you saying that low-space allocator can set args->alignment = 1 to be
>> explicit?
> 
> Yes.

ok

Thanks,
John