Received-SPF: pass (google.com: domain of linux-kernel+bounces-93679-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <84970313-4ca4-4195-6a06-fd7a0d925648@quicinc.com>
Date: Wed, 6 Mar 2024 15:24:19 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 14/20] media: venus: pm_helpers: Remove
 pm_ops->core_put
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Stanimir Varbanov
	<stanimir.k.varbanov@gmail.com>,
        Vikash Garodia <quic_vgarodia@quicinc.com>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Andy Gross
	<agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        "Mauro Carvalho
 Chehab" <mchehab@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
CC: Marijn Suijten <marijn.suijten@somainline.org>,
        Stanimir Varbanov
	<stanimir.varbanov@linaro.org>,
        Mauro Carvalho Chehab
	<mchehab+huawei@kernel.org>,
        <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "Dmitry
 Baryshkov" <dmitry.baryshkov@linaro.org>
References: <20230911-topic-mars-v2-0-3dac84b88c4b@linaro.org>
 <20230911-topic-mars-v2-14-3dac84b88c4b@linaro.org>
 <ec239f69-6ace-c4a4-409c-771f1d24ce81@quicinc.com>
 <d19bd56c-dc85-46ee-831d-e67768ccf6ed@linaro.org>
Content-Language: en-US
From: Dikshita Agarwal <quic_dikshita@quicinc.com>
In-Reply-To: <d19bd56c-dc85-46ee-831d-e67768ccf6ed@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 3/5/2024 4:22 AM, Konrad Dybcio wrote:
> 
> 
> On 3/4/24 07:57, Dikshita Agarwal wrote:
>>
>>
>> On 2/10/2024 2:39 AM, Konrad Dybcio wrote:
>>> Without an OPP table and with vcodec_pmdomains_num (so, v1, v3 and
>>> sdm845_legacy targets), core_put_v4 is a NOP, jut like core_put_v1.
>>> Unify them!
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
> 
> [...]
> 
> 
>>> -static void vcodec_domains_put(struct venus_core *core)
>>> +void vcodec_domains_put(struct venus_core *core)
>>>   {
>>>       dev_pm_domain_detach_list(core->pmdomains);
>>>   
>> what is the base of this change?
>> I don't see dev_pm_domain_detach_list in mainline code.
>> Am I missing anything here?
> 
> The base is specified in the cover letter.
> 
> The code in question is indeed here since January, perhaps
> you're looking at something older than -next.
> 
Thanks for the clarification, I was looking at media tree which
surprisingly doesn't have the base change.
> Konrad
>