Received-SPF: pass (google.com: domain of linux-kernel+bounces-93712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231007153956.344794-1-shikemeng@huaweicloud.com>
In-Reply-To: <20231007153956.344794-1-shikemeng@huaweicloud.com>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Wed, 6 Mar 2024 11:09:28 +0100
Message-ID: <CAJfpegtjB1RufZBRTJ0wh_xdtbOdGkyuxVV9kNV98WxbUiqQFw@mail.gmail.com>
Subject: Re: [PATCH v2] fuse: remove unneeded lock which protecting update of congestion_threshold
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: bernd.schubert@fastmail.fm, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Sat, 7 Oct 2023 at 09:40, Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>
> Commit 670d21c6e17f6 ("fuse: remove reliance on bdi congestion") change how
> congestion_threshold is used and lock in
> fuse_conn_congestion_threshold_write is not needed anymore.
> 1. Access to supe_block is removed along with removing of bdi congestion.
> Then down_read(&fc->killsb) which protecting access to super_block is no
> needed.
> 2. Compare num_background and congestion_threshold without holding
> bg_lock. Then there is no need to hold bg_lock to update
> congestion_threshold.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Applied, thanks.

Miklos