Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp969720lqs; Wed, 6 Mar 2024 02:15:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVHT37Rz11lrwks+h9FLOvAMW3hfyMhStfX7Ap+v3lA53UQG5HkaRnk0SWb+jEg4QIUCf48eadtpu1P39387eS6IwsT2HK9MVXF4FBuOQ== X-Google-Smtp-Source: AGHT+IHgiFCC34gtnJoCPlfjbN/lUEKkpHyXxB6xmKMCE7t9rIw0F1hu8KEBTSrn220n9FiqK4D/ X-Received: by 2002:a17:90b:11c4:b0:299:61eb:c75e with SMTP id gv4-20020a17090b11c400b0029961ebc75emr12051171pjb.23.1709720111855; Wed, 06 Mar 2024 02:15:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709720111; cv=pass; d=google.com; s=arc-20160816; b=SEJl/e0N8P6trdCsFASfNjUdtFrBh0+U9nlNlHkS492lMpCZB7mf6U3K9hRgP5sKOz ISKk5ebYZaeOgyYktCWrVCf+OvQkW/8gAOgHXyZ6T/zGo8dyYU6u+78Oghg1MxIOPr/i efcw3mUy4aFGeLjJH6/LCl2N7G/XtCfYqQhlIwuDv34twfKbzFkYARe1hXk91SVXwbZu FzKpHfcYaAcLdZRVel175tcNGyQeKuz5HGNQU/DUYUnNY2+oPqW93bw9KqgZZksKYPpc veLDkFqB51iScjhAIdEz3KOFGXuC78xUr8QMuv1WQ0/VggZ00gf5j7XP486DR1x0l2kc sLiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from; bh=hQIl64sMkc4WZaDjsqBq75GIfgI1T3WDQ73P6HtKS7c=; fh=wle+AMEnMb9kuUAOUjruS2hT0WH4XyjrFu+GeVbWDBI=; b=SX7egBx1PbYZzmNcxJnWmKYUr48qD3Cg5qf5TyIcuXszxeCDB2MAZt3KhgR0Zfh1av cqTRdpI4TMiJ3NXhB0ccPFIE/adnmtb2/ni3iGjxYnNQIuuGZ1u3mCmfjQIgDkhU0yPT RKfbTfXiJKTxiuI5A4ROtf/gQI8fL3s2TsEO7apM61qOagxBpliIehPTDn1mJ1VQwgPV F9qd+BlQnNC87JNaSoK0uiTU7xVM3n/BMc/ZRlPZ7ESHsar0xoB8ttFQ6u6pMzvZwEDy bHEEXJxnrLC9UqhmL++z56X6B/3jQSD54hXL92Iw2ERGi0g7k0KVnSq2wnfMhP7E+1/w FsEQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-93720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93720-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b16-20020a17090a101000b0029b7857a18esi843500pja.18.2024.03.06.02.15.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 02:15:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-93720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93720-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B36F528606D for ; Wed, 6 Mar 2024 10:15:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DFC05F866; Wed, 6 Mar 2024 10:14:58 +0000 (UTC) Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id D84A95C911; Wed, 6 Mar 2024 10:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709720098; cv=none; b=ks0wkqOie7edlIp75l5jTeU4aBvzHwk7uqIpF+MBqq1DfY4MFV2UUxvtT16WB8hCsinE4E3n1V/OeHZ/7M9YAgGdjiMj3dNPQ8pnZHQ1mNOxR22Xq+X6BHb9+DXlXxZ0rCTuB1dg5qd2kAm3OOI9fBqfnuCwodDzRsopKHODk/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709720098; c=relaxed/simple; bh=UZ7/cWck2FA3uFUivhbIlq/keQvDrUcLIV3QGDzLZr0=; h=From:To:Cc:Subject:Date:Message-Id; b=WWZ/8Z5jYcSokkVSzDPYhTTGiK8wwk2MMDxEI6RaO8AgMqkJ94bDgL1FBRucMJTEnQmPBLO/U2h+V+ageCjPyNssmHgZWsO7kIhXMC+l+RRvPdwPeAqkkRuPtY6I7Rm3o9xqtwh/HfA9zzVHAylq4ihRxbx7TwRqV678pr57MiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id D407E60303ED2; Wed, 6 Mar 2024 18:14:51 +0800 (CST) X-MD-Sfrom: kunyu@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li kunyu To: jonathan.derrick@linux.dev, axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Li kunyu Subject: [PATCH] sed-opal: Remove the ret variable from the function Date: Wed, 6 Mar 2024 18:14:44 +0800 Message-Id: <20240306101444.1244-1-kunyu@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The ret variable in the function has not yet been effective and can be removed. Signed-off-by: Li kunyu --- block/sed-opal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index f62b7ee933f7f..25fdbb7e14ae9 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -3108,10 +3108,9 @@ static int opal_read_table(struct opal_dev *dev, { read_table_data, rw_tbl }, { end_opal_session, } }; - int ret = 0; if (!rw_tbl->size) - return ret; + return 0; return execute_steps(dev, read_table_steps, ARRAY_SIZE(read_table_steps)); @@ -3125,10 +3124,9 @@ static int opal_write_table(struct opal_dev *dev, { write_table_data, rw_tbl }, { end_opal_session, } }; - int ret = 0; if (!rw_tbl->size) - return ret; + return 0; return execute_steps(dev, write_table_steps, ARRAY_SIZE(write_table_steps)); -- 2.18.2