Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp983603lqs; Wed, 6 Mar 2024 02:50:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWqZxOVnuYH7eSaBRFuRfFDhNX0I5DqFtuhHxycYlXGv7qh9rvrIjlLwr1Yckq19XMf2whNxauOyL28hAzrQXAkhcfsh1KT5GRRo4MLGg== X-Google-Smtp-Source: AGHT+IHLiPTtkHGetnEBmNw3L/G7uFNhkjShIqfdqTn+/96DfG7EYk2wE2jU05MvTxEBz7rTgwzZ X-Received: by 2002:ac8:7d44:0:b0:42e:d5a3:e03e with SMTP id h4-20020ac87d44000000b0042ed5a3e03emr5018667qtb.53.1709722226570; Wed, 06 Mar 2024 02:50:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709722226; cv=pass; d=google.com; s=arc-20160816; b=k6i50PpDeeZ6YhHe8bRLPTXyeTxdQWsWHo7692lw3i8jQJQONYMPKoUffd4Rl5jYXL toTjpAFcvOatke0lb9F8bEn3MIfAGFWQzSDQDGblwB/DI7u3BhodVgu2hqcS41UIE/mw 3c66qqla1EbftkC7V36MQyMct4C2AkIhUIvwK/ixskS/Jetz+ykXWdgUZFOcH3MvDwZX JtfZe1Sd6K6GyjoWYu/5P2OTyc2jAlTKidjbBje5sgvxQrTNHbMdapxjHLDu7Gr+p8wo UFW73EFEupl65bmLR1nMaPeJYq42bHUGMyCf21TpclX9vNmfO/ghAsEKFbaj19EXInAp OuGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=kCnWZ1x7u1ZRj4hgLqLjcR+fsanLqjl0nvZjh1lNmoI=; fh=HDEXumAcspvpwuyF44zs0bbtnm+nXE2+gcnnbPKzHJ4=; b=ToyxpquV0ZDK8zbLbj/JLJBDkbNKJ4YSBeU+SPm2zlXz+d0kNqEhFbCBmpWXeNNRNU LaOkKnqYPJOj8REDwg6S/1TwSKpelHkci06vkfZH042DIkUSTcJKX06jBr7iXPwEjrQa ilt/B5ozBInb8QwD7et9i8p5RZFLh5U444guP0Wj/rjrrVqZhqJSErak3MDcbV5wIMK7 o244lA0bUGL3V3xdTx2k/AE6IXnLSb+O3KffzT5elwyAKXBQEckrMi92z2lFH74E7f7w IvI9PiVJHcQjFpRMBCy+0rqdpnGW/Mcznq9NzlVvpfs6ULceLIWs1aYZWcDUeMED85vj FVHQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U1gzvKde; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-93804-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93804-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c9-20020a05622a024900b0042ef287a016si6660700qtx.99.2024.03.06.02.50.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 02:50:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93804-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U1gzvKde; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-93804-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93804-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4F1581C20C9C for ; Wed, 6 Mar 2024 10:50:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C70D3605A2; Wed, 6 Mar 2024 10:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U1gzvKde" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68BF35FDD2; Wed, 6 Mar 2024 10:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709722220; cv=none; b=RgTv19VySXoz+cb52Ev1cL3rKmuuc8KhrnkAoGBm6xM4espMMzW4FFT8dEy7LOOOnsEmL+of7CdwkB3Vtw5wL2JRcBGuWJFF+3bBmoz/EXL2ohwyrllhbPJN8xCqxe4w3N07Yp0DzzwhN8pqRRENFkHhBwbH7PgM6rYAngf/p1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709722220; c=relaxed/simple; bh=/FQwOjsjlEXsuJlp+9wnACCslIvKGqy6TJS6hVnDSpM=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=a7J9ZJaHzuxQ376T9hKQpmd7ALCL1D/tIXJHHpa4lOpE514As12muMQ7gEjdju0QVIfnjfLTk6btXVVV7Wmg2ZitNI2yl7V99pyBR7LTmWrwbVVcvOOIgaRRan8HMc8sgVfNKNZkQRI6ne02nfqpLkemFrFIcSlO5pmERIrVJnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U1gzvKde; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709722218; x=1741258218; h=from:to:cc:in-reply-to:references:subject:message-id: date:mime-version:content-transfer-encoding; bh=/FQwOjsjlEXsuJlp+9wnACCslIvKGqy6TJS6hVnDSpM=; b=U1gzvKdeI0onrymFaAShjZAbTUAczFLnHIrpCFJVCtQSpOf7wnOKE1Mq LtVQ8VRYqFCTKBgbhH/T5gQyQ0i93HAwkKlbTo/KD3GK5appwdzvSvge8 vN06GMR3z2oThZ86xFED4Sfn2JW0xpjF83qF4YSIOuw+jpET4zcO13ISC bCKvATWFAgtIUOCxXq6AfVRqWBMre5qYMF/5NfDKpYqN5PVM+evJjBFUR L1ioQC9M8xtpl2GGABZoYhe0X0SjveQsAHF6J981jFJuV4PgacR5g/kwp C2+CHIiTTa0/JzbzMXw7n9alir096kUpceAkJVUQiiYutrlgbzzN/OwMv g==; X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="8143242" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="8143242" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 02:50:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="14394664" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.244.146]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 02:50:16 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: Shyam-sundar.S-k@amd.com, Armin Wolf Cc: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240304205005.10078-1-W_Armin@gmx.de> References: <20240304205005.10078-1-W_Armin@gmx.de> Subject: Re: [PATCH v3 0/4] platform/x86/amd/pmf: Fix policy binary handling Message-Id: <170972220931.2521.8343066824996760779.b4-ty@linux.intel.com> Date: Wed, 06 Mar 2024 12:50:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Mon, 04 Mar 2024 21:50:01 +0100, Armin Wolf wrote: > This patch series fixes various issues inside the policy binary > handling code. > The first patch makes sure that a valid error code is returned upon > failing to start the policy engine, while the second patch drops the > usage of readl() on non-io memory. > The last two patches fix a possible out-of-bounds memory access when > parsing the policy binary header. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/4] platform/x86/amd/pmf: Fix return value of amd_pmf_start_policy_engine() commit: 98cfcece0ab86c99bc106633d764fb6ad4a35b8e [2/4] platform/x86/amd/pmf: Do not use readl() for policy buffer access commit: 379a7c64c4fa33315b504ede86a87188dc88fef4 [3/4] platform/x86/amd/pmf: Use struct for cookie header commit: a87d92223084f61d37da4952ad68634ea8a7caaf [4/4] platform/x86/amd/pmf: Fix possible out-of-bound memory accesses commit: 1e7a14ee259e2ff85be51bf36a7692b20233159a -- i.