Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1004448lqs; Wed, 6 Mar 2024 03:36:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV8Jlj15WKOXrrvq0mrnaYiwuvpAHMPVJ3UDCseh4Wy9aE2yLDu+Xwb/N1/o07h3VskePN+po4c/mjwOdGQFm+Qag7Znk+UpV9VdLymiQ== X-Google-Smtp-Source: AGHT+IE0iQL2cvHzj2f7lRmxq8IQR6LYxtSFYvvlb3iLsngWEAmTEq+bcNw1fSc+HNaJAY7Q5vSs X-Received: by 2002:a05:6a00:178d:b0:6e6:4350:b886 with SMTP id s13-20020a056a00178d00b006e64350b886mr4193636pfg.32.1709725016983; Wed, 06 Mar 2024 03:36:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709725016; cv=pass; d=google.com; s=arc-20160816; b=AxB7t8XvIysYytoewjs9qY2HNFruUelKj/2y91k4SW451lPfIrN3uW0lQwM7VjRouc ypA/U8F2XvkoqU5oOR2lBEe/Sr/dVRXnwCKWj7H4SawhTk+DsqLqg2eirLiYykL4MMWt iHD/fgdG9kYR/ISOd0/5GjdKZ3wrm0Ked95plH5uebXMKR7zWt41HhvXxGONaVLwsyNf U2T1E1JiVlfBhBbg42+um3sXjBwCMU9sJdkOnwH+JWnmeyNPYZvo3G5npgDVd7VLUnFv nsH7hL9JESPjeGP17Em7IfvIlh43BWoMFq5O7EZPTBn7jjX0QyyWT7fKHwMUOeh4vf89 LLLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=6uAOMX0RuCr7M6XK8anVwhoPbtBy8Gft5Y8twebfOr8=; fh=NoYEqG65JXYICdsF2fwjknOpgVNbRTmRM802hgqImIM=; b=a2bBg6D0aUbPegk9nXH7V/kXiKEjsSsbrOHiArvst/F64cVJkxz7YpH0XZ6ly28esB W0LaxNtEAKoJJ0fkvoTvXzS6BpP7aXxv1xzlBxJHPPMCcbUDENyjvEp6+CdHlbLxVmu0 S3PxXsZ/OWzdx0HUkBczx0WeUhlY4LKnnf/+GL33YFJz67PP4Tki1OfPAmnIWILqGseH XUXbSO02sgXqkavn8RXyQDT0Y7BXRIvtmKRxtq/ZKr5M2o95mTYU5eJv5jfX+2BDjQRz akDyeQUWmnTeQdvONojPA7eEkaG8nJfpkrwBypizN6+3TR05L4kCdmIrX7oNoCGxACMr kgRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ILnQe8IS; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-93850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93850-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e18-20020aa79812000000b006e558b4e179si11376150pfl.235.2024.03.06.03.36.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 03:36:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ILnQe8IS; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-93850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93850-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9EF962814DA for ; Wed, 6 Mar 2024 11:36:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 835BD7FBA3; Wed, 6 Mar 2024 11:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ILnQe8IS" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20B585FDDC for ; Wed, 6 Mar 2024 11:36:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709725006; cv=none; b=hUPvToqBl5VOuzw1YEdawavARUV5aXO9lc75bHSAYtgH0M/nMhLa9++VIbfb0MatXhiYzKEikfE9IRXA3D7UB0szy+VFRYYqwyN+nuTLJ07YRJhXuRFGnGjXeykejw9BDe3kWRY7Kk15wBOLhqWxglg1NkfRdorD029J9ig5Rqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709725006; c=relaxed/simple; bh=6uAOMX0RuCr7M6XK8anVwhoPbtBy8Gft5Y8twebfOr8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=SmGxMvp98KoRcWd4+BEIdxZ5WxxrHD0g38cCQ4FknhcCBuyfIp+Sk41B49Is6iMwGyJOc9Q6CGV8LG9gP+V1CYruQcSGFW19LqCNS45E4Q9yk/q0WxAOg8UkPQqgX/YigHT3d+rcJzKl5qxuuAIAaV+8OrB4zSyF09eDzyWv54s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ILnQe8IS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709725004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6uAOMX0RuCr7M6XK8anVwhoPbtBy8Gft5Y8twebfOr8=; b=ILnQe8ISEKRVh8vx8b8r1qzenuWdncDgyelzJlIV7Qp9fegqhRvtgeOj52qvj0+Drcpkxm q3diH71DS/93WI16Nh1H4umVhX3WKqKfx2SlIFCegPJncddVoffkpSBLr6Fkbg+p6kTeSN 15KivWfYZxeRjJuv7+v7j9snC6bOzz4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-l7HKRom8P2ia66y8lhAUUA-1; Wed, 06 Mar 2024 06:36:43 -0500 X-MC-Unique: l7HKRom8P2ia66y8lhAUUA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5131e2433d7so2103860e87.0 for ; Wed, 06 Mar 2024 03:36:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709725001; x=1710329801; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6uAOMX0RuCr7M6XK8anVwhoPbtBy8Gft5Y8twebfOr8=; b=eZ+C9H+CjbMB+a6gnXJNTqxqFK3Y7gRSpKiMuKQK3ftfNc3ULPWshWZRHAgUgllyaK ftLVyVBvyTSfvWo9ZXlAU+7Z3rfYbdAnaXl5yM/GNacdNRC/PGOSkcs0IWmkpPlaxTRM 93BAXrYlptU5Cx6ymxNJsM49eD5yLnse1A4wPfe7zFJI0kEx3FWuj00ExEk1v1mv8f30 y2QHQ6Wda6oB+Tqb9nPSl5R6heOChSFtsizwBNn1GbmXKpRkRRGWAkQ4Ljzpe+paxwuH B+t9L/mFuMbFvvD+XZGdKlL/rnFTBAKizIFVEjaa5W7ACUtyZYC3i72aik48mOq8jMnq KcLQ== X-Forwarded-Encrypted: i=1; AJvYcCWOAi20/mFJBIY6Wl6zw/2UJlcG55bDXv8tvH2ZFqWJpVCLJ9Q5msBu2XWo0nIq1FIR94GHhglt4IDKX4TqSxcaZ8bzjP7DRYl6avLJ X-Gm-Message-State: AOJu0YyG0CTfD47gnM3aABHkp39EeLJtTUzzi66Xgo4ESZn6Cpt1B5KR J0HubgymfIxDxbE85T2bPFr1fBRu7oreFmo07jvOKQa/I6jkP1ARjZRGbSl6732yAFix5+U0NZ0 23zXrRh+8EqfYy22CQ4yBx5n4WhBb4YxSPKbMQBYj976QQbsqAl+ltOY5aLD07k1L3NBFzg== X-Received: by 2002:a05:6512:200e:b0:513:4b49:e1e5 with SMTP id a14-20020a056512200e00b005134b49e1e5mr1650255lfb.1.1709725001207; Wed, 06 Mar 2024 03:36:41 -0800 (PST) X-Received: by 2002:a05:6512:200e:b0:513:4b49:e1e5 with SMTP id a14-20020a056512200e00b005134b49e1e5mr1650247lfb.1.1709725000800; Wed, 06 Mar 2024 03:36:40 -0800 (PST) Received: from gerbillo.redhat.com (146-241-235-19.dyn.eolo.it. [146.241.235.19]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b00412f02bff2csm3326770wmq.37.2024.03.06.03.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 03:36:40 -0800 (PST) Message-ID: <095ce1d0f2cd6771b30ab1d73ee6aa8e8460c7c8.camel@redhat.com> Subject: Re: [PATCH net-next] tcp: fix incorrect parameter validation in the do_tcp_getsockopt() function From: Paolo Abeni To: Gavrilov Ilia , Eric Dumazet Cc: "David S. Miller" , David Ahern , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Date: Wed, 06 Mar 2024 12:36:39 +0100 In-Reply-To: <20240306095430.1782163-1-Ilia.Gavrilov@infotecs.ru> References: <20240306095430.1782163-1-Ilia.Gavrilov@infotecs.ru> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-03-06 at 09:57 +0000, Gavrilov Ilia wrote: > The 'len' variable can't be negative because all 'min_t' parameters > cast to unsigned int, and then the minimum one is chosen. The above is incorrect, as the 'len' variable is a signed integer=20 The same applies to the following patches.=20 Cheers, Paolo