Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1034143lqs; Wed, 6 Mar 2024 04:37:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUvEJ7LugmxZcPPzwsfcu5s8lTZobwjhBqWKf0NfaO3jkMG5pVrmrtct2LLXZEW+F3hx29bIAnjK75PBHvYqVxuzAaRpclnmCVKJSBf0w== X-Google-Smtp-Source: AGHT+IE+vN9QZg3F/7WzQRnZZ5Mh+/Tlyl5mlxzozk5rddhvOJyI94brrp+zz7QXra8UMRwGCVOc X-Received: by 2002:a05:6e02:1d89:b0:363:d96f:6850 with SMTP id h9-20020a056e021d8900b00363d96f6850mr18478764ila.12.1709728627172; Wed, 06 Mar 2024 04:37:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709728627; cv=pass; d=google.com; s=arc-20160816; b=X6cqvMk0IsUZUNKHsw2NulBqWiGmJ4C9NiOg6X29EjGOYCfB22AGCZOv9Nskh0+kd7 dCnbo+aDq1yQMCGAKLhN5mBoRZLJVjkG2CHjaRSDn/vppSY4duxim2uyJR78Cp0JjEta Rh6uCdXaHlXWJNBd5Q4UlWmqWnHy6AW27NiWRO/CmsVVOC9oJPuwXqv+eNAM1hIKz8js cVom3RZ0oLCM7a2CpwkxcgA9jMLlqUGkaqxc5TZ/UnLqhu/QpyrBdrwJJ4DY27tna9aE 3WYWRQdkYhhKNo3M3QZ96LiXdjFSTbCVUEfEvCJ+7/vLuTnp5C+dZNW0z+vuZUIhcbvF cjug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=OMF4QDA/BIIwL+kdUSy1E5oYvYlaroCGSWt9+J3am6I=; fh=xsvI7l1HeEjfi9GLdU9i1+gXWs6iCG50UXVPhs7pR1M=; b=VZ+TG16H358ffpKNaIbSf+Iya0vJPGJwxBpDDZfdOrT4e26QIH7UQVizmjJC2hQIaE B3BzIGA/qrYOPzoStJ4w1e0D2s54QnEk3YGsAYNMZZIf6wuFifHAs2fRbFNDdRkZVE+P PP6Vq1nmsCSw+u3meDwZB+F5NQIgOO4IZ2MZGrKCOf+Kf650mCQNBYdlOFI2G7jeGlBq xVfCKErd99/WVWzYV7Xv/bcMkIIYNGWfX/31PPVy1OvMz6C1gqhLoe71lav0h2zrQqwo N4vyOTNr/diwx2nHKjdlzOz9qBDxnnry/q7S0StVYfuPmuV1hJSN7hwl2IerDvTw3tUf NbKA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zkKuuijP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zkKuuijP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-93898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x17-20020a631711000000b005dc88c4702dsi11816693pgl.225.2024.03.06.04.37.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 04:37:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zkKuuijP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zkKuuijP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-93898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 37EB2B2447C for ; Wed, 6 Mar 2024 12:32:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0A4F85650; Wed, 6 Mar 2024 12:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="zkKuuijP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Yol0huDH"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="zkKuuijP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Yol0huDH" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CED384FC4 for ; Wed, 6 Mar 2024 12:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709728273; cv=none; b=paVdTgyoMoRUal3Eua8iHjCoZjLeVu9DCmfNhm+CXvxWM+fc9uGrPIFVsgxfjHNVOAXBqFt5waBlW5NOMoFv1d2A0lDQ/DdkvojLxgDH/xZZFnNk49Uuj+pkRULxGYqQnL+NY4kdb11KSC6fFMdwU/K2fXDxWWU5mQi0Bp+6aAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709728273; c=relaxed/simple; bh=pkGnmJQ/2pBzk5rj4EVaNuLlwwgXwzwrSPkoY4ScGjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QtnotkYL99ewY4a1yVpm5K7cUXBrfU0AwUmp6q0qB/JcJ3a04BTyjki/agNcie6sqjcm6+NNrtiS6+9WpOKQwlo9Wx6VUOeTj1G78HTTKRJJ0cF0QWIw8bME80Sh5JHgZAa60XsPQpBrPc5R5+C2RZ/vh1AzKC6SbQ2MI7g40Yw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=zkKuuijP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Yol0huDH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=zkKuuijP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Yol0huDH; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BF4A0759C3; Wed, 6 Mar 2024 12:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709728269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMF4QDA/BIIwL+kdUSy1E5oYvYlaroCGSWt9+J3am6I=; b=zkKuuijPtkX3+HRHmbSvRGQBMjgF+6ket/HA3Smww4iLnhtgAZlQQfuL/JJ/dWrE+xXjRu QCZAg7b1kMx1Yu/WNaMSka4dNR7vLJhPP7jtJ1jzpP1pcoJOxXo4aj5rUxN0j8UEJG/KuC K7tJ6dXo3m5zI7bzctnDO4tUtU5CxWo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709728269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMF4QDA/BIIwL+kdUSy1E5oYvYlaroCGSWt9+J3am6I=; b=Yol0huDHb0VY+oMPN3hvChYMwd7AcGe8W7vBXgQ6s67q9g2lDhCyf5oZTlfcoho+IhYlmX LW/dNK8fE0YGPuDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709728269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMF4QDA/BIIwL+kdUSy1E5oYvYlaroCGSWt9+J3am6I=; b=zkKuuijPtkX3+HRHmbSvRGQBMjgF+6ket/HA3Smww4iLnhtgAZlQQfuL/JJ/dWrE+xXjRu QCZAg7b1kMx1Yu/WNaMSka4dNR7vLJhPP7jtJ1jzpP1pcoJOxXo4aj5rUxN0j8UEJG/KuC K7tJ6dXo3m5zI7bzctnDO4tUtU5CxWo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709728269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMF4QDA/BIIwL+kdUSy1E5oYvYlaroCGSWt9+J3am6I=; b=Yol0huDHb0VY+oMPN3hvChYMwd7AcGe8W7vBXgQ6s67q9g2lDhCyf5oZTlfcoho+IhYlmX LW/dNK8fE0YGPuDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 302E71377D; Wed, 6 Mar 2024 12:31:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id AJEaCQ1i6GUaTwAAn2gu4w (envelope-from ); Wed, 06 Mar 2024 12:31:09 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH 2/2] mm,page_owner: Drop unnecesary check Date: Wed, 6 Mar 2024 13:32:17 +0100 Message-ID: <20240306123217.29774-3-osalvador@suse.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240306123217.29774-1-osalvador@suse.de> References: <20240306123217.29774-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: 0.98 X-Spamd-Result: default: False [0.98 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[vger.kernel.org,kvack.org,suse.com,suse.cz,google.com,gmail.com,suse.de]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.72)[98.78%] X-Spam-Flag: NO stackdepot only saves stack_records which size is greather than 0, so we cannot possibly have empty stack_records. Drop the check. Signed-off-by: Oscar Salvador --- mm/page_owner.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 7163a1c44ccf..e7139952ffd9 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -865,8 +865,7 @@ static int stack_print(struct seq_file *m, void *v) entries = stack_record->entries; stack_count = refcount_read(&stack_record->count) - 1; - if (!nr_entries || nr_entries < 0 || stack_count < 1 || - stack_count < page_owner_stack_threshold) + if (stack_count < 1 || stack_count < page_owner_stack_threshold) return 0; for (i = 0; i < nr_entries; i++) -- 2.44.0