Received-SPF: pass (google.com: domain of linux-kernel+bounces-93924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <26f3e99c-8f57-4779-a679-2085e469d9cd@siemens.com>
Date: Wed, 6 Mar 2024 13:52:38 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] Revert "riscv/efistub: Ensure GP-relative addressing
 is not used"
Content-Language: en-US
To: Yunhui Cui <cuiyunhui@bytedance.com>, paul.walmsley@sifive.com,
 palmer@dabbelt.com, aou@eecs.berkeley.edu, ardb@kernel.org,
 xuzhipeng.1973@bytedance.com, alexghiti@rivosinc.com,
 samitolvanen@google.com, bp@alien8.de, xiao.w.wang@intel.com,
 kirill.shutemov@linux.intel.com, nathan@kernel.org,
 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-efi@vger.kernel.org
References: <20240306085622.87248-1-cuiyunhui@bytedance.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20240306085622.87248-1-cuiyunhui@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anpCa0xFcXcwUEZva21RZHg1S3V2MjlzYkYxWldpSFBvQWFrNVE2RmgycjVS?=
 =?utf-8?B?OW8wb0tsOWY4TEFQeGY0c285UXRhTnBLRzUwOHMyajdXa3QrcXYyV1lxMytK?=
 =?utf-8?B?VittT0J1K0krdWtDQ2lWQTRhZnNGbm5MYkdCeWxLVFZZbysraU4yUms0Tk8y?=
 =?utf-8?B?SUYwdFcxNWk2RktjcDFkTjRHeUJSdnJMdCtSeExBekxQZ0Q4eFVGcVB2Nmxz?=
 =?utf-8?B?UHowQkVQWDBrZDBFZ3hQaStVckVBV2pKUWRUTWF1eWwvWDJFSE1lQ3JJMWVo?=
 =?utf-8?B?T01rZkFrYW9zcm5aZkxnWmdVeEJKY2NiZGFIUTlQaWF3b1RnN3ArRm44SDdi?=
 =?utf-8?B?Z2hmVWduWkc5aWhHWG1MTGdQb3JJZmlkT0tyOTMrWS9mMkFVQnRuaGR4YzNU?=
 =?utf-8?B?dEFob2hocTRIcytLTUZvV1N5Z2kzZUxIbkRsbGkrdGxRR1RjaFpRWDRYNFg5?=
 =?utf-8?B?NGVObXRydGY3YTc4cW80Y3Q0WmZPSjhCRUx4WWxmdklWNU9JVktlRnllckhu?=
 =?utf-8?B?U0xTTE9TMEV2SW96cFRrVkVldVZIbEVGYndZUzFRSlptaFlQNzE4QnEzL2F2?=
 =?utf-8?B?QWNqdlpHeWlHdmpCdFFTL0VWd1RqMFZXNHdrQ0FJNWoxZlJkMTU3d000UTJV?=
 =?utf-8?B?UU1yTlJ0SkhIWEVxcWs2SHp6eUpuT3ptQStrQ3laODRkNzlSMHlyQzExM2ZW?=
 =?utf-8?B?NEtXQ3ZNeW5zdFpraEpmSXNGVDR3TzV0aVR0Yk5Xb3o1YThjeno3MCtMazk1?=
 =?utf-8?B?azdoZWdaZ1JjSElMQUo2ZlNPTkgrRTRDazRMMVNmRDNZNUlxQWhpQXpWYlU1?=
 =?utf-8?B?M1JhVWpNYXJQZzVFL2JxcXhMeWRqbVgyeUNnbVRTMzhqRWEwSGJjREI4OEZz?=
 =?utf-8?B?Qy8yRWY5aFkyNHlGOENKdWJlN2t1LytLTkdxSVZibWxtYkYyZ1pobkFkaVpZ?=
 =?utf-8?B?eG8rZ0RLa1hyUlg3V2xQZnhBejBBaTgzelkwZVpJcTNTNVlLMWVPS3Z0VXpY?=
 =?utf-8?B?V0pvOUlDQVdyNHozdGZMbGlNTXI5WkJhbDFvbk45RzRISkpTQ2VyTGU0RmEr?=
 =?utf-8?B?N25jZHgyVlg0am1UL25aakVQTUw5VkUzbEU4SEZWMDJsSXVUOWNzUk8vWk1H?=
 =?utf-8?B?N21IMi8rVFh3eVlHaU1zdFFBNzZIcVJISFplU0hFSkg3LzFveVVqMXdHVVlO?=
 =?utf-8?B?MDNFWVM2anFlcWcyVExYcEx5S0JoeXM0VlN5TmFQZ3p4UmxPL2NZUWtkT282?=
 =?utf-8?B?MWxOTTYwUHo4bjA5UzRXRDFvd1NXLytlVElOZDYzSzlGTFhheXBSTUoxbWVv?=
 =?utf-8?B?bHQya3FRMnQ5bDBnU1RlUUZYclJyUjVTNGlUT2U3K0xISnRqMGhydzNpZGt4?=
 =?utf-8?B?QjVsZjdDdUFSWTRvMjVlcFJvN0ZmRjQ1VEliNnloTmlsS1pPbDNyZmdKMm5y?=
 =?utf-8?B?OXUrbVFkV3NXa3pTOXY1UEhRdUxtMWNPYS9kbFpZL0N2S1E1UW1NSTZaQWpC?=
 =?utf-8?B?ZHFpYlZlZzVZbWRDcnRuQmQyQTV5Q2w1RWhVV0Z5ZVdiYUNVak1SUXAzdkVi?=
 =?utf-8?B?emIrNDJqNENyaTlOUFBOTnVvc0pYei8rbnlwZ0lNUlpDaEZBQVdaREROQUt5?=
 =?utf-8?B?NE1uemRjSmhDdXRjOXpNdTN1NzBNbWlvbkZqc0RqbWZ0VGRIWTlMdWRFSk1k?=
 =?utf-8?B?cnUxTzJaTFhZQVl6UU53OFc4QlFWaVZBV0M2WXlHVjhIVTdLTW1URU82MHhX?=
 =?utf-8?B?anpFYXpLKzNoeTlQSTN1dzU1anBVcXpZUXlVbzlwWDVPWit0dUdZQlBNOUZ2?=
 =?utf-8?B?ZlpDZjRoZjYwVGlVM2pmWUpZLzRBd2IzdW5BbGhkaTdjTnVKWmxmRm9rTDhN?=
 =?utf-8?B?bnpyazhnSFdjOWU3aUdyVWU5MUtJY3F2YUQzZnFYWlZvdE5iQi9VS2FuRWRq?=
 =?utf-8?B?OUlQRGlPSUkvQjRqM2NCczgxQngyb1VIenJRWHlqcGVhWWpWRFMrcjdXWEY4?=
 =?utf-8?B?YklTNUZaYklNWU9yRWJ0cFRWU3B2YlZYSXUrUDdEbmFiNHMwTUVlbmdoaUth?=
 =?utf-8?B?VExSMkJjOC92WDVaUUl5RG5ueGUxMm1ZNVB2djJIWXFBZW9GblVGNmltQWdo?=
 =?utf-8?B?Z2JFazhwN0tQQzZleWRsMmN3YlJERkdsRlpMZmhCOVRablRoZ2dwNjAxVFAx?=
 =?utf-8?B?Wmc9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f651963-77c2-40c5-3806-08dc3ddc4ee4
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 12:52:40.6379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hngz/CazQwvMNzzYoEBKRF5Yk37natODlOuw3Ph2S/Qnt6uwP6aFcpCwlzv8CwDToqNjdjdoBdxUCqVob8/pMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7984

On 06.03.24 09:56, Yunhui Cui wrote:
> This reverts commit afb2a4fb84555ef9e61061f6ea63ed7087b295d5.
> 

This comes without a reason - which is likely something around "will fix
this properly later". But then you regress first and only fix
afterwards. Can't that be done the other way around?

Jan

> Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
> ---
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index 31eb1e287ce1..475f37796779 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -28,7 +28,7 @@ cflags-$(CONFIG_ARM)		+= -DEFI_HAVE_STRLEN -DEFI_HAVE_STRNLEN \
>  				   -DEFI_HAVE_MEMCHR -DEFI_HAVE_STRRCHR \
>  				   -DEFI_HAVE_STRCMP -fno-builtin -fpic \
>  				   $(call cc-option,-mno-single-pic-base)
> -cflags-$(CONFIG_RISCV)		+= -fpic -DNO_ALTERNATIVE -mno-relax
> +cflags-$(CONFIG_RISCV)		+= -fpic -DNO_ALTERNATIVE
>  cflags-$(CONFIG_LOONGARCH)	+= -fpie
>  
>  cflags-$(CONFIG_EFI_PARAMS_FROM_FDT)	+= -I$(srctree)/scripts/dtc/libfdt

-- 
Siemens AG, Technology
Linux Expert Center