Received-SPF: pass (google.com: domain of linux-kernel+bounces-93970-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 6 Mar 2024 14:23:09 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	linux-doc@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, horatiu.vultur@microchip.com,
	ruanjinjie@huawei.com, steen.hegelund@microchip.com,
	vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com,
	Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com,
	Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com,
	benjamin.bigler@bernformulastudent.ch
Subject: Re: [PATCH net-next v3 01/12] Documentation: networking: add OPEN
 Alliance 10BASE-T1x MAC-PHY serial interface
Message-ID: <a9c8a5b1-866e-4ade-ad07-af715042ec9c@lunn.ch>
References: <20240306085017.21731-1-Parthiban.Veerasooran@microchip.com>
 <20240306085017.21731-2-Parthiban.Veerasooran@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240306085017.21731-2-Parthiban.Veerasooran@microchip.com>

> +NORX (Bit 29) - No Receive flag. The SPI host may set this bit to prevent
> +                the MAC-PHY from conveying RX data on the MISO for the
> +		current chunk (DV = 0 in the footer), indicating that the
> +		host would not process it. Typically, the SPI host should
> +		set NORX = 0 indicating that it will accept and process
> +		any receive frame data within the current chunk.
> +
> +RSVD (Bit 28..24) - Reserved: All reserved bits shall be ‘0’.
> +
> +VS (Bit 23..22) - Vendor Specific. These bits are implementation specific.
> +                  If the MAC-PHY does not implement these bits, the host
> +		  shall set them to ‘0’.
> +
> +DV (Bit 21) - Data Valid flag. The SPI host uses this bit to indicate
> +              whether the current chunk contains valid transmit frame data
> +	      (DV = 1) or not (DV = 0). When ‘0’, the MAC-PHY ignores the
> +	      chunk payload. Note that the receive path is unaffected by
> +	      the setting of the DV bit in the data header.

There is some odd indentation going on here. Maybe tab vs spaces?

Otherwise, this is nice documentation. Thanks.

	Andrew