Received-SPF: pass (google.com: domain of linux-kernel+bounces-93736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 6 Mar 2024 12:20:21 +0200 (EET)
To: Armin Wolf <W_Armin@gmx.de>
cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] platform/x86: wmi: Avoid returning AE_OK upon unknown
 error
In-Reply-To: <20240304221732.39272-2-W_Armin@gmx.de>
Message-ID: <a81d0ad2-d9d9-b85d-decc-3de314078f9a@linux.intel.com>
References: <20240304221732.39272-1-W_Armin@gmx.de> <20240304221732.39272-2-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1731533219-1709720421=:1022"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1731533219-1709720421=:1022
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 4 Mar 2024, Armin Wolf wrote:

> If an error code other than EINVAL, ENODEV or ETIME is returned
> by ec_read()/ec_write(), then AE_OK is wrongly returned.
>=20
> Fix this by only returning AE_OK if the return code is 0, and
> return AE_ERROR otherwise.
>=20
> Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus.
>=20
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/platform/x86/wmi.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 900e0e52a5fa..be0e772a87c8 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -1213,8 +1213,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physi=
cal_address address,
>  =09=09return AE_NOT_FOUND;
>  =09case -ETIME:
>  =09=09return AE_TIME;
> -=09default:
> +=09case 0:
>  =09=09return AE_OK;
> +=09default:
> +=09=09return AE_ERROR;
>  =09}
>  }

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1731533219-1709720421=:1022--