Received-SPF: pass (google.com: domain of linux-kernel+bounces-93983-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 6 Mar 2024 15:35:56 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [SPAM] [PATCH v1 5/5] media: ir-spi: Unify indentation and
 comment style
Message-ID: <ZehxPFh2ecxsKsOF@smile.fi.intel.com>
References: <20240305174933.1370708-1-andriy.shevchenko@linux.intel.com>
 <20240305174933.1370708-6-andriy.shevchenko@linux.intel.com>
 <hwtodfwrgonzzf2dpoqa3b5b3v66ypp7uu7upsnt6dx7weua2f@byxbgpxurhmf>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <hwtodfwrgonzzf2dpoqa3b5b3v66ypp7uu7upsnt6dx7weua2f@byxbgpxurhmf>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Mar 05, 2024 at 11:52:15PM +0100, Andi Shyti wrote:
> On Tue, Mar 05, 2024 at 07:48:30PM +0200, Andy Shevchenko wrote:

..

> > +static int ir_spi_tx(struct rc_dev *dev, unsigned int *buffer, unsigned int count)
> 
> this goes over 80 characters, though. Not an error, but not worth
> a change either.

It's only 82 characters and I consider this as an improvement in readability.
It's quite pity that some of the subsystems are too conservative, hope this
one is not an obstacle for them.

> I'm not going block the patch as the rest is OK.
> 
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thank you!

Btw, don't you want to either add your entry into .mailcap and/or update your
email address in this source file (and maybe others)? I Cc'ed you only after
I looked closer to the sources...

-- 
With Best Regards,
Andy Shevchenko