Received-SPF: pass (google.com: domain of linux-kernel+bounces-93988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: John Ernberg <john.ernberg@actia.se>
To: Wei Fang <wei.fang@nxp.com>
CC: Shenwei Wang <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Heiner Kallweit <hkallweit1@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, John Ernberg
	<john.ernberg@actia.se>
Subject: [PATCH net v3 2/2] net: fec: Suspend the PHY on probe
Thread-Topic: [PATCH net v3 2/2] net: fec: Suspend the PHY on probe
Thread-Index: AQHab8t46xO1JP3Hxke5Lu7SCFbkbQ==
Date: Wed, 6 Mar 2024 13:37:45 +0000
Message-ID: <20240306133734.4144808-3-john.ernberg@actia.se>
References: <20240306133734.4144808-1-john.ernberg@actia.se>
In-Reply-To: <20240306133734.4144808-1-john.ernberg@actia.se>
Accept-Language: en-US, sv-SE
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Since the power management is now performed by the FEC instead of generic
pm the PHY will not suspend until the link has been up.

Therefor suspend it on probe. It will be resumed by {of_,}phy_connect()
when the link is brought up.

Since {of_,}phy_connect() and phy_disconnect() will resume and suspend the
PHY when the link is brought up and down respectively, and phy_stop() and
phy_start() will resume and suspend the PHY in the suspend-resume paths
there is no need for any additional calls anywhere.

Signed-off-by: John Ernberg <john.ernberg@actia.se>

---

v3:
 - Only call phy_suspend() in probe, it is taken care of by the phy framewo=
rk (Wei Fang)
 - Update commit message to reflect the above
 - Drop fixes tag, this is technically not a fix anymore (Wei Fang)
    Should I re-send this for the net-next tree later, or is it still ok fo=
r net?

v2:
 - New patch
---
 drivers/net/ethernet/freescale/fec_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethern=
et/freescale/fec_main.c
index 8decb1b072c5..fb092b7bfe85 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2539,8 +2539,10 @@ static int fec_enet_mii_init(struct platform_device =
*pdev)
 	/* find all the PHY devices on the bus and set mac_managed_pm to true */
 	for (addr =3D 0; addr < PHY_MAX_ADDR; addr++) {
 		phydev =3D mdiobus_get_phy(fep->mii_bus, addr);
-		if (phydev)
+		if (phydev) {
 			phydev->mac_managed_pm =3D true;
+			phy_suspend(phydev);
+		}
 	}
=20
 	mii_cnt++;
--=20
2.43.0