Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1098293lqs; Wed, 6 Mar 2024 06:23:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVRanKAPS3OM/GUg15fJwmucrsvyR+v19TKVgirUEpVln10K2gImaBu+yK24j1CimgubLwXFa6uiaaqvI913O217Ygd1ieHkI37LHZYaA== X-Google-Smtp-Source: AGHT+IFCbjFyO6abuhVqvwX6Y59Z6E+ikiCR4UoCohoyXcEXXAmQKc8a/EBnoeCtSB0dirDw5dm3 X-Received: by 2002:a17:90b:3688:b0:29b:5b54:14b4 with SMTP id mj8-20020a17090b368800b0029b5b5414b4mr6815719pjb.31.1709734995124; Wed, 06 Mar 2024 06:23:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709734995; cv=pass; d=google.com; s=arc-20160816; b=E4om3ad3DeWKFaDOtoCjVQqnzAwTsLFBSXLOLGkLjMbA7QPL2flVbsbZCpAXmHHTWt GPUPeR7CXnv+XwZHWqU9PdwaWtdNiYG4m4TFNkln34wQTlMAmCwlOjACey2XKDAu8E1e bK2R0TqTeWfmD83eAjwhZAMDWHEUyXr0nOwY/kS+JT8h5iZIg7KU+TytZPBNU7Bz544L QHKXXbZaALuiT4okAvcY4kw1JlszSXzGXrpheswYX/KlZPByESkYzIQg/xkNZMeVRgPO /RoLzEBBAZHJyhdE1UJrBcZuhv069sEwJs/O27/v3w3y8R1mfc3XNjmPLlFdMNZICwYW n0eQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=Gu9bTqFbjX8kE0J0GowvQKt/2cUMGqw5BoSNIiRHniA=; fh=yzgV902SZvtAWODijA68sf59Y0fmtIqFWrJoQeI07Bc=; b=ifTyY4Ivqy+tm/oAu+eXQxM/iqIHuD9/g84952Tv1GHb5YP9clO8rUi4iFtDSlosvs b6fVQPID9OIs/t3hTV+cTCEplnM0F3JjRI0yY/GaeZHWyMWBf9itTuLCl5Ew9pOpMtfq /fcxZyqnSBGPH9MaY7xT6oxYavqUrnWrsxSwO7IHSG+CS/6mObAGI0T7LWx9MWDB6QFA dXNVUK7mG6S8X061d6msI+n6KvK8n0Siucs8UcLnkidSvinbWQdUPmVkGrgyqOXOefTy hePdaM65H3ZPx8c75lqwJuHaD5pau7HkeBQ77shN0e70nNguT/RRE3wcNS5+DiP7RKFh iRsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-94034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94034-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id v21-20020a17090abb9500b0029a890a03aasi11856593pjr.44.2024.03.06.06.23.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 06:23:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-94034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94034-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C98E4283739 for ; Wed, 6 Mar 2024 14:23:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20929132490; Wed, 6 Mar 2024 14:23:08 +0000 (UTC) Received: from 19.mo581.mail-out.ovh.net (19.mo581.mail-out.ovh.net [178.33.251.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC83E12C52C for ; Wed, 6 Mar 2024 14:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.33.251.118 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709734987; cv=none; b=O6w6Zbo5G0AVLAD7JXHGZg1Vdmz01Dex6oDNGn8hu1v0qOkPsGjq5xvBTwYdxJsBmdjg/RXEoTxKvkvB2vegr4z3JzrYo4MnViR96cJUKfObt5o0HCkNMkr3SxIwvgP2Lbjsxt8Rbdy/PekcbQICFUoYfJ2g0mN35QcVtJ87iIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709734987; c=relaxed/simple; bh=GScJtoRBAe4lkdk7YCQcaJqSxf7aTWrzfVxXIXxEmMM=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Bt6UHl1525AV/XwYEtpVK/V9NXf2KjHIgCdqnUc9Bu0KneB1fl8mUNBmIhf8Lv66LCbBzTYHQccpbI+NLy/I251Oenqe5fPtuAY4DZK5IBrinY8C7S9ryZuMbMX89gHB7oqfkf/o/i9PwVK41RJ/uAw1hwicvgMeMv/X72cq69A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=etezian.org; arc=none smtp.client-ip=178.33.251.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etezian.org Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.25.111]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4TqW926ptcz14nt for ; Wed, 6 Mar 2024 11:55:50 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-7smw2 (unknown [10.111.182.47]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id AC5801FF06; Wed, 6 Mar 2024 11:55:44 +0000 (UTC) Received: from etezian.org ([37.59.142.101]) by ghost-submission-6684bf9d7b-7smw2 with ESMTPSA id sAEZNcBZ6GXmNgEA++KPQQ (envelope-from ); Wed, 06 Mar 2024 11:55:44 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-101G0043716780f-fe81-4286-987a-6a321cced5bc, 62DEF991EB217AB86F953B10C2782167B22AFEEB) smtp.auth=andi@etezian.org X-OVh-ClientIp:89.217.109.169 From: Andi Shyti To: brendan.higgins@linux.dev, benh@kernel.crashing.org, joel@jms.id.au, andrew@codeconstruct.com.au, jae.hyun.yoo@linux.intel.com, wsa@kernel.org, Tommy Huang Cc: linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com In-Reply-To: <20240305011906.2745639-1-tommy_huang@aspeedtech.com> References: <20240305011906.2745639-1-tommy_huang@aspeedtech.com> Subject: Re: [PATCH v2] i2c: aspeed: Fix the dummy irq expected print Message-Id: <170972614153.1712532.8035778125665215281.b4-ty@kernel.org> Date: Wed, 06 Mar 2024 12:55:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 X-Ovh-Tracer-Id: 6468857915411270185 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledriedugdefudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevjghfuffkffggtgfgofesthejredtredtjeenucfhrhhomheptehnughiucfuhhihthhiuceorghnughirdhshhihthhisehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnhepffetheduffdvhfdugfffudfgjeejudehheegfeeguefhieeugffhgfeuffdvgfefnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepuddvjedrtddrtddruddpkeelrddvudejrddutdelrdduieelpdefjedrheelrddugedvrddutddunecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekuddpmhhouggvpehsmhhtphhouhht Hi On Tue, 05 Mar 2024 09:19:06 +0800, Tommy Huang wrote: > When the i2c error condition occurred and master state was not > idle, the master irq function will goto complete state without any > other interrupt handling. It would cause dummy irq expected print. > Under this condition, assign the irq_status into irq_handle. > > For example, when the abnormal start / stop occurred (bit 5) with > normal stop status (bit 4) at same time. Then the normal stop status > would not be handled and it would cause irq expected print in > the aspeed_i2c_bus_irq. > > [...] Applied to i2c/i2c-host-fixes on git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Thank you, Andi Patches applied =============== [1/1] i2c: aspeed: Fix the dummy irq expected print commit: 94e889260a5bae7d4c06de90f1724aeb8b1175c6