Received-SPF: pass (google.com: domain of linux-kernel+bounces-94040-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 6 Mar 2024 15:24:05 +0100
From: Maxime Ripard <mripard@kernel.org>
To: forbidden405@outlook.com
Cc: Michael Turquette <mturquette@baylibre.com>, 
	Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] clk: set initial best mux parent to current
 parent when determining rate
Message-ID: <20240306-inescapable-astute-bobcat-20c3e8@houat>
References: <20240306-mux-v2-0-92a5fa461fd2@outlook.com>
 <20240306-mux-v2-1-92a5fa461fd2@outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zf73hvuk44f6kich"
Content-Disposition: inline
In-Reply-To: <20240306-mux-v2-1-92a5fa461fd2@outlook.com>


--zf73hvuk44f6kich
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Mar 06, 2024 at 12:22:23AM +0800, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>=20
> Originally, the initial clock rate is hardcoded to 0, this can lead to
> some problem when setting a very small rate with CLK_MUX_ROUND_CLOSEST.
>=20
> For example, if the lowest possible rate provided by the mux is 1000Hz,
> setting a rate below 500Hz will fail, because no clock can provide a
> better rate than the non-existant 0Hz. But it should succeed with 1000Hz
> being set.
>=20
> Setting the initial best parent to current parent could solve this bug.
>=20
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>

That patch makes sense to me, but this changes the behaviour of the functio=
n.

Before, if we couldn't find a good configuration for the rate, we were
error'ing out. Now, we keep the current configuration. We should
document the new behaviour in the function documentation, and we should
probably run that through kernelci to make sure we aren't breaking any
platform (and from experience, we probably are).

Maxime

--zf73hvuk44f6kich
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZeh8hQAKCRDj7w1vZxhR
xYFUAQC64cGB/6QatYSjC3DnlztHH8x/x6LsjJUpD5B/vIbvVAEAmQ+PxbQ+4VTJ
iPySZ72xkzqMzdCHaGE2dgv/wYd63gk=
=+nPB
-----END PGP SIGNATURE-----

--zf73hvuk44f6kich--