Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1099654lqs; Wed, 6 Mar 2024 06:25:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUIF0NRS3XRNumLlxKs9h1Ug/fIJX3vB5ViSYrCmHaO1iUjHbpho0IngLIRqgkTaTJCeZtuwscYCUiBxyZsFKnjARuXlw6Rn7f8IJwlnQ== X-Google-Smtp-Source: AGHT+IEtylC7i0acoooEfxhM+HJTOwL5fbG+EO71vgVDmstSm7ODheGCdMUhtww+6WvG1tu9BkGo X-Received: by 2002:ac5:ccc7:0:b0:4cd:20ea:35aa with SMTP id j7-20020ac5ccc7000000b004cd20ea35aamr4499123vkn.8.1709735132738; Wed, 06 Mar 2024 06:25:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709735132; cv=pass; d=google.com; s=arc-20160816; b=VosWJ0avpF+ushpRw9888cVY6O16K9gI7jNjJmtZGqCDUaVT07KC6QA7vPZK5rAG63 SAVzYYquIVDqEso5DBIVQTh23S2V/P9Bso++B1xiXfIXP+TF3WIPtWd3bF3QYhEwKYe7 pkYifibRe5mFtsLK9E0Qg+siKkt4B2QMej7cdovSyKbnTF+mFKpfiovc+5sNj2l9Zvdf b4rpwYT53u9bKH01d5S0EYdk4Qc212FCjt8hYIZiUagOqtsviZ2lRAc3XtJAh28zFXTZ fYk3jvdh4yg2VVpam2u3bnHVj3UGDsAufE1MjVQ0KCwuCIX3xv9Z9lpOpaJpdWiDy4zX z9vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=Pj4bHbPI5AUECUQfSx2Ris/MdC5Q/VoaGT2RU4DqPlY=; fh=Uuyss4zIRMUVMMp0oURnCb0c5Ncwbn+5LGBycWvxdx0=; b=CvkQamciyGIYrbhA4NXNuRq3EbetHnlydMt/r5rR36vjcRW0uVpzCLVWkMatGTHZbB sg4mDIiU34mnrGUVzMPmFaXWQJ8f0UsvNc840UZcCo5kZwY9jDS/Wnqq8K0aRBbw8WyI 6pn3PIuSsT5o4cOAzoAuwPVVYfC8iyk2iORz2aLV/Cax4rU91j8hG7xiIOmkUjO3f98k SgwLtnbuYSgmPR4P4Ar/gDiCVIUKdc2jJPJ3iQKgTxxMk3LLww7Sj1Kk6KDYz0MvMEv9 sd0bfTPopAzNP8HyoNOV1N8OzjUuoxyRczz//OoFonebp8nEq70YN6bp1e1FfbSZcgFn 2AJw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-94042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t7-20020ac5c967000000b004c8048c464asi2074722vkm.24.2024.03.06.06.25.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 06:25:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-94042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6FA6F1C210A9 for ; Wed, 6 Mar 2024 14:25:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D4F8113248F; Wed, 6 Mar 2024 14:24:58 +0000 (UTC) Received: from 5.mo550.mail-out.ovh.net (5.mo550.mail-out.ovh.net [178.33.45.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC40060895 for ; Wed, 6 Mar 2024 14:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.33.45.107 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709735098; cv=none; b=twCmX4TgI6VlV0BBe8rM6H2dH3xrKeMrgHOpLzv0agZwD+rz+yHGcsj/BUORy9PHv1hWlqkUpYhEWDMZG3VqT32/B4L1R5OS0gbL88E7YAx8bWhlomsRRv37oEQwFYbhAwF5ILqJDJ0y/AH6vHs0kTRdZAvxK0JyXioofMZg+ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709735098; c=relaxed/simple; bh=r5/BbODiVYHKi4Vy9BlmKr5xBKMSKvqljtQVJe3nSwc=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=XZdTTe/zyExAfiG/OsQ/lHBmf4XHOJVFqB701GBEICFJQDIFoWpzc6ykz7O1l6wGprbkBOCbb099w9skxNDOUiVHGy22QDn/bl1rvejj8+3JJ4WIKod0qpaUutcBCGr2R8zHGS2DAw5GOhJz3vGyYIVbWptgm61mhJSTkozVYMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=etezian.org; arc=none smtp.client-ip=178.33.45.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etezian.org Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.176.170]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4TqW8n0x2hz1L27 for ; Wed, 6 Mar 2024 11:55:37 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-n2q92 (unknown [10.110.113.124]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id B275B1FE65; Wed, 6 Mar 2024 11:55:33 +0000 (UTC) Received: from etezian.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-n2q92 with ESMTPSA id xHmDHbVZ6GUUgAEA0v5T7Q (envelope-from ); Wed, 06 Mar 2024 11:55:33 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-107S0019a2d669e-ee64-4ca9-a271-21f25ef40524, 62DEF991EB217AB86F953B10C2782167B22AFEEB) smtp.auth=andi@etezian.org X-OVh-ClientIp:89.217.109.169 From: Andi Shyti To: Krzysztof Kozlowski , Alim Akhtar , Jesper Nilsson Cc: Naveen Krishna Ch , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com In-Reply-To: <20240305-i2c_exynos5-v3-1-17a749688806@axis.com> References: <20240305-i2c_exynos5-v3-1-17a749688806@axis.com> Subject: Re: [PATCH v3] i2c: exynos5: Init data before registering interrupt handler Message-Id: <170972613133.1712532.6066452137196640811.b4-ty@kernel.org> Date: Wed, 06 Mar 2024 12:55:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 X-Ovh-Tracer-Id: 6464917266006870544 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledriedugdefudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevjghfuffkffggtgfgofesthejredtredtjeenucfhrhhomheptehnughiucfuhhihthhiuceorghnughirdhshhihthhisehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnhepffetheduffdvhfdugfffudfgjeejudehheegfeeguefhieeugffhgfeuffdvgfefnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepuddvjedrtddrtddruddpkeelrddvudejrddutdelrdduieelpdefjedrheelrddugedvrddutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheehtddpmhhouggvpehsmhhtphhouhht Hi On Tue, 05 Mar 2024 11:50:00 +0100, Jesper Nilsson wrote: > devm_request_irq() is called before we initialize the "variant" > member variable from of_device_get_match_data(), so if an interrupt > is triggered inbetween, we can end up following a NULL pointer > in the interrupt handler. > > This problem was exposed when the I2C controller in question was > (mis)configured to be used in both secure world and Linux. > > [...] Applied to i2c/i2c-host-fixes on git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Thank you, Andi Patches applied =============== [1/1] i2c: exynos5: Init data before registering interrupt handler commit: 51130d52b84c473f5da5378aa7e7633611f79313