Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757463AbYAEUj5 (ORCPT ); Sat, 5 Jan 2008 15:39:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756880AbYAEUjr (ORCPT ); Sat, 5 Jan 2008 15:39:47 -0500 Received: from netrider.rowland.org ([192.131.102.5]:1189 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756854AbYAEUjq (ORCPT ); Sat, 5 Jan 2008 15:39:46 -0500 Date: Sat, 5 Jan 2008 15:39:46 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: Greg KH , Andrew Morton , Len Brown , Ingo Molnar , ACPI Devel Maling List , LKML , pm list Subject: Re: [PATCH] PM: Acquire device locks on suspend In-Reply-To: <200801052119.48542.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 21 On Sat, 5 Jan 2008, Rafael J. Wysocki wrote: > > Another thing to watch out for: Just in case somebody ends up calling > > destroy_suspended_device(dev) from within dev's own resume method, you > > should interchange the resume_device() and the list_move_tail() > > calls in dpm_resume(). > > However, if we unregister them all at once after releasing pm_sleep_rwsem, > that shouldn't be necessary, right? It's still necessary, because destroy_suspended_device() still has to move the device from one list to another. You don't want it to end up on the dpm_locked list. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/