Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1106601lqs; Wed, 6 Mar 2024 06:36:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXEXsltR1S4EVo1aKp4/0epaxC8IdDUm55MhE8WGPu3bOjJxspGNJZy75hKIAFGkPaRIv0/1k1WnN93FKl1bJDIxntOW9WbwsuqqNI//Q== X-Google-Smtp-Source: AGHT+IEg9OvxaR86y4UiKMysrYdfbn5LTspEkJpIsme7t0z3m033QAZ7wOIBsR97u+bSS5iDQYmb X-Received: by 2002:a17:906:b00c:b0:a44:c1a9:ee37 with SMTP id v12-20020a170906b00c00b00a44c1a9ee37mr9394365ejy.61.1709735760654; Wed, 06 Mar 2024 06:36:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709735760; cv=pass; d=google.com; s=arc-20160816; b=D5dZkpbt8kt/1tfgKk5j2q2IRC/2tIwTFHLejrsxYmgQLM4XjUMyvXMyxT5ZRYNRFg V+xRYFBIU233LvXanPrdTOB/BjD1Q+DblJaYSxtzuk0LRLuOfjcHPVAStWK04w/Arzms wp0H/kTwtPxAp5Eq1gECR+EZ2zEawa2o0WZvtfJW/nKKN3EQun2ZlJOFYDO/+OZgTnAM dQzZR8p1xqt/Q9Xnic/8j0VFJln4eib+tiBLilV9FImXQ5w1X2GZw80p3Xm9xZCbR1M/ OKdOldtKxO8sey5+X293rwykmfWs6xJcMYkULmZo2NS4bLlGrqcLtHggcqDxB85Xfceq z6Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=i//jDsTDtD6aipHKSJbo3y9InLD9ekcY4Q8bRAz7D0I=; fh=vxy6TUU0j1Yzhj4/lDT29UH0s6E3W+lhufi8g4Rzzv4=; b=RdZ9K03dgZHYXBHNR4XrN8vuMN/iSdsaiGxRx6dux+0B7Ehm6E983DDRiiVG/LKjZv mB5bE/yZWnVHsylyRX6OQx8xVSjU0gcKdCX260BPZzaJrSOSYUEqrp9tGqEV9TluOzwL V1hiiWDc6EBX1SYSiayd26rvxFHxN2yIWWPpRupcFy3NgRv0z8U+qCvJn2IbSEooXHHY QJjxOF9w7z5JqT+oC84HyZpzfQ25FOUihctReM6QBrw1p8iHkWxB+6kR6cXbSzhDDdNj 1Kx29pMe9IT4UQP0YYwKopd7GKGa5csAR4uf0OtprgYKDg5KuDAhh+9VfRyLHpR7wqh4 K1qw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4u3k3yn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4u3k3yn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-94062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gn34-20020a1709070d2200b00a44d53a08a4si4310294ejc.861.2024.03.06.06.36.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 06:36:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4u3k3yn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4u3k3yn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-94062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3D64D1F242DF for ; Wed, 6 Mar 2024 14:36:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 00846134730; Wed, 6 Mar 2024 14:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="m4u3k3yn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Q+rqqaEf"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="m4u3k3yn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Q+rqqaEf" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30DBE1339BA for ; Wed, 6 Mar 2024 14:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709735744; cv=none; b=RtevxPu7s4CIQCDBdAVh+vUKkdgOYge5j/NYJUKseZQiG9gvHFnGwrNh2ZKgsMhohtHo7GzvW08cyI+w1zQrxTj0h1+lRvo2yiJ3QuVHkJ+KIjbOvTkYiYe04oNdf/8PDoWcXsNokonM+OJALeEq9Y9CA6hzznTK1RT5vSjJuJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709735744; c=relaxed/simple; bh=Xr1vXBs9w5NHKfxraPFbNelfZmDu30dtkzsfnQyw8FI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IlY4JNuPC8WnN5p08f9JvMzmulabERMaMbdFb/o0Y7uWI2EDGefBVUp0r4VNRZ6bklbbMM7YVYAx9EnZiGu28l1ZmN97/E9p33/ROgbJKc+NvRY9OYO9IiPdxFp7eB0M79zunQF9c3I0LAJObMVvVSF3IiUWpT4152SWI0KnyNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=m4u3k3yn; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Q+rqqaEf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=m4u3k3yn; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Q+rqqaEf; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 46F616B282; Wed, 6 Mar 2024 14:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709735740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i//jDsTDtD6aipHKSJbo3y9InLD9ekcY4Q8bRAz7D0I=; b=m4u3k3yne6nn9gziGmKyJC1bqD6h90BtyE0ne1tka1Dq4kOzVEs0QdrQzXeu8+E1p9JDmg WrBGZQ0TIHy15Tw51d+FmeJHt+l31wLyS7hNDRDUY7nq1OX92qpVmtc9PNAh7qDhERhBE+ T4PCyFEoA0O8Ofm9EqCoyfWdCEJbV1w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709735740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i//jDsTDtD6aipHKSJbo3y9InLD9ekcY4Q8bRAz7D0I=; b=Q+rqqaEfdxrDJlwELieO87zVpiqsYl9MeocJVZaH1CNEP1Qd9PuVDHbcMrZy6guBliGcFw ppsPPBudgOFH/YCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709735740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i//jDsTDtD6aipHKSJbo3y9InLD9ekcY4Q8bRAz7D0I=; b=m4u3k3yne6nn9gziGmKyJC1bqD6h90BtyE0ne1tka1Dq4kOzVEs0QdrQzXeu8+E1p9JDmg WrBGZQ0TIHy15Tw51d+FmeJHt+l31wLyS7hNDRDUY7nq1OX92qpVmtc9PNAh7qDhERhBE+ T4PCyFEoA0O8Ofm9EqCoyfWdCEJbV1w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709735740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i//jDsTDtD6aipHKSJbo3y9InLD9ekcY4Q8bRAz7D0I=; b=Q+rqqaEfdxrDJlwELieO87zVpiqsYl9MeocJVZaH1CNEP1Qd9PuVDHbcMrZy6guBliGcFw ppsPPBudgOFH/YCQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 350E01377D; Wed, 6 Mar 2024 14:35:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 7n2DCzx/6GVEbQAAn2gu4w (envelope-from ); Wed, 06 Mar 2024 14:35:40 +0000 Date: Wed, 6 Mar 2024 15:35:39 +0100 From: Daniel Wagner To: Keith Busch Cc: James Smart , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] nvme-fc: fix blktests nvme/041 Message-ID: References: <20240221132404.6311-1-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m4u3k3yn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Q+rqqaEf X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.11 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.10)[65.09%] X-Spam-Score: -3.11 X-Rspamd-Queue-Id: 46F616B282 X-Spam-Flag: NO On Wed, Feb 21, 2024 at 11:04:13AM -0700, Keith Busch wrote: > On Wed, Feb 21, 2024 at 02:23:59PM +0100, Daniel Wagner wrote: > > As suggested by Keith I've merged the new flag for nvme-fabrics with the last > > patch. I also added some information why nvme-fc is handling the initial connect > > attempt differently as requested by Christoph. > > > > The new flag is called connect_async and the default is false/0. I've tested > > with a patched nvme-cli/libnvme version and all looks good. When this series is > > accepted I'll update nvme-cli/libnvme accordingly. Note, that even with an older > > nvme-cli the blktests (especially nvme/041) will pass with a newer kernel. > > > > (nvme/048 is still fails but this is a different problem. On my TODO list) > > Series looks good to me. Sounds like it's not fixing any regressions, so > I think this goes to the 6.9 branch. I'll wait till end of week for any > other feedback before pushing anything out. The second patch should be dropped in this series and replaced with the patches from Hannes '[PATCH 0/4] nvme: fixes for authentication errors' https://lore.kernel.org/linux-nvme/20240301112823.132570-1-hare@kernel.org/ Should I send out new version or do you take it from here?