Received-SPF: pass (google.com: domain of linux-kernel+bounces-94082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240229121650.33983-1-thorsten.blum@toblux.com>
 <CAKFNMomtp7ZwB0gmxoemp_ums4rqOSbfF2BMS6kX+LwtKYtvCg@mail.gmail.com>
 <19910196-DFF3-4F94-B6D3-B9BF722DF8B8@toblux.com> <BFEA2A31-3147-49EF-A9BE-592C90E783DD@toblux.com>
 <215C3176-D6E5-47CF-BC48-7A75CF75CE3F@toblux.com>
In-Reply-To: <215C3176-D6E5-47CF-BC48-7A75CF75CE3F@toblux.com>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Wed, 6 Mar 2024 23:45:48 +0900
Message-ID: <CAKFNMo=324Wq9NHPKNXf07w9tpGrE8bp=Rf-AiHqnM7VqbTZPg@mail.gmail.com>
Subject: Re: [PATCH] nilfs2: Use div64_ul() instead of do_div()
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 1, 2024 at 6:15=E2=80=AFAM Thorsten Blum wrote:
>
>
> > On Feb 29, 2024, at 21:40, Thorsten Blum <thorsten.blum@toblux.com> wro=
te:
> >
> >> On Feb 29, 2024, at 20:41, Thorsten Blum <thorsten.blum@toblux.com> wr=
ote:
> >>
> >>> On Feb 29, 2024, at 19:45, Ryusuke Konishi <konishi.ryusuke@gmail.com=
> wrote:
> >>>
> >>> All of the fixes in this patch seem to be correct, but this doesn't
> >>> cover nilfs_resize_fs(), nilfs_max_segment_count(), and
> >>> nilfs_sb2_bad_offset(), which also have do_div() that doesn't use the
> >>> return value.
> >>
> >> For nilfs_sb2_bad_offset(), where the dividend is u64 and the divisor =
is u32, we
> >> would need a dedicated function like div64_u32() that doesn't calculat=
e the
> >> remainder, which doesn't seem to exist. What do you think?
> >
> > Never mind, there is div_u64(u64, u32). I'll submit a v2 shortly.
>
> I left nilfs_sb2_bad_offset() unchanged in v2 because div_u64() still cal=
culates
> the remainder.
>
> Thorsten

I got it.

I reviewed and tested the v2 patch and it was fine, so I sent it to
the -mm tree.

Thanks,
Ryusuke Konishi