Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757586AbYAEVER (ORCPT ); Sat, 5 Jan 2008 16:04:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755922AbYAEVEC (ORCPT ); Sat, 5 Jan 2008 16:04:02 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:47181 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbYAEVEB (ORCPT ); Sat, 5 Jan 2008 16:04:01 -0500 Date: Sat, 5 Jan 2008 23:03:30 +0200 From: Adrian Bunk To: Randy Dunlap Cc: Al Boldi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, David Brownell , Greg KH , Andrew Morton Subject: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support Message-ID: <20080105210330.GC22232@does.not.exist> References: <200801051546.SAA08947@raad.intranet> <20080105113024.209485f5.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080105113024.209485f5.randy.dunlap@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 56 On Sat, Jan 05, 2008 at 11:30:24AM -0800, Randy Dunlap wrote: > On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote: > > > > > Select SCSI for USB Mass Storage support. > > > > > > Cc: David Brownell > > Cc: Greg KH > > Cc: Andrew Morton > > Signed-off-by: Al Boldi > > > > --- > > > > --- 23.a/drivers/usb/storage/Kconfig > > +++ 23.b/drivers/usb/storage/Kconfig > > @@ -2,14 +2,10 @@ > > # USB Storage driver configuration > > # > > > > -comment "NOTE: USB_STORAGE needs SCSI, and 'SCSI disk support' may" > > - depends on USB > > -comment "also be needed; see USB_STORAGE Help for more information" > > - depends on USB > > - > > menuconfig USB_STORAGE > > tristate "USB Mass Storage support" > > - depends on USB && SCSI > > + depends on USB > > + select SCSI > > We try not to use 'select' on subsystems and try to limit its use > to library-like code that is relatively small. Selecting SCSI > breaks both of those efforts. >... _You_ are trying to do this. For kconfig users, "select" is _much_ better than sending them through different menus. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/