Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1132219lqs; Wed, 6 Mar 2024 07:14:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVDN6bPQPaco/Ql6bOne3yUel/uvkMJQoeV2QMyTk12u/pEP9bVHfdK/+Wu2vpLG20NlQt7PLFb0glQ42aoB3fbcRVEDlU3/pWKL/jUgQ== X-Google-Smtp-Source: AGHT+IGySyht0CdNyXpEGNsvlL1ZM0T44nw6/cc/arCpunWVHK3Aayu+IUyMR8B0xm7oCPzGm1V4 X-Received: by 2002:a2e:9588:0:b0:2d3:7dcc:491c with SMTP id w8-20020a2e9588000000b002d37dcc491cmr3836529ljh.26.1709738082104; Wed, 06 Mar 2024 07:14:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709738082; cv=pass; d=google.com; s=arc-20160816; b=Zq4s0zTrjfoORaCbnEtz/HIkT4BaimGeClhH18xDBC90/5REUoDL21bxqXpAUb5gKJ F6Umc/uqFEJ0XOP41YOLFcxxTBHclajUbX1WR6y1K7AYA5AQFl6VGz2jAwq5/5WCA5tM e2ef7f9ONfSD9Mi77JaW2Jk7x86hEtUyC5jsHlX9cJYyMxuBPe20Xl3D0kdeOewBBfZd qAOQQ4gOph9WV39BQFCVO/exX3ZjHJTgeRqQzZVoLD2lvNQNNodOQFJSa4kYIgp05y8z bG3FgOnY63Nl440APRbcYTmBikXNZBUKO73ELf2EN89PBevqjgdL8/Tzm3Duz93FCGo3 hfYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; fh=jU05CMUzj24gi9A+H+0UEGzmSo0chOBujXb7LmKaseo=; b=WQXwzQB41qIzmAxT3dqdfpTmVfdVlricQNdAvzwHGOYY0ybEcUUbkq7XAKNV0yMmDq Z+NZPTagHfG4akhCWZpnL8yRyOCVeZH/AOrjtjgpLHCoI2m8j9dPzaRJex7xYB2Y8R9Z hUoFudkME6Kg7ClX4l4qWQ/OLADpZ8yvlap+gtPk25znZDrFAyGD+CM0cdVjzt6tYjD4 wgSzRR/Q816M5dyU0hOzhDkM2DTG10DcyAlhLXKBXPmrvGEhNmONGgMoEOcJlt6Qq24V TXJKzui9NlAd70CpoB5SxEaiORSdgLYY164vOX4if3r3TkgHEgr8VydQIu0m1AcbRbC1 y3Lg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=ZBRJ4Nw5; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-94139-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94139-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a66-20020a509ec8000000b005673a89e79bsi3333140edf.414.2024.03.06.07.14.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 07:14:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94139-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=ZBRJ4Nw5; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-94139-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94139-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A33311F2B145 for ; Wed, 6 Mar 2024 15:14:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 646C81350C0; Wed, 6 Mar 2024 15:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="ZBRJ4Nw5" Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0DEA5BAFD for ; Wed, 6 Mar 2024 15:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709738073; cv=none; b=e93mMfwncMLX0UPEincahqiTI/aoiXc09Lpn4iN0whJIX+hUyPFOs1VzjoEsvpoVQbyk/dYguG2hg0lLq57p/dgV9f/UVTul8kz7cgpQigJEoxf0qireKz3jlzwkfoaVpqCvAIaTS7TSbKaXP2WUW1lS5UFD1fAECM48RFC8DSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709738073; c=relaxed/simple; bh=V3aJ+mDpXol1LnRkVd8frXu/5mxpgid0TGJDT/7qC6Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AE8wM4wSFr7ZrEO6JIrl1elzRaLxuIVe1KPLtSDQuXYieoc4n2VURgNjbGD5uNqXaEf7Cw0k79HB4QcTi11SmXZajY9x5JePPq3kbLZdhOb9XmAfEQMiN/UvhMF2xEZ87EKJVcmhuZemYLgicWguD4Bvgo+j6U8uhwO7MYYtm8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=ZBRJ4Nw5; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-365b5050622so1958025ab.0 for ; Wed, 06 Mar 2024 07:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1709738070; x=1710342870; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; b=ZBRJ4Nw5kAKzT6hI1cTWI2uZxh8XH7Y2i+mBi+20T9bQa3MBPM2CcHYk3d2DXSLf1O 9MF9o2yE+qudRaFV75QWnAs2/jRaD2UyCjOX9VCsseIIqKjp6k04aB6YBD+irWxNbfE3 gjkPIY3iqf/uVuGV6D69c3UJYqfovaIqcMEjIyi7Gy1mTNzesJ9e1qmLFAAORaFY17wb dyBm1u3+T9dNG5XezU+Pv544xkY/OgUNfBnrgTdvz+eOxy/BAQBZjdteghJJq6KmlJTt yERTrgXkDQ9CtPo1qvmdJuSMWOIrzFbjjXYaXG0ZRDo3j+bTySPRtz/gDCvcX1cr28Qs 46Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709738070; x=1710342870; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; b=pV6UFZMdN3NtEMUVv0Rmpl1PSPlzrvbIoKUJk6uq0S+CdS1qro4MFvWVzLucf0KKkI KDNQCIgRW7uDKDgYhUsLlJ9MgFqEmD5EPlzAIC8glLw9jWaMzGmubIj3SLLHQ4NuLRd2 Nmb504Xq8ogff0JGKtUQy7kS/9S1bZmlhuOCMbDG7Si/mcRMntSINO0G4GV+AiUJ1gaE CQjpecrF3rqt6z0roT7uIQVGbsDbUav11fQ9uAI6U3WnjNAffrlON0WJDepL7PEXYOXn 6h44r1kqJxjMis1vS8ax/0hHkJWJEBobZAJJXhW07lwGAd1zi/9eIVhcgreLQTu0Qnw/ ydnQ== X-Forwarded-Encrypted: i=1; AJvYcCVb5TamefR6wD8srq17VYM1ySR7nBngfjzHQF2n0T3cF3K+3z+IwiaMMd4Y6Xc9VoJhCelHdtlG3ERiMl68JfF62a+RsGsMUfptTa2R X-Gm-Message-State: AOJu0YxfVO3pmc8yCeUrxERUfSfB8J9aYq20UV4i10JbHc1vXmgUwvVD 42ls/SJiyOAj6exOOP+0QZpl/ja4sN/DcwmxRsG70S7TVQlZfKqKC76PZqzY/8U= X-Received: by 2002:a6b:6611:0:b0:7c8:7471:2f59 with SMTP id a17-20020a6b6611000000b007c874712f59mr2532950ioc.0.1709738069617; Wed, 06 Mar 2024 07:14:29 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id y16-20020a027310000000b004767d9bc182sm380434jab.139.2024.03.06.07.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 07:14:28 -0800 (PST) Message-ID: <74fd60ca-6284-4817-8ec1-7f1a6c203473@kernel.dk> Date: Wed, 6 Mar 2024 08:14:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: Fix page refcounts for unaligned buffers in __bio_release_pages() To: Tony Battersby , Greg Edwards Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , "Kirill A . Shutemov" , Hugh Dickins , Hannes Reinecke , Keith Busch , linux-mm , linux-block@vger.kernel.org, linux-fsdevel , "linux-kernel@vger.kernel.org" References: <86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com> <20240229225630.GA460680@bobdog.home.arpa> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/24 8:03 AM, Tony Battersby wrote: > On 2/29/24 17:56, Greg Edwards wrote: >> On Thu, Feb 29, 2024 at 01:08:09PM -0500, Tony Battersby wrote: >>> Fix an incorrect number of pages being released for buffers that do not >>> start at the beginning of a page. >>> >>> Fixes: 1b151e2435fc ("block: Remove special-casing of compound pages") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Tony Battersby >>> --- >> This resolves the QEMU hugetlb issue I noted earlier today here [1]. >> I tested it on 6.1.79, 6.8-rc6 and linux-next-20240229. Thank you! >> >> Feel free to add a: >> >> Tested-by: Greg Edwards >> >> [1] https://lore.kernel.org/linux-block/20240229182513.GA17355@bobdog.home.arpa/ > > Jens, can I get this added to 6.8 (or 6.9 if it is too late)? Let's just go for 6.9 at this pount, we're almost there. I'll queue it up. -- Jens Axboe