Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1148164lqs; Wed, 6 Mar 2024 07:38:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWy2oN84qlIsiOl/CyjUc5paAAbIoD18f8HMt2wsNV+X7lpKjirXanbm8J6mQvD8pnMTMU1O+qWWoHNK4ViFd7yNTsZRqWKXYs6MW5vWw== X-Google-Smtp-Source: AGHT+IHKqhYfUvntRKBF0hPgfg4meiNHlXeM59qZoMNnDjgRGdHvvRLP7ZhCaJBq0efxO1guxlQl X-Received: by 2002:a9d:3e0d:0:b0:6e4:9456:6b04 with SMTP id a13-20020a9d3e0d000000b006e494566b04mr5650773otd.5.1709739508812; Wed, 06 Mar 2024 07:38:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709739508; cv=pass; d=google.com; s=arc-20160816; b=tOYmufhGsOvJ7nPq6pby4MasZaH5RiZI2xU1sHIj+UugbJmNOzD8McZDWtbT6pyo47 3aPoAn/jy4JDX/DPnYyh5KEFlkuVsqL+8oeo9BTrP7mUNtv/JlfLkmwnZFcL2wZdq5Z5 fjwI/lXSfMbgJ0qU4ceW4FpzTqaP45P09imzJipOaiaY3AdhH5n4BuhtvUnNGZox1Btm 9+CmoMKrfecqs2DuQYCvEfEMkPhOVtKCeK7ne5HwIR5fuqTN/6J802ah61Dh6U0AbZ9X s4rOMP9iO15Ccl8KJJCrElx2TgfatpF3pnJ+WJ/JcR9Gr5bkxlyXvgil1dD+ZXgcb8dj b9iA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=ue7GdPLCaPX4RWMzrCRbKHMe+t/tuY4CrVTF3vFJ00w=; fh=DcB4GRJLjDiSDqapuh8Jn6yiKGGm5csMC+4Kii9NnRg=; b=cxTHPkrKrIo1hIXmjSyrDmuvTKw7SJaNpS9QC9UN2gAAsXRY9gUX2LtR03E2yGJ3n4 8CSHNeYmQlJPpoYjUUjruKzXZckX7MKCuil5d8g2FUQuCbp988Tr+tSF9WTo2vH/Kd+E MR59JLG2fU/IE2BtV31AtwSvLsh116/sDIFhfj8dnfwRgAdRQO4Xa9qB43B7SLaOLApb 3MlPfv2B+k/bl+1EH1E4mqI/OySWGrOJIBRiPq1gOkiRTXa+uwwJusfXFNONE8BYsrfP 2RljdF9Ia4wHYLiX8+i+w0T3b/mV/5rKECXrC1u1t6cdgFQGWbZ/BA6QbYUpxAJ9u7IQ hkbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=BYWJIlcd; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-94165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94165-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h15-20020a63120f000000b005e42b5cb08bsi11819322pgl.110.2024.03.06.07.38.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 07:38:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=BYWJIlcd; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-94165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94165-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7C064B22F2C for ; Wed, 6 Mar 2024 15:37:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7715D13BAD2; Wed, 6 Mar 2024 15:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="BYWJIlcd" Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AA4137933 for ; Wed, 6 Mar 2024 15:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709739334; cv=none; b=b6LrW0shgRvHrbuufbF6WU8xj/7XXUhmkfW8VHnbgO7+QdVFcxHtI76frxeDy/7ra4SXSyFGtytEEJAjSTkPBcIOUO5mPrz0lYmghWgqhC5EqS9apFt9OkVVYB1Zu/Fqdl8SMFX8ZhofpB+22w88lFEu07y2JAmp3UK8DtgALnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709739334; c=relaxed/simple; bh=+VtCcHm5WT6i5E4oxIOVLZNWtaf/A5upYPdSnULaepg=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=e85/lzn0MgQ4gRBu6yc6t4MRTE+7ybTIDe+k4+nE1e00LeruHhPlcuwjOOEM6RRP40rEz9wLerX5lqeh+dteB53Kktj5S+Oot+dcU6YaZOHrfPyrudleIZVzHkocCC02a3pEz+fDhp1ZqD/iACxdGipuTPEEh894LSo+awXteCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=BYWJIlcd; arc=none smtp.client-ip=209.85.166.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-365b5050622so1989465ab.0 for ; Wed, 06 Mar 2024 07:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1709739332; x=1710344132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ue7GdPLCaPX4RWMzrCRbKHMe+t/tuY4CrVTF3vFJ00w=; b=BYWJIlcdHUQEHe2Pbo0TgUtA78B5NCiDbZLUBteXS/rKZcsgH7sRIoZNQ4gCaGV9C1 ucok7mcO1o3tCpyq6UwLUknnLCCYGWzc+roNHmvAVuaFgEGbRhIxOXdn6RYlKVDVWg2S pnaDWlHWHWU8G4SDPWITFUT8PcO7+qlBBxcoGx9E8uf3HXbPM/RML337pTWm4xMONqnJ bpSc3qKRrfADMu8egltnQRBfbU3qJivCZmf6mu+6GBTpzPiunzLHvC/17Kvm0e4rZwSI 6lrPLDDsVhzsUNQfu3EStf3x357T8YyjXMWCiTg6kxMjr47WpWP8ISFIiZ7JgQm9ITmu J74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709739332; x=1710344132; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ue7GdPLCaPX4RWMzrCRbKHMe+t/tuY4CrVTF3vFJ00w=; b=oVstT0Kdtnm+4EzDkufeVKxS1P039u35SnwzbdM8DmyreOMbq0i58XhzNoi9b/eUkV EvCQRcOP2YvYW17IZQJLdtPUnPjJmJxSrl4v/v/unaeUCBbaW5QyhjTYAlZmk9yOiccO ls3rZTBCB30CZC2pJWy02Knm56pDvpTvWTdQ6WdReDtJxuI0E01ZmrwcIa0ULktaZ8B+ x5olAFnkPQFZgn2e8qiiwRgD2QZWmvninPBgbKeFmofKMMB7NlYDWksqECB4PfGHdKyc LNfQXgHut/qRJiaMXP/s2o7lxdom1lSrRECfC1c1BpR8OKoSyZAtfJOyj6KX5Buf9UwO y6Mg== X-Forwarded-Encrypted: i=1; AJvYcCW0ohVtF/KCyP1mBlaVPlY2jaAWs5aqwsga7NXuM1LBjRLRvTO8L/aQrh8AwpajDZPZ98bRiRN9ggXmGU8RkbXqFmtddL4muY2dYWOC X-Gm-Message-State: AOJu0Yy72GmhLw70GU7HmnEqPzmTpYvx1sizgbZMFcVrjb7Th3X77KU9 txulan4C0OTToh6RkD9TmhJPtnrpzaiQn1d8qGiDTkSwLTNuOGexyCbL6Xf/c47xSR9BsH7xrAR Y X-Received: by 2002:a05:6e02:1d05:b0:363:c82e:57d9 with SMTP id i5-20020a056e021d0500b00363c82e57d9mr3850245ila.3.1709739332451; Wed, 06 Mar 2024 07:35:32 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id t2-20020a92cc42000000b003660612cf73sm324467ilq.49.2024.03.06.07.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 07:35:30 -0800 (PST) From: Jens Axboe To: Roman Smirnov Cc: Sergey Shtylyov , Karina Yankevich , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org In-Reply-To: <20240305134509.23108-1-r.smirnov@omp.ru> References: <20240305134509.23108-1-r.smirnov@omp.ru> Subject: Re: [PATCH] block: prevent division by zero in blk_rq_stat_sum() Message-Id: <170973933060.23995.4109030710526528242.b4-ty@kernel.dk> Date: Wed, 06 Mar 2024 08:35:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Tue, 05 Mar 2024 16:45:09 +0300, Roman Smirnov wrote: > The expression dst->nr_samples + src->nr_samples may > have zero value on overflow. It is necessary to add > a check to avoid division by zero. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > > [...] Applied, thanks! [1/1] block: prevent division by zero in blk_rq_stat_sum() commit: 93f52fbeaf4b676b21acfe42a5152620e6770d02 Best regards, -- Jens Axboe