Received-SPF: pass (google.com: domain of linux-kernel+bounces-94201-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <51a21209-82a6-431e-bff8-9fad5142dd42@quicinc.com>
Date: Wed, 6 Mar 2024 21:24:39 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 3/3] arm64: dts: qcom: sa8775p-ride: Enable support for
 firmware managed resources
Content-Language: en-US
To: Bjorn Andersson <andersson@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>,
        <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>,
        <quic_wcheng@quicinc.com>, <Thinh.Nguyen@synopsys.com>,
        <p.zabel@pengutronix.de>, <linux-arm-msm@vger.kernel.org>,
        <linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <quic_psodagud@quicinc.com>,
        <quic_nkela@quicinc.com>, <manivannan.sadhasivam@linaro.org>,
        <ulf.hansson@linaro.org>, <sudeep.holla@arm.com>,
        <quic_shazhuss@quicinc.com>
References: <1709657858-8563-1-git-send-email-quic_sriramd@quicinc.com>
 <1709657858-8563-4-git-send-email-quic_sriramd@quicinc.com>
 <b9142874-0afb-40a6-9008-b33bd8f56840@linaro.org>
 <399555e8-d8fa-46b7-8b15-3d3a4a30809b@quicinc.com>
 <qbgyspabmohgwenj3mbpiebyll2jlgvbq5v5fm56mo2ixwgnee@nyjzjrspxrq3>
From: Sriram Dash <quic_sriramd@quicinc.com>
In-Reply-To: <qbgyspabmohgwenj3mbpiebyll2jlgvbq5v5fm56mo2ixwgnee@nyjzjrspxrq3>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 3/6/2024 12:17 AM, Bjorn Andersson wrote:
> On Tue, Mar 05, 2024 at 11:33:54PM +0530, Sriram Dash wrote:
>> On 3/5/2024 10:38 PM, Krzysztof Kozlowski wrote:
>>> On 05/03/2024 17:57, Sriram Dash wrote:
>>>> Establish the channel and domain mapping for the power domains to connect
>>>> with firmware, enabling the firmware to handle the assigned resources.
>>>> Since these delegated resources will remain invisible to the operating
>>>> system, ensure that any references to them are removed.
>>>>
>>>> Signed-off-by: Sriram Dash <quic_sriramd@quicinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 96 +++++++++++++++++++++++++------
>>>>    1 file changed, 77 insertions(+), 19 deletions(-)
>>>
>>> Do not mix DTS patches with submissions to netdev or USB.
>>>
>>> Please put it inside your internal guides, so you will not be repeating
>>> this over and over.
>>>
>>
>> Sure. Will take care. Thanks.
>>
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>>>> index 26ad05b..b6c9cac 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>>>> @@ -764,8 +764,18 @@
>>>>    };
>>>>    &usb_0 {
>>>> -	pinctrl-names = "default";
>>>> -	pinctrl-0 = <&usb0_en_state>;
>>>> +	/delete-property/ clocks;
>>>> +	/delete-property/ clock-names;
>>>> +	/delete-property/ assigned-clocks;
>>>> +	/delete-property/ assigned-clock-rates;
>>>> +	/delete-property/ required-opps;
>>>> +	/delete-property/ resets;
>>>> +	/delete-property/ interconnects;
>>>> +	/delete-property/ interconnect-names;
>>>> +
>>>> +	power-domains = <TODO>, <TODO>;
>>>
>>> This wasn't even tested.
>>>
>>
>> This is tested with the specific power domains in place
>> of <TODO>. SCMI interface is used for the power domains.
>>
> 
> So you tested this on v6.8-rcN, but you're not able to upstream this
> dependency? The code wouldn't compile if this patch is applied, so what
> do you expect that I should do with it?
> 
> Develop on upstream, test on upstream, send code that improves upstream!
> 

Thanks Bjorn.
Sure. I will wait for the scmi based dt support
for SA8775 and then update the patches on top.

> Thank you,
> Bjorn
> 
>>> Best regards,
>>> Krzysztof
>>>