Received: by 2002:ab2:24cf:0:b0:1ed:3240:60d6 with SMTP id r15csp1108687lqe; Wed, 6 Mar 2024 08:23:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU/tkt2LY2wqvjNUoMgDBuFvtHG0VrS/Q9PdU82ZvyA1j0G+3170pwT5zV5IprgiW95AaQeXiidfMPpoWoTZFIJfIhL0B/EyMlJqYSOrQ== X-Google-Smtp-Source: AGHT+IGKNXapRP4MAZphRB9u3EDORoWylagINRKE9YKtGxCMNUDthOQIegyp0BLIpXclH6uHSBSH X-Received: by 2002:a2e:3a13:0:b0:2d2:e2b1:4488 with SMTP id h19-20020a2e3a13000000b002d2e2b14488mr3931046lja.22.1709742195496; Wed, 06 Mar 2024 08:23:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709742195; cv=pass; d=google.com; s=arc-20160816; b=0HYIOmTLC+Wsz8pYQPpzGP8zolUy+78x40nHlWVcOny/7NWmytjXeAii9mvAYfERD5 zPscfftLFGYzkdSZ66QcAU+DDsaNHlgVN1YopmpUpyJksSnys8Zp5ZVMX0zoDOHxbzkZ Mb8VZ70E66ErsLx/5kfEZbw1j12yx9+bZ/vebuGiKxxbD4KbSZAt6gv+fGbFhyFtsCdf l9YfSLaqK611AvFz1WZE6GVUehgYWuVSY8qzeRveoa8PxwBmqaaK22lQ6dOwJm4+NwXy rXJ6U+LjrOH2YVMv89rAipYn70nUPBSJ4AGTX6DWQ7yyCR7Wd/B8mgLZdtLMrA/5hXbV Qmmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=NfPMWTyDL6HmwdNZeiAohl0/oI3Uq8Bk13pW//L7Y9E=; fh=WOouEbXfOZOrYUev0RK5R+sgoLfUUIZJYahLtlQP+Rc=; b=DsTu5GjxeD2itoAtDyc+kRb1TgImtLqgEkIqvXo2dNXBtrrxu+EvTSk/zLSSr12B96 V+4R/qlunHySqkIjHk7CWccG0vfs5y4tk+lJbyPx1PgkC3JPqWjFjr67sSn28b0DWdPd lFA1Hc3fOJkk1y+fWJEka/apTU6002yw3SysWNVGWObPaX/EjuemjgHqVa3bV+bUbNG0 HGl5vFTk5H1zhddM4NenG27fqc56lR+WJBQmNiM88x53eG35A7gQUyMa3MoAosm/hi+4 UgPJq3lh8bjLa09iyrQOQD7CSFiRJvz44fhg/a2FCFG/Adidui9KkQh3V2FYyz4635dI lSSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JMFBK0Pn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a5-20020a05640213c500b0056765fe9a2fsi2599900edx.137.2024.03.06.08.23.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 08:23:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JMFBK0Pn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1E37F1F22BCB for ; Wed, 6 Mar 2024 16:23:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BF0D137926; Wed, 6 Mar 2024 16:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JMFBK0Pn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50036135403; Wed, 6 Mar 2024 16:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742181; cv=none; b=CYOEEHl2VrnX31hK03LeSVoZZ2w97yMfqDqxeoSRvAZITha3wWU+BRROnRFzQR1CG6Gdhul9ksOm+ouIebPnAs6lcpRmrzVyYJDTWnIYTaWoOWk0Zqe2LAehvFui8w516iY2ZTQ72KmkHd8B83uPRxyquIPgKBuVuhEG1NZ5goM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742181; c=relaxed/simple; bh=24mhXff8LDVoMbm7CqvfvCGZksiGBKhKHIATyzFE2PA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Al0U9E+ihR7oF61I+oHsjNlhGHZxvh39z9HtrddKWS3elHUn+XsmRWkrUVQlUWgOJA9D6pPC9BRiLe543Lk3ffrzIgcwJEQBXCvIU9dmbXhJrdPR101qqK6+oOnyk2LwwKW+Vlbf3qb6uiK3Uf9Wp9s7+9sGj5ORDruNWUKAJtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JMFBK0Pn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD6FC433C7; Wed, 6 Mar 2024 16:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709742180; bh=24mhXff8LDVoMbm7CqvfvCGZksiGBKhKHIATyzFE2PA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMFBK0PnNMiwfUMScMG+NrwmxDyqseaiWtBJ5EZw+UjeFHPDlaJs3PFJ+qIU3ESG6 cpmueBKnRTCLMw0LKN0D0URc4gYNnDmgVmbCK11YilSR4cHlzgD4G3FnA1LUKDW0SJ 2z3qahBPYT4Sh24Xtxt/Y0LssSKwZpVx9Y6uoPwzyptI5ZJALkhmbn9NWW279W9TCa BK1OM7R02Y242iRN2CscD0zmWvIcTc2aXQNmJ2+DIwmkqttNyqRF23bobGei0bknCP 9rOE8dOUqsUjExFwY1aO/M7iPvS8dbi61vs2aYuLWk2sbyn5ptXJvXpp/ISA98blwW FJJgAql8v1eHw== Date: Wed, 6 Mar 2024 08:22:59 -0800 From: Jakub Kicinski To: Andy Shevchenko Cc: Yury Norov , Herve Codina , Vadim Fedorenko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rasmus Villemoes , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn , Mark Brown , Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC Message-ID: <20240306082259.5a29a5aa@kernel.org> In-Reply-To: References: <20240306080726.167338-1-herve.codina@bootlin.com> <20240306080726.167338-2-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 Mar 2024 15:38:10 +0200 Andy Shevchenko wrote: > > It's minor, but you can avoid conditionals doing something like: > > > > netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF); > > This is harder to read. +1