Received: by 2002:ab2:24cf:0:b0:1ed:3240:60d6 with SMTP id r15csp1108744lqe; Wed, 6 Mar 2024 08:23:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWTY1hUJ4134G/Clc0WsuCq3mQ6N3n8e4KfCPAz6p+VMRetPVaHf5bQyb2elyujvIQ5/E1kQuJQAAnwJNoDCSG26OQedMR4A8bdSiO3vg== X-Google-Smtp-Source: AGHT+IHWmZj51LuTIkffl4TsyH7cUCuk2u9F1qi+E8U6Bx4jysE/hIYoXyBghk4W8mgjaxvLbHw+ X-Received: by 2002:a05:6a20:244c:b0:1a1:6cec:7261 with SMTP id t12-20020a056a20244c00b001a16cec7261mr404881pzc.16.1709742201078; Wed, 06 Mar 2024 08:23:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709742201; cv=pass; d=google.com; s=arc-20160816; b=WIkcJFg+wX91Kuk9ZI2aAVsRhQ6rZ2PhWcsj0S6VMHbmIyge3PUhaaV036Tm3jqP+3 ZxA1G0jPZ6J2R13TxOmnZKn4P2yYBC0ud/a8O0gX4Xus7NU+oIE/DBr0pmKGmJhuGeSA b/gF+dJMRoWc7vPPNifsBWP1OIHJWUxgTnyrzlsOb3ohmOcUB6lHq5avqA33JSMkZ73s 2u1e2L/w8dO+YxC1es3PtQHrzKBP2YrBzJy/jYoJXhZ/OruCOG1MfVFtbiGl6Hxfpgpc Gp8WNhR7DLzT/bhsxVGx1VWYRktqGSIQM7EsUwhD4gH22qLnCsTdjAoRIGcNBmctNDHu qyLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Dgm9kyS7DBdkySJyycHZLL8e8yFBAt7VHUt7y5oi7/0=; fh=/cCLrmvvJZlAMtFugwu+QaQxHUC3WtsMKzAQ3OyNtTM=; b=orQfRBfBhZN6RS8NWOk+ryi3HVlX3FeGExNMGna/CzERXH3pMABCt4dwJZsZLf4yKM 3vcUVZIaV9ZRRhjJunR8s4ai0ffheYyei/tr9kUY9mAp7BG5Ki7BniO4QEIIvcKSTDLR GbOfz0WzdpaOr8/F9NkInP3o6UJ8mQXg7LvASX/JZ9pZxBLCXn+eYfA+ph6UunpxkrRL nYzyz1MRt3s3abBHqxAM6hYz3tek0EJbC6Adcpcf+laeKc1hNuFYgESoJnIM7w1skOCD cgRLDtaY/uN30RP61wfdSjDCZRDLQ4qbTLKED8XCHe4Jp4IIdlYd62CSNPw2PkuxIrvK ZQyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FTVhAcGJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94257-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s15-20020a17090302cf00b001dc8f8e63e8si12553500plk.271.2024.03.06.08.23.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 08:23:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94257-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FTVhAcGJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94257-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DCDC02883F3 for ; Wed, 6 Mar 2024 16:22:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 320BF13790F; Wed, 6 Mar 2024 16:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTVhAcGJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6F613665A; Wed, 6 Mar 2024 16:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742152; cv=none; b=lOSWgN9KNpCjv2FSRtVVfrPmgGLzJzmt8m3ykPPH/NsV+iBYjyPm2NGOwS44ovoQGq7GZrJwSb836wulS2yxnCCWNdBTxJtV37UfUv5mfoy1WjVz2tdW0KaE/flIWE18wBNBlTFpEvcleCTsGO0VxvdM5sM8iBI5Bz6seqPXPsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742152; c=relaxed/simple; bh=+KJTQZuaYF3wEiXcdWnySdEhubrnS47IojZ6kAGAEHc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dGn542ZPm8UROgQTt3XNHxB7vgE8rCV2TMQJQu9h5U3GGmyJcFxvJow8k29GsbXjOn40GJtr+5su55lshDycm4QAzkLnuJnvoqxHZdxlCeYCwRY17jIe4Lb30n8nnlKahsFDs6bUcgXb2EK3htff2/tGKhop4siiTMRWjT1s7Zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTVhAcGJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9864BC433F1; Wed, 6 Mar 2024 16:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709742151; bh=+KJTQZuaYF3wEiXcdWnySdEhubrnS47IojZ6kAGAEHc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FTVhAcGJbBGD0bpjx8ho5NWpNNX8TWh2NOW/Qe5/qoDQQackrnQknXDrHwkvw5pqg R+M/t7L4uHA3HQ9MM5707FBqWiipHmDcXasXyt5827bh/QpU1cXCTo33F01EYfdaoS O9Wd9ohs77gNH+xobff95KyCyOlT8XUaE4IxR80fkwNPLoL0lDalbNm6L6G/PAIhcV UkkV5oxoFhAChPXmdrYwRdZ/gzpkgjix/dd/Wq06dfmF69thX/tVDAAJo5UyloBDXl rKNCZxUMRFj9/5KZZSpR2LIEAxy2ulsR6CL2bfmsNv1hATWvLXh5V41JJcCL7muIVm mNoJqQsDGCxTQ== Date: Wed, 6 Mar 2024 08:22:30 -0800 From: Jakub Kicinski To: Ratheesh Kannoth , Herve Codina Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC Message-ID: <20240306082230.7ecf207b@kernel.org> In-Reply-To: References: <20240306080726.167338-2-herve.codina@bootlin.com> <20240306105651.1210286-1-rkannoth@marvell.com> <20240306143743.5732b298@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote: > > > > + struct qmc_hdlc_desc *desc = context; > > > > + struct net_device *netdev = desc->netdev; > > > > + struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev); > > > Reverse xmas tree > > > > The reverse xmas tree order cannot be used here. > > qmc_hdlc depends on netdev, netdev depends on desc. > > > ACK. Usually I get comments to split declaration and assignment for > my patches in upstream. Yup, that's our general preference, to split the init out of the definition.