Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp6827lqi; Wed, 6 Mar 2024 08:35:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXknVK+WI9DuxLhb/J1qTQ4fNZYuuVdzw8RtueDAcXhRnQ0OFNSJOSp9aIvLgEFcj84ICM5FPY3bJpSYD9tIQ0NOl2kb5HIJ5aqTnt2ZA== X-Google-Smtp-Source: AGHT+IFquR8Xn21Foc7Aaq0oKrc/gffet9CuFR8KJ4KF5azbreULNc7qrsJvfLK8FSSnKVtcOlYD X-Received: by 2002:a05:6402:f96:b0:567:429f:7164 with SMTP id eh22-20020a0564020f9600b00567429f7164mr5893507edb.32.1709742933238; Wed, 06 Mar 2024 08:35:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709742933; cv=pass; d=google.com; s=arc-20160816; b=ghAYdZQOysQEimC3NoxEUx8q2By153nV+tBI7oucgfj63ZHc9aPhv6Q/8FATiUcAM+ No1fLop1W3epyEXis1D2axwhgcvgSqwqoVZArjPV2lY/04YiTqeMmchUJ4Ym3YSQjYkV jGrKsl665kFnnh4JlUGIjfvQNcBClgp+E3aZpwRTwew5LTL7IAVZqUSaQ1D4VaW7QtVr regAe0QMzA5GxAzUo4dx9kORkefLI4RL0lpUcxk/XuJ0GwWEE8TO/MivJR4zk7a3womn RHnKYePfgOmmWMGGpJaFj0qQ7+HJj/e5qWIBhI8a38PE3GQVA9zOcpbrfOHhdfRnRj7C T0VQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=vYaBF1RfpTBvYJ+BNNdJySPJ/cELqkCtHtPXIPhdHes=; fh=v5vU078aXvRZkyaHEyJKZQmCLuLJ5DO6Rw+CB1/6Fx0=; b=J+GSF7984yoXS4Sk0Y+DQJkpMW7uDBfHuhdSo8vW0YoIsRk3CfIlj1z5F1/6Dx1IZ6 IRmDAOXx/6wYBW+M3tky9KOx2wi6s4Rodff8LwBbRj/ac/wwm5xvK3RTFS8Neri2NSsN BmXVjMY9XX+9UpmuohSFTmzCY7B55sSFdoVX5wuKGm5cQO/o9nKRG2E0L60mTbxSnIIS eG/IaDDj+ly3bSAmKFgb4T8dV7Jmal8C4J9q2wIOXf4kpqxploDgWKtdcwPNaBViz/Fg I78bqtt4rntey39TRx3thFp8WPLtz5X561Yti3JJujDoRGPmxF+zqY0B9DN/BFDBdAXN 3TJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-94275-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94275-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y22-20020a056402359600b00565b5e786cesi6316410edc.27.2024.03.06.08.35.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 08:35:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94275-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-94275-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94275-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F105C1F29553 for ; Wed, 6 Mar 2024 16:35:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8531C137904; Wed, 6 Mar 2024 16:35:25 +0000 (UTC) Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [207.211.30.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E1875FB95 for ; Wed, 6 Mar 2024 16:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.211.30.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742925; cv=none; b=sMtey+gqMnl1oH7chAwYJ8tTmYbdeuJyw5G4Nk63E68RQNjzBA2s6PkCOHRrsYYzw8jNzuurWtyf7UH48PMb8EyMQ14tApvZRMGBb4Ys9OVioTJKQpGLCjnwYrpiVlmGkSU+FEp2Nvdh55bkTle5wNAOs/fKs6Fqlf4Rpg1ezJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742925; c=relaxed/simple; bh=SVvWdNGpY/CIYt+MhM5laWQNaxntm3Tz6Wsa6jb+nnQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CLxqBHw6MbWvxwOw73Op7HLe2ELTFOGjRA1o8zCxckzluAQpA9/NSb6DyXbJkrs1P/22FYF/LUhQPInt8LwemVHRtwg53fTDh1IjHy6vxNtzobyu/kPDkDmmGFaEnUW8Z3aOawTVvoQLTTigHRvge9fbbz6DC7sQF8uqAN9sd20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=none smtp.mailfrom=queasysnail.net; arc=none smtp.client-ip=207.211.30.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=queasysnail.net Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-RSHPMtiyNbORLwcOcr_Qtg-1; Wed, 06 Mar 2024 11:35:18 -0500 X-MC-Unique: RSHPMtiyNbORLwcOcr_Qtg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 971DF8007A6; Wed, 6 Mar 2024 16:35:17 +0000 (UTC) Received: from hog (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D31737F6; Wed, 6 Mar 2024 16:35:16 +0000 (UTC) Date: Wed, 6 Mar 2024 17:35:15 +0100 From: Sabrina Dubroca To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next] net: macsec: Leverage core stats allocator Message-ID: References: <20240305113728.1974944-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240305113728.1974944-1-leitao@debian.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 2024-03-05, 03:37:27 -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the macsec driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Reviewed-by: Sabrina Dubroca -- Sabrina