Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp9672lqi; Wed, 6 Mar 2024 08:40:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWbQbBJ5x/+GU9GaiVVXtJWYREdBzbgyIuPIk0KuFJdvi2iD/q8fH5Qm7yFyUIam3Ohgl3RWAQBV/HaVkFC4vjTaTHF/owdURULnywXzw== X-Google-Smtp-Source: AGHT+IGnuoahNj4tsq4w0HjVOHbhP82VsAIi/UY3E2QZY8HNRTu8Gw3nF9IxLMeKBv88m8JWz1uh X-Received: by 2002:a05:6a00:896:b0:6e6:4946:985f with SMTP id q22-20020a056a00089600b006e64946985fmr3634166pfj.11.1709743243351; Wed, 06 Mar 2024 08:40:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709743243; cv=pass; d=google.com; s=arc-20160816; b=fWR4SSy1tpVQwPu/JAGU3+Xune27zoF7uwYur7PCJLS3yjMb+ooDKTZrSHT+SEaWbK AsCACWK3J4ACX+fy/3e2o+1NOtZnpfM8a4tR1ydonsndwmmvflFfjKRkUwvMpFbggJ+s Jf1Gi1wPkRFo0JQWgcsyIhju1aou4568sgHdwYxcrVw2BZJ2MroPabe3/uN7QTsuuqjp Oa1zrAebDkhw/vvaarD0Ng4O+t5V1aDHu6Z/VjWyNopRnXN3FC0gx1j6cN2JdvvvBBHQ CgLrPhcWQeFUeIdAwR+xotvxjru278Fbj2ndFlFSILmXOv518rwUvxadHcRVd9+HWxIl MYGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=X5ZJAoTEcHafCyXwqx02YJ2+wXyfpkwNOLbUFgtaoIQ=; fh=PTqt67D61VcQVOiYNvl85kUiy5OBfuK7KsJrdsxp8us=; b=Fm6+ORbzD4L828bqednUZsTkVLwN87BUcZYKAH3sgK4Xx2DfAWdTtm7woiYfqXQi/W 1R59fApGAtQZ7UAeRZkE/QftZanfr1mZjJ7O2HE00zc4uGbsp3BUz/fxngKjmHKmSUfF AtRUDTxxO2TC8I03h9aNcQMe2ZpAZa9eN+yIGUK5aSak56i6DV8qwSbEdx6e8yPtUuwY 9U924WMqCsqtZNRkQgAsX+MAzOUALoqmZswuAAe9z3HVjbPXyz/ZrUNxTihoOZNxjk9P 2pYA93Ge7WWrTKeLFQ95nq2tAni0GIDNwYHpuLvGz1vguXpwsxMML0HF1GhVavKxKleD /gcw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=VvZ2tEfw; arc=pass (i=1 spf=pass spfdomain=8bytes.org dkim=pass dkdomain=8bytes.org); spf=pass (google.com: domain of linux-kernel+bounces-94280-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94280-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ct17-20020a056a000f9100b006e652784c07si725219pfb.272.2024.03.06.08.40.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 08:40:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94280-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=VvZ2tEfw; arc=pass (i=1 spf=pass spfdomain=8bytes.org dkim=pass dkdomain=8bytes.org); spf=pass (google.com: domain of linux-kernel+bounces-94280-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94280-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F1A59287C39 for ; Wed, 6 Mar 2024 16:40:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1D4F111A3; Wed, 6 Mar 2024 16:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b="VvZ2tEfw" Received: from mail.8bytes.org (mail.8bytes.org [85.214.250.239]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5377F5D8F0 for ; Wed, 6 Mar 2024 16:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.250.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709743237; cv=none; b=qAI+DxoRx4FIBag96amVWinEZOfQ0cAHlFOK3lR41OqOtIxIhYc9dPX5xFo5tbuWRHjEMg5uTNzutDBmvbIW7V9+MTt8OP3lmzbsuyx/VaXHEVg/O0ql0oJIQtyC71El6XFBax5Fw2515871aRxpuCtN22MIFs/sMVNfrxyjSSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709743237; c=relaxed/simple; bh=DzK8eeew7owQbLWBsnwtpFXZ2gPBFj5rnJtQIM4ikNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k0V2d8mZ1K0D+atVM3QKOGJbJajQ66JQ2lqA0adpZfJNjmO32dFjkMCyYh8PgylucI7MVPiaiC6p6Mg/6aRO6zP3Pg9CEHixAymSVKwmbZ763JCBp3p/U1p/7f9JK3wzvhtE6REW1qkneiGIt7W643VXCZeab3OAoS1/u+zzAak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org; spf=pass smtp.mailfrom=8bytes.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b=VvZ2tEfw; arc=none smtp.client-ip=85.214.250.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=8bytes.org Received: from 8bytes.org (p4ffe0c3c.dip0.t-ipconnect.de [79.254.12.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 15B751C85E6; Wed, 6 Mar 2024 17:40:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1709743233; bh=DzK8eeew7owQbLWBsnwtpFXZ2gPBFj5rnJtQIM4ikNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VvZ2tEfwn2bqRzHS/qHGD1wjA5vJ9Lwb+SpS9Xzeyd3iF5xLQnSRn2H9meRXaLsiC sIDk3RVghO8bZPyXTv4oFmAKcCaD8gFuuxpACD9REdbNCJV5mA8s4lKWS7JT52lBoA VlIcO3k5WJagMlFckeHt+aqxRwG+IEVBDqc1zhN+waw0VClxL0MLISRsUoG9INsBIl VHgj2O4gNC2c6oLC2aSWRM0XHCYcrLae2/x5GPgn6/uQ5BPIe6TUoiPJZM1E7iMz5R vkgI6rTxzJiUkgCL4NPntkl+EdSDAIgbHwBNuaMnMS+HNR1PazdGGltEpe4Fr1wmKA T0WNYi/tYLc0w== Date: Wed, 6 Mar 2024 17:40:31 +0100 From: Joerg Roedel To: Robin Murphy Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, will@kernel.org, mhklinux@outlook.com, petr@tesarici.cz, hch@lst.de Subject: Re: [PATCH] iommu/dma: Document min_align_mask assumption Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 04, 2024 at 12:05:42PM +0000, Robin Murphy wrote: > iommu-dma does not explicitly reference min_align_mask since we already > assume that that will be less than or equal to any typical IOVA granule. > We wouldn't realistically expect to see the case where it is larger, and > that would be non-trivial to support, however for the sake of reasoning > (particularly around the interaction with SWIOTLB), let's clearly > enforce the assumption. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/dma-iommu.c | 5 +++++ > 1 file changed, 5 insertions(+) Applied, thanks Robin.