Received-SPF: pass (google.com: domain of linux-kernel+bounces-94306-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240306081038.212412-6-umang.jain@ideasonboard.com>
References: <20240306081038.212412-1-umang.jain@ideasonboard.com> <20240306081038.212412-6-umang.jain@ideasonboard.com>
Subject: Re: [PATCH 5/5] media: imx335: Limit analogue gain value
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, open list <linux-kernel@vger.kernel.org>, Umang Jain <umang.jain@ideasonboard.com>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-media@vger.kernel.org
Date: Wed, 06 Mar 2024 16:59:19 +0000
Message-ID: <170974435963.362031.17853243017273896294@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Quoting Umang Jain (2024-03-06 08:10:38)
> The sensor gain (both analog and digital) are controlled by a
> single gain value where:
> - 0dB to 30dB correspond to analog gain
> - 30.3dB to 72dB correspond to digital gain
> (with 0.3dB step)
>=20
> Hence, limit the analogue gain value to 100.
> For digital gain, support can be added later if needed.
>=20
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

I think this makes the behaviour more consistent with expectations from
userspace for the ANALOGUE_GAIN.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  drivers/media/i2c/imx335.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index c00e0c2be3f3..701bd5318b45 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -45,7 +45,7 @@
>  /* Analog gain control */
>  #define IMX335_REG_AGAIN       CCI_REG8(0x30e8)
>  #define IMX335_AGAIN_MIN       0
> -#define IMX335_AGAIN_MAX       240
> +#define IMX335_AGAIN_MAX       100
>  #define IMX335_AGAIN_STEP      1
>  #define IMX335_AGAIN_DEFAULT   0
> =20
> @@ -1169,6 +1169,14 @@ static int imx335_init_controls(struct imx335 *imx=
335)
>                                              IMX335_EXPOSURE_STEP,
>                                              IMX335_EXPOSURE_DEFAULT);
> =20
> +       /*
> +        * The sensor has an analog gain and a digital gain, both control=
led
> +        * through a single gain value, expressed in 0.3dB increments. Va=
lues
> +        * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher =
values
> +        * up to 72.0dB (240) add further digital gain. Limit the range to
> +        * analog gain only, support for digital gain can be added separa=
tely
> +        * if needed.
> +        */
>         imx335->again_ctrl =3D v4l2_ctrl_new_std(ctrl_hdlr,
>                                                &imx335_ctrl_ops,
>                                                V4L2_CID_ANALOGUE_GAIN,
> --=20
> 2.43.0
>