Received-SPF: pass (google.com: domain of linux-kernel+bounces-94346-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 6 Mar 2024 18:46:11 +0100
From: Herve Codina <herve.codina@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ratheesh Kannoth <rkannoth@marvell.com>, "netdev@vger.kernel.org"
 <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC
 HDLC
Message-ID: <20240306184611.0cea20af@bootlin.com>
In-Reply-To: <20240306082230.7ecf207b@kernel.org>
References: <20240306080726.167338-2-herve.codina@bootlin.com>
	<20240306105651.1210286-1-rkannoth@marvell.com>
	<20240306143743.5732b298@bootlin.com>
	<MWHPR1801MB191837C8907B39F67893F0BBD3212@MWHPR1801MB1918.namprd18.prod.outlook.com>
	<20240306082230.7ecf207b@kernel.org>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Jakub,

On Wed, 6 Mar 2024 08:22:30 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote:
> > > > > +	struct qmc_hdlc_desc *desc = context;
> > > > > +	struct net_device *netdev = desc->netdev;
> > > > > +	struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev);    
> > > > Reverse xmas tree    
> > > 
> > > The reverse xmas tree order cannot be used here.
> > > qmc_hdlc depends on netdev, netdev depends on desc.
> > >     
> > ACK. Usually I get comments to split declaration and assignment for
> > my patches in upstream.   
> 
> Yup, that's our general preference, to split the init out of 
> the definition.

Does it mean that I need to update in a next iteration ?

Best regards,
Hervé