Received-SPF: pass (google.com: domain of linux-kernel+bounces-94351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 6 Mar 2024 17:53:05 +0000
From: Conor Dooley <conor@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com,
	git@xilinx.com, Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: rtc: zynqmp: Add support for
 Versal/Versal NET SoCs
Message-ID: <20240306-mystify-playset-5b4ae2f955f3@spud>
References: <70b646d60f53cccc734afbc7f22245d53394075e.1709728587.git.michal.simek@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="p/fOP0/kzkjNlStW"
Content-Disposition: inline
In-Reply-To: <70b646d60f53cccc734afbc7f22245d53394075e.1709728587.git.michal.simek@amd.com>


--p/fOP0/kzkjNlStW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 06, 2024 at 01:36:34PM +0100, Michal Simek wrote:
> Add support for Versal and Versal NET SoCs. Both of them should use the
> same IP core but differences can be in integration part that's why create
> separate compatible strings.
>=20
> Also describe optional power-domains property. It is optional because pow=
er
> domain doesn't need to be onwed by non secure firmware hence no access to
> control it via any driver.
>=20
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>=20
> Changes in v2:
> - Change subject
> - Add compatible string for versal and versal NET
> - Update commit message to reflect why power domain is optional.
>=20
>  .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml          | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b=
/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> index d1f5eb996dba..5652df8ec121 100644
> --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> @@ -18,7 +18,10 @@ allOf:
> =20
>  properties:
>    compatible:
> -    const: xlnx,zynqmp-rtc
> +    enum:
> +      - xlnx,versal-rtc
> +      - xlnx,versal-net-rtc
> +      - xlnx,zynqmp-rtc

You sure chief? I don't see a driver patch alongside this adding these
new versal compatibles there, so should these versal compatibles not
fall back to the zynqmp one?

Thanks,
Conor.

> =20
>    reg:
>      maxItems: 1
> @@ -48,6 +51,9 @@ properties:
>      default: 0x198233
>      deprecated: true
> =20
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> --=20
> 2.36.1
>=20

--p/fOP0/kzkjNlStW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeitgQAKCRB4tDGHoIJi
0lR0AQDThWJ+9/UbQ2HAJQImVzfkdbfv85FsDZpRODFQwqT+BwD9GMputTe1LtAz
1aZaDasFqMBFJ8Tn1IH6vfz8bq6C8AY=
=m8/k
-----END PGP SIGNATURE-----

--p/fOP0/kzkjNlStW--