Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp55931lqi; Wed, 6 Mar 2024 09:55:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWexXzcCgSrRAw9BeeZz+zWgfI4F7n71I3ANenW8i8N+me4IlJoPC6GpMqixcrmZ8NWbO5xy0LaAELTosXR8QffT2Y1iawGzmJYLXC7Ww== X-Google-Smtp-Source: AGHT+IEstDddlu6iizaazxZJrQ5PQ/X8Z2+9fJmeWnSExUBZLUmXBlM6GInNkIfu7SrrTRbhCICB X-Received: by 2002:a05:6a00:2da3:b0:6e6:451c:a519 with SMTP id fb35-20020a056a002da300b006e6451ca519mr5578582pfb.5.1709747706359; Wed, 06 Mar 2024 09:55:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709747706; cv=pass; d=google.com; s=arc-20160816; b=O8CuIrHBmg3vOCvyto822BcSF7O7DB674RCxEy/c9gNYfMfaWqfPvk9s7VggodK3xy kd6mYE6GvEaJGduqk9Kv3ZBXXqadMBlqRSaiJFm0Ety2q4CQ1YS0ulqPUeePYdU9/Zb/ lMI+TMOuOGOU/6FgttGtrphWJyEU0wPuEeyy/37wAd3wgg4qushoz1mzfDmqUdDaWVBX xyDzmHq7pwohzi3PWBaDKsq89biL96WODXnOXlKZGUTWDdAmiV+3GX1qHLftrtb2YMCb J574yabuuLyh2rSEnW+b6BFbeg0ozVoYOnBh72CpOeP8kOsi4vB4SDEqYmOpPWzWHiK+ 50Gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=mLGLY+t2hPYfwc3g4Q5rUF5sd+9MOZBLmHzUPzGALFo=; fh=n+NdAIdi3Vir+hV5/V0nHjY2T+VPO33b3bzAU1rO+4c=; b=jBfF1EeQOoAQYTyCAaW7UXxXbmXT5Irfw939/rE7X26sfLGRjbsbYAgvSrNwkvjOkF +JWw6XKPEa207SCwDqjxDBaLThLR0Exa9zxJhK4vxr5w0aYLovh00Ofyykv4M+ADHzs5 X76vl2/gXTe8SyPAYQR9MRphi1QSvTMOQfvy6CYu/idOAzMXZUMJkadUw0ysnWDHPDzH +v1CwhBK18W9IIkJJ3+oEzUECSO4I2KRgh4KpZhW75WDWa8BzaXi3b0Y5lrzDkfyvIMC NSz+vj2266B3BRbZSvhnh4HSU5K5xxYhCI1ALGNRZRHsgzABBPL9yglJ9nflKhYAcTx5 PpwA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SNgkFwNj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94350-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u19-20020a056a00099300b006e61151b562si6689260pfg.63.2024.03.06.09.55.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 09:55:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SNgkFwNj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94350-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B4673B23E48 for ; Wed, 6 Mar 2024 17:52:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60E2413C9CA; Wed, 6 Mar 2024 17:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SNgkFwNj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 877CD5CDE2; Wed, 6 Mar 2024 17:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709747526; cv=none; b=Tf9kC5jc4jXIt23wi1KQe3+Q7x6kqpN+tMDrLOKsl1Hb2pD2w1YHCPADZLo1GfQxV2I9CHNvKM4XcAaICMVZn51U+yBSJ1WGus7sfsighr1URcu2goblcmO2kQDuCWwF7i2TsjDY4ibDkBvEGse/Xw30glxHXTN8aBjtB+1AxTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709747526; c=relaxed/simple; bh=jgEqnyMEYTp0IrTDwRr0KVr2VswUj1JqQ0+266jhtlM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UjU9BbH0gbw66ay92JD9Z6MRV5dBZk+BBHs5CJ2TUBZTC4pSSzvY1VIYoXED1/+dal7BXORDRxr5bkJ6h8tQjGtw0zIzQMhb4gGxsWNEiHgjME4PhvBtV5aioRnvh0/KVNYwD3vI7Bm6GCP4aCQ71+h4j3iOKkypa3U5WLULLOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SNgkFwNj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB9EAC433F1; Wed, 6 Mar 2024 17:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709747526; bh=jgEqnyMEYTp0IrTDwRr0KVr2VswUj1JqQ0+266jhtlM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SNgkFwNjM9f6hkLDbZFwtoLQAcqD7MooHi0DYcg9Q1zc0riXtyrd84D9NCPSY11Va awkyccB/VTiowgOSLD2Nbn2zkpdPCtVPhRRAd5Hpy7kKAIwIPpkrA0PITYNm3e6/78 kLgHlyJrdXcfAwDdG51qSaN20KgCVH2Wc8UJVuXGv4xgPQmgWDhyMJwv2cxW+XpKMk DDHR42nKbVSF/r3/YT7OYuDqiEcq5y3xAeHprU9uTS1N8vIfTLCyEBpdwqNzxVAd2r UdYkhPY1zyDFYSZIoQ0IWVlQ4DfySJav08uy+jsvPXc3sYuxOCi8gBVJve62/rKkOO Pnq+iQwXPIHBA== Date: Wed, 6 Mar 2024 09:52:05 -0800 From: Jakub Kicinski To: Herve Codina Cc: Ratheesh Kannoth , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC Message-ID: <20240306095205.5875d8ae@kernel.org> In-Reply-To: <20240306184611.0cea20af@bootlin.com> References: <20240306080726.167338-2-herve.codina@bootlin.com> <20240306105651.1210286-1-rkannoth@marvell.com> <20240306143743.5732b298@bootlin.com> <20240306082230.7ecf207b@kernel.org> <20240306184611.0cea20af@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 Mar 2024 18:46:11 +0100 Herve Codina wrote: > > > ACK. Usually I get comments to split declaration and assignment for > > > my patches in upstream. > > > > Yup, that's our general preference, to split the init out of > > the definition. > > Does it mean that I need to update in a next iteration ? If you'd be so kind.