Received-SPF: pass (google.com: domain of linux-kernel+bounces-94403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 6 Mar 2024 10:25:05 -0800
From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>, Evan Green <evan@rivosinc.com>,
	=?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <cleger@rivosinc.com>,
	Eric Biggers <ebiggers@kernel.org>,
	Elliot Berman <quic_eberman@quicinc.com>,
	Charles Lohr <lohr85@gmail.com>, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/4] riscv: Decouple emulated unaligned accesses from
 access speed
Message-ID: <Zei1Ac8RKNJu01Fs@ghost>
References: <20240301-disable_misaligned_probe_config-v6-0-612ebd69f430@rivosinc.com>
 <20240301-disable_misaligned_probe_config-v6-3-612ebd69f430@rivosinc.com>
 <20240306-tactless-decathlon-b0df16517b1b@wendy>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306-tactless-decathlon-b0df16517b1b@wendy>

On Wed, Mar 06, 2024 at 01:19:37PM +0000, Conor Dooley wrote:
> On Fri, Mar 01, 2024 at 05:45:34PM -0800, Charlie Jenkins wrote:
> 
> > -void unaligned_emulation_finish(void)
> > +bool check_unaligned_access_emulated_all_cpus(void)
> >  {
> >  	int cpu;
> >  
> > -	/*
> > -	 * We can only support PR_UNALIGN controls if all CPUs have misaligned
> > -	 * accesses emulated since tasks requesting such control can run on any
> > -	 * CPU.
> > -	 */
> 
> Why was this comment removed? This patch doesn't change the situations
> in which PR_UNALIGN is allowed, right?

I'll add it back, that was unintentional. Thank you.

- Charlie

> 
> > -	for_each_online_cpu(cpu) {
> > -		if (per_cpu(misaligned_access_speed, cpu) !=
> > -					RISCV_HWPROBE_MISALIGNED_EMULATED) {
> > -			return;
> > -		}
> > -	}
> > +	for_each_online_cpu(cpu)
> > +		if (check_unaligned_access_emulated(cpu))
> > +			return false;
> > +
> >  	unaligned_ctl = true;
> > +	return true;
> >  }
>