Received-SPF: pass (google.com: domain of linux-kernel+bounces-94476-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 6 Mar 2024 14:25:53 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <ZejDQddMp17RD6Yk@lizhi-Precision-Tower-5810>
References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com>
 <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com>
 <20240306-pebble-grope-88fdaa95a87c@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306-pebble-grope-88fdaa95a87c@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HgShbDSfLbH8nrAqS1IiDELfJDWpT5H3gCvH5kHrIFoowrePcsJ9Z0Hi3LFg?=
 =?us-ascii?Q?EqbmdyhiUCTdrSe7OEg+egM5K92nIina7jg10BN7GEsnMrqsXvJfw9Sl4sqT?=
 =?us-ascii?Q?I9wrG3O5PzNb5Kd/fXUrK9mEoDUrlGHkKYplEwucu7P7t4tfXbYVGASTLInL?=
 =?us-ascii?Q?hRVUSPN+cvRwskyPVNL+jQv7ZduW5e8Ef4udQZrAjMEVR91+JTKuG7cSlXhX?=
 =?us-ascii?Q?Py2hXlAEGQOGl2E2GTAoKmraeIp5kvwGnnC5fJSx2OK4WQyJRmSwk6MnrnAQ?=
 =?us-ascii?Q?/ECgJNMNQl52M8lST6Ic+LUeqjc5x5Y0Zqmo+BD1d7BmSIaJGkGgtq2k7l/n?=
 =?us-ascii?Q?dR8KmP5XvmmtoMK+fiMFYOo02208ghcH/1wpUdxC9M7M9SZo8oaqvCTSEmIE?=
 =?us-ascii?Q?K/cKysHZ0XY0dO6kfo9jWRkcPrKEPto1WrBHTuYi1wlnChc3MY2dYVlDhNto?=
 =?us-ascii?Q?T2nOdZ5uxRaFr6VLIkn7kz1JfIUt0ma1qUpsaVE0h7VUZp3AJaYSQCkO6bfS?=
 =?us-ascii?Q?MPVOMCrKnk0lpsqX4pmJvOQ++dCfVSc76VNC0VCKHkeG8zDCy73B+EO52yoC?=
 =?us-ascii?Q?uGfa6VJ9WUm9QME7Hj6rsN2FNA4W/RcnXKf+9dbczY67wSQSQQU4knlvHT8h?=
 =?us-ascii?Q?GgoiN9uc0gZzhx7vvSxIyHGIm19IcGWmCxs1ISaDKMTzL39cw6i7wYifSpSS?=
 =?us-ascii?Q?UJ1rrgC6rEq0l7SlHthe703dtFOcAwQMa0rDEDSbo/qbyQjba/tXspucY1y1?=
 =?us-ascii?Q?rWr5VlFnDWFC+KqVfCTluJFO0vt8PvQUwfdTTTjjF9b9JNbKwkHrt5oiy3Kf?=
 =?us-ascii?Q?InWRWMPjlJyYgTR/TIzmVvjVLMFLR34rLSzTOq7rpEpVDIbmF42S1+AVNb5R?=
 =?us-ascii?Q?C/i9YUgB+3Kb6mb4KDL0KOr4EesMnFxf+OCDGlk1P6U7xVU3CB5dN2r0cn1P?=
 =?us-ascii?Q?6ttO6VtmT2MKY6AqoopYJe6gp8fs9oP8lJ2NSrRgUIdkt9vzH88gf6ZVmHs5?=
 =?us-ascii?Q?Kg7beQaScSP7JLObKD/zxqJj6/S/NKxYJW08xZvn0r6dNo3Zc+7aSNSrnMEO?=
 =?us-ascii?Q?5iiqlRfl1khqwHpPgD4vLXDudRj+yLu/wQ6SdjQqLrEWSKTsKNauUBD1o2Zw?=
 =?us-ascii?Q?73BDBOFNDxv6KEWPL5ull/BBV6kQLxa7BlrJeaiiXhNeS3Hpy4kjhdvKUTMc?=
 =?us-ascii?Q?8ie0HHbPskMeOahhPAUGQcWImJj4XJuu5hgOqvhSJFmDzDtxsbF2tZeLecYR?=
 =?us-ascii?Q?w7d0n5qhdfxp+bEX/Nldd5wlVGARb0kjD+YAHJoVe5a/iYpsmNAUJmWK0QyV?=
 =?us-ascii?Q?ms8jlicumSgzPpTmzoBH+dNQXN6jb8+SXqfRdT30fK22E3FLy0J/8gSW1KWL?=
 =?us-ascii?Q?88V4mO/RWikTUbyg4UpWioOVKbdzKzMcdthiwGClAl8TisEmEDZCY5xz3dIs?=
 =?us-ascii?Q?btXbg0fEOg2aGG/NTRTldfnI13B06YMNFvJYyF8nJzvv9V86H0C/c4h53eN5?=
 =?us-ascii?Q?+4PJ8BileVLyynaBVVnO4IWJxNlZ4NqYg6g4v576Wm9M3UUhAAbAsUTIoZZY?=
 =?us-ascii?Q?58HWd/NTw0oVNdFHzZe53R1MWJ786yaCNTJ59i5K?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 870aba6c-2cc7-464e-6258-08dc3e1341d3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 19:26:01.0922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tp/CnZAW+DSi7M7TMJYLgTqXECFDjPOD9PcdNkZFBFvF3T64pKF7PwfkDSkqWmkSDd+EbN4PCPOVKzVNdgMFSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7951

On Wed, Mar 06, 2024 at 06:45:13PM +0000, Conor Dooley wrote:
> On Tue, Mar 05, 2024 at 12:33:04PM -0500, Frank Li wrote:
> > Some sai only connect one direction dma (rx/tx) in SOC. For example:
> > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> > for dma-names.
> > 
> > Remove description under dmas because no user use index to get dma channel.
> > All user use 'dma-names' to get correct dma channel. dma-names already in
> > 'required' list.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > index 2456d958adeef..6f551c68d33db 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > @@ -81,15 +81,14 @@ properties:
> >  
> >    dmas:
> >      minItems: 1
> > -    items:
> > -      - description: DMA controller phandle and request line for RX
> > -      - description: DMA controller phandle and request line for TX
> > +    maxItems: 2
> >  
> >    dma-names:
> > -    minItems: 1
> > -    items:
> > -      - const: rx
> > -      - const: tx
> > +    oneOf:
> > +      - items:
> > +          - const: rx
> > +          - const: tx
> > +      - enum: [ rx, tx ]
> 
> I'm not entirely sure if this was Rob's suggestion, I got the impression
> he was suggesting that in the two items case we'd not care about the
> order. But while I think this is different to that suggestion it's also
> not wrong.

I log this at cover-letter. b4 can't support write change log at every
patch yet. Rob's suggest was not work. dt-binding check complain too long
if there are two dma-names = "rx", "tx". 

Frank

> 
> Thanks,
> Conor.