Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp119452lqi; Wed, 6 Mar 2024 11:43:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX4S/WfM+RlNlEnDCQKRVvH0WqAn3MVujePezUdRGVcmTd3Br/lU5kSO6EeIL5313ylsGBouua0R4F4yy7AEyoa9S/NeNHCQ6NDBwZdiA== X-Google-Smtp-Source: AGHT+IFle4JCUf+ep41MfyVQLf236gxAY9Qq3QWCsdCyGnB2qbVkrwgOtYcfNKuZfDlKkRlFEXGC X-Received: by 2002:a05:620a:574e:b0:787:aa2b:e831 with SMTP id wj14-20020a05620a574e00b00787aa2be831mr5824774qkn.35.1709754223027; Wed, 06 Mar 2024 11:43:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709754223; cv=pass; d=google.com; s=arc-20160816; b=jYeA1DUSeLcOS/bgYulRgIkO7v23q8rm1qxGfryCmIjGOboxwMiA9yP/Fa+fEIjwpr 85BMb2Ov6tyxpjLWNDQ2rO0oboQk8RXRqekUivYcxQCUagBxckvgwZDGoiZVGd+X6HF4 6Z5w2g3IFulb1DNpx4irrbqbjhLwb/j3NLYZGAbIlqd0xBb/sxCB2xVbrByJoWrEWQiS swVM0ZJL2tOZsjUUevLKxv0OdjMIo8W9dVQwKavU07s7iN6slJERgALlvwy1EHeN6Q96 JubgcUK3oQJGtB42es3CNYwCv0YNtXa/n07m44BY9H+Ac5ep7oojiFn2eeYZ7ZTsAciH nNFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gDP/iSV3829h5otGGMZUPM4U9pFddgAm8oqng93mios=; fh=rP9F7Vq/YTFksD1hmsyVUT2vO05iwRijywxktecoODg=; b=Dd2sxhYp41KWf78S88cDAZ2vTTQNJAGgV3ZBMW4OmQsO44klR2mogiJgXcBmmJ9tje PeAnPAT4pbaTAkPQr73SA6pofb/Gh3W6ELOLfDjGyL/mKU8ewOXrg/iqbsITH3Fn/bqR J1leBqcb9MSO0RCURz3nxQmEwAabAjHXJUMP/ZLkpeG+erpPBTsSvkhsS2spna0InZld 5Q4MqgowWCtAIruaBnxurYR+0XrLpOWTsmR9bTBK/hFDbtxBb1eVTgliDR07ALOzD3F5 I0PL69DAonPH52KNrPbkjdrI5fn6dkjyXzCWuWXV/gpU0IiCu/JRxyaOMA30TUF6yrft 0Wxg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="c/tmS/3+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94496-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94496-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b15-20020a05620a118f00b0078834cb8112si4504905qkk.269.2024.03.06.11.43.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 11:43:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94496-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="c/tmS/3+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94496-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94496-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 30E611C216A4 for ; Wed, 6 Mar 2024 19:43:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A555F14038A; Wed, 6 Mar 2024 19:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c/tmS/3+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD8F7487AE; Wed, 6 Mar 2024 19:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754211; cv=none; b=gzbNtAKHWawKnceV/DNZGoX2beAo9OE1JPl+q/QMDhl9NHEa417iBhzVXmjEL0dU/E7h05HxseGX6+OAY339gZezafHh/K0yLrYAqEHmG3fnFc+xftOKpJLjkK0aNrNTrnbRgrvB/YHT4MrDctwCtQNzh/EEFPp7lvKYRk1bU3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754211; c=relaxed/simple; bh=xtEDxEHvvvxyVXTyfp7trVYl/30Kq4/Ns4l1f2QW3W4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H3DlRlIhB0HL9LbIhdR1SweI5DrP9aCSaHY+m1M5PprFdU7amGPWTDbF0ZMgYp9pMryVF4EZD95YSCR2sC70fXG+x/nRHMdYEOnjV0BRjEx0xv9XXXcUuu3UamgthxKkqkmLS43dTNvyNobRLRQ6Od45DU09Ns+pAHCg9AGNurI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c/tmS/3+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2BDAC433C7; Wed, 6 Mar 2024 19:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709754211; bh=xtEDxEHvvvxyVXTyfp7trVYl/30Kq4/Ns4l1f2QW3W4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/tmS/3+oeDJnWr09mojyuk75EE0hGzxhYO8HuuKuTK32JURSB6KBTnuyZPYj152F DRv01rFWLtnJI0i6gxTcWlg6DywqVJcaQ82187zTI+sUg0D5pkJsqqWfbrmaVdLPIM XbDlce4L1LWH9ml/IMt2vwhnQEsI7/PiaYk0E3uZcr1jyJYH8zxVelCGttgoj0dq2+ +7GiD+/GCLwncahbWF9JD+9JtCxbomgYVfXbSQrElLCtUh+HR6y++hOdGMkMKgRKnz ItTsNW0+LeO8s0QOC22r+/RiIzdkHGf3DT63VmNqgsZ64jsPdhLyiknqKBfBkWjbKe W0pa+vlU58ZPg== Date: Wed, 6 Mar 2024 19:43:27 +0000 From: Simon Horman To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next 1/2] net: geneve: Leverage core stats allocator Message-ID: <20240306194327.GA281974@kernel.org> References: <20240305172911.502058-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305172911.502058-1-leitao@debian.org> On Tue, Mar 05, 2024 at 09:29:09AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the geneve driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman