Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp119585lqi; Wed, 6 Mar 2024 11:44:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUfZKsDLnbxODFMD4OWXkZb+9Z+nzmhapsq31rlRhdFzqvO0ItxdBO4ktFXuBpPqMzW0lJasOoXheWzv2MxcnG6jBg6s/vnug9z3mqEKQ== X-Google-Smtp-Source: AGHT+IFwmZQZeUlnuMUOWOesuhJbkznFjPue31NiYzeUd6Cv5uuuaFbqmyRpptyw9b3VpA4WOKLN X-Received: by 2002:ac8:5a55:0:b0:42f:f7b:f796 with SMTP id o21-20020ac85a55000000b0042f0f7bf796mr2656517qta.55.1709754240258; Wed, 06 Mar 2024 11:44:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709754240; cv=pass; d=google.com; s=arc-20160816; b=guG2xM2STlN2gSHW83OpPqqKvVII6xP8XVMS9HN9+1f9iHSyCfRXlqhAMyPLSr5uGY z3YDq7yyHLQj9thVWfKsppX7oN+FV50pdL599pD7UiFAn8kOUQAhZoG2amR+bE833LRk e1BOw3ST2u9C0OODkI/FRZsYfXW0EyMnag67uLrFkgeqDV3Khjeuiq7nq7hnBc2W1C7k tOz7ovtewQ3s85KNam05aPqTShvVOzG243yN/lDNDS05jxQVrzPLbpJCP49heiqtlFMs xvZ2K9T1s8N3b2XbJkwAZpZddjcw67Xw2WMtVTb8heEuFj/uDj64JL8eNFEAmtO4oVbU NDMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=P+O24L2FXYpmC0YBoSfjtLdsdJ1rxiR+lSzp6sTXTTE=; fh=rP9F7Vq/YTFksD1hmsyVUT2vO05iwRijywxktecoODg=; b=Z4/pC71bBhj/eJMGp6Hk4gbFwRhhprGNVrOfjtPxd8rX9nLFucH1zF5PUDGfQLUy3Y XAdYi5m/9bRWiklxLzTD1KqXXemi/+vvPodnra1M4DWFJTo6eEAGqsQ9AYtxw6SxW226 H2p7Bl4o+p2D1ck8kMgtmrrb0pa7atkU5qBlwqpkLsnVnwybTh3DfsRxIEoBwXTRI7Nz Em/1F3bYMOhLzEHODhvY1IZDS73U9knafo8IYR9pSYdYdcx4tHPeUf5duJ/OtSQs9xaK QQ9YfT0ngh+Hj/uF6vN/7z4P+8Jydy2a8iltHtaRSjcMs0qIob6I2AzrZ0pq2+M+RDQS DgWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VVuqLScG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f14-20020ac85d0e000000b0042efcd2116esi5697185qtx.717.2024.03.06.11.44.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 11:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VVuqLScG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-94497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C6DDC1C21773 for ; Wed, 6 Mar 2024 19:43:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32568140397; Wed, 6 Mar 2024 19:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVuqLScG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58A00140368; Wed, 6 Mar 2024 19:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754232; cv=none; b=uToBwZCrVfyGEpZuZeYihzZudYgRo7mxAEAfFWolCybtduAxbJNtvvF6CioXpJKT6naCnCnFDdA2+q/3RNW5pTh3ic2kMg1F5/znRjONSZvnZai4v0vLDvK4nxt9M2gWf4MfNE/af0OicK/7J8cqyoEYpyWmltKh6bLTnk62qO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754232; c=relaxed/simple; bh=cDcynlg09PGkT09NRyUpJm9Vb1/jsYZ/mjlNe+XyGRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z5lcCV5Ble7oB/UrhEcCpZtGCunCS2Z0slo0dIL3FcjoCy5Rbrjegefe3Xmk3Vo+y/mXj6fGLiOFiUgiEVdONUuvXEJuR8+ei9fx/iYmo5CamS3wzdXZTGfr9D3ML2VvH7Hp21G6P1LunyXUFF3mOuXunsulCgfU7NrNO3D0vfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VVuqLScG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 421BAC433F1; Wed, 6 Mar 2024 19:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709754231; bh=cDcynlg09PGkT09NRyUpJm9Vb1/jsYZ/mjlNe+XyGRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVuqLScGrbDQLbjTW+Gko6kM1DNY9/oIAe6jT28G1JpZflHZGIelb5Ibrv6VA1lKx VV3EEJrKuzmmln98Q8oujcR3jh5pFqjgR0GUrlfg3VuhaTSwYQ/QRMPJXI4ATGZcvW sDYu8ASnyK5GN10BhEu7rghIP6FeZeJaZsB0me8EjAw/ylNclzFE44FV172bNvnOTh XMYuebMh+yAHKZG3+HKPYuKgDzRqFJTYQyZbqF278Y1S/W/RMuZ8a1jQmucnYIcMmX Gsf7nCTXC0mhCbWxFB/U3cZbXV/QiPJDPGrSy5Abz8oocTsaSylSFre0/sz1AIDPkl oQbylq66sqmFA== Date: Wed, 6 Mar 2024 19:43:47 +0000 From: Simon Horman To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next 2/2] net: geneve: Remove generic .ndo_get_stats64 Message-ID: <20240306194347.GB281974@kernel.org> References: <20240305172911.502058-1-leitao@debian.org> <20240305172911.502058-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305172911.502058-2-leitao@debian.org> On Tue, Mar 05, 2024 at 09:29:10AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman