Received-SPF: pass (google.com: domain of linux-kernel+bounces-94520-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <048b4cff-9f3e-48aa-8c17-043261888ad5@ghiti.fr>
Date: Wed, 6 Mar 2024 21:00:43 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] riscv: compat_vdso: align VDSOAS build log
Content-Language: en-US
To: Masahiro Yamada <masahiroy@kernel.org>,
 Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt
 <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 linux-riscv@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
References: <20231117125843.1058553-1-masahiroy@kernel.org>
From: Alexandre Ghiti <alex@ghiti.fr>
In-Reply-To: <20231117125843.1058553-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Masahiro,

On 17/11/2023 13:58, Masahiro Yamada wrote:
> Add one more space after "VDSOAS" for better alignment in the build log.
>
> [Before]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> [After]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS  arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>   arch/riscv/kernel/compat_vdso/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
> index 62fa393b2eb2..3df4cb788c1f 100644
> --- a/arch/riscv/kernel/compat_vdso/Makefile
> +++ b/arch/riscv/kernel/compat_vdso/Makefile
> @@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD  $@
>                      rm $@.tmp
>   
>   # actual build commands
> -quiet_cmd_compat_vdsoas = VDSOAS $@
> +quiet_cmd_compat_vdsoas = VDSOAS  $@
>         cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<


Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex