Received-SPF: pass (google.com: domain of linux-kernel+bounces-94558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 6 Mar 2024 15:25:02 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <ZejRHkdBsfUAH0sQ@lizhi-Precision-Tower-5810>
References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com>
 <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com>
 <20240306-pebble-grope-88fdaa95a87c@spud>
 <ZejDQddMp17RD6Yk@lizhi-Precision-Tower-5810>
 <20240306-petticoat-womb-a61cad7d788d@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306-petticoat-womb-a61cad7d788d@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TuwwfhfWUL427kSgFt8TB4lPIn25lwg7gPaqXcjPkdzJ7H6pBkipLIkMulZ4?=
 =?us-ascii?Q?v0XO2HFFupHUS/QIcx+ASEswf3AkUGNnhbjPx/R7ohjAU0ILnCKx84GrVjh4?=
 =?us-ascii?Q?/HgBiWaXdrlEKI16793pBwesEfU8q6hk8+VNn88z1s2jTBG6uTDwBs9R2xU/?=
 =?us-ascii?Q?DsQyl7o766HL/Kg1faBw5egqQhKh/5cRQ1ujpca854cV6kPY58I6caovog/g?=
 =?us-ascii?Q?cQjsV0QqmZEaJpcKx97yGuL+4H60gaSGhxxdwj76OSQzttKg/++aF+8mTgYe?=
 =?us-ascii?Q?mV4JG/QlLbv5cj6woD8BhgF7xruzcZRxyT+ugpsSkgw/V74Vi9gYLGyC5lmC?=
 =?us-ascii?Q?gWy06Ut067HWnX8V6bg5Hg3YRJ0KzQwV77eU+3MhBeiDjNvu91JqoLf/jPPE?=
 =?us-ascii?Q?7PVPF7DlY5nh+k6dWbwBKYa3aX/ISHg0zPKylaYsRxw3JJzkqQA+I9fBQmHS?=
 =?us-ascii?Q?DJcEqe4+6NrfQEcrlg3+xELj+2JdLBDbW7qOgxv4Qwb5okKhVOWGHTI2rnhL?=
 =?us-ascii?Q?MAtWG5Luw11CEm+mSnFIzI4vDjNtUG0/0MlS2wZ0dFGUXWbCk4BRODpbmpq8?=
 =?us-ascii?Q?7Y4nfWlbkirTaHCmH6wSvPaYsR/45JfIDGxnumV/6mkLHd62YFqloYn5Mgio?=
 =?us-ascii?Q?vquzrFDWH3RKS1vOv7NwtQHCkTJkrLqwUIlaDl7UH7iN2UNhCd81twdxDvnd?=
 =?us-ascii?Q?ksWc8D+L/gqR27qGkED+alHqSia58BmfEmUQ4LdfkuCV7tWlY+fvkyLUlFJV?=
 =?us-ascii?Q?q2Cvmfw0gd1fSYOfgdzWsZMW+gKbEIZ4Udcr9oJnha6Ss07pjUrShqlwG+oU?=
 =?us-ascii?Q?4tshrrrDaxYVsEBT9K/2ErTZU58cAK4oCBA1dSoP4rZSTvA79VZTwwskIJKe?=
 =?us-ascii?Q?v/lB9bIhJdmqVnWvHj463k+0kNunMxf0+P/+wHwBTXYzyigWSmXrP18sneX+?=
 =?us-ascii?Q?sMV9ptJJIAaqVTUT4wX79lVOK5sJBeDzAEhXqWHCHi0keI7Za+4lJUw52aYP?=
 =?us-ascii?Q?WYdrJVW29MbA4L0pqx4xcJaty3N4LY9HgAaB4YUhhplDkTO0tSWt/C1gkMu9?=
 =?us-ascii?Q?KJoQLTfsL5aMIA9RNU7Yx0gfSfjpI/T3PfC1drQk5oKCZg+KSzo6tcCTxt+O?=
 =?us-ascii?Q?kisEkr/VdDNkf0TZnTqBx66W3rDOznJaUTZQS8vkoLr+lSW0sfxZABYkwHfA?=
 =?us-ascii?Q?poHvAYBqhBGN7Gqyl77aoral4PCQTNSNo5Jpt1ftiypGxxpvDW+viS65I2gy?=
 =?us-ascii?Q?9ugmijj2vAnZOdL2oDMwLG7cupUk8oNVtSOIovqXgoG5hvsNrfbHaY/pd6Ey?=
 =?us-ascii?Q?imPqz1BrqPcvSCyYVy+nV1fNdvB3zIoNEUYm0Z144QphfoFrW/VnEmEWREtx?=
 =?us-ascii?Q?OIhO63Eu4tuA5fsF37y5Q50dAy44+VXTbhJiRHEovWtLbdM4lQPwcRgpNMgu?=
 =?us-ascii?Q?3O9xLcMeVSmow+fawPoZpEB5vviXc0zWcLN/LZHK3n9gu3sYeY3R4M2PXcm1?=
 =?us-ascii?Q?JBr5LJi/MNGGS1eOulf6qjSGKqBnLZUz4ZszWKVXqqfdByq7iNVQ+Y+5IhSW?=
 =?us-ascii?Q?z+atg57d9VOC/xSu60E=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2662dc43-9dc4-4540-2495-08dc3e1b8604
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 20:25:11.4749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: foX/kCXdMrqlqm2VNfJ1dtiVv1OgN7TTMVIh1NIoplyzRpvDPrm0gh5kVq5T7qOUzr7c2S4uBLnIWnSZLUACkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7084

On Wed, Mar 06, 2024 at 07:45:34PM +0000, Conor Dooley wrote:
> On Wed, Mar 06, 2024 at 02:25:53PM -0500, Frank Li wrote:
> > On Wed, Mar 06, 2024 at 06:45:13PM +0000, Conor Dooley wrote:
> > > On Tue, Mar 05, 2024 at 12:33:04PM -0500, Frank Li wrote:
> > > > Some sai only connect one direction dma (rx/tx) in SOC. For example:
> > > > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> > > > for dma-names.
> > > > 
> > > > Remove description under dmas because no user use index to get dma channel.
> > > > All user use 'dma-names' to get correct dma channel. dma-names already in
> > > > 'required' list.
> > > 
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 13 ++++++-------
> > > >  1 file changed, 6 insertions(+), 7 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > index 2456d958adeef..6f551c68d33db 100644
> > > > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > @@ -81,15 +81,14 @@ properties:
> > > >  
> > > >    dmas:
> > > >      minItems: 1
> > > > -    items:
> > > > -      - description: DMA controller phandle and request line for RX
> > > > -      - description: DMA controller phandle and request line for TX
> > > > +    maxItems: 2
> > > >  
> > > >    dma-names:
> > > > -    minItems: 1
> > > > -    items:
> > > > -      - const: rx
> > > > -      - const: tx
> > > > +    oneOf:
> > > > +      - items:
> > > > +          - const: rx
> > > > +          - const: tx
> > > > +      - enum: [ rx, tx ]
> > > 
> > > I'm not entirely sure if this was Rob's suggestion, I got the impression
> > > he was suggesting that in the two items case we'd not care about the
> > > order. But while I think this is different to that suggestion it's also
> > > not wrong.
> > 
> > I log this at cover-letter. b4 can't support write change log at every
> > patch yet. Rob's suggest was not work. dt-binding check complain too long
> > if there are two dma-names = "rx", "tx". 
> 
> Yeh, that is what happens if you just have
> dma-names:
>   enum: [ rx, tx ]
> since that only allows one entry. Take a look at st,stm32-uart.yaml
> instead, for example.

Yes, it works. Thank you very much. I will update it at next version.

Frank