Received-SPF: pass (google.com: domain of linux-kernel+bounces-94572-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 6 Mar 2024 15:53:39 -0500
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max
 interrupt numbers
Message-ID: <ZejX0/FA/z4wa7cY@lizhi-Precision-Tower-5810>
References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com>
 <20240305-asrc_8qxp-v4-2-c61b98046591@nxp.com>
 <20240306202537.GA587561-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306202537.GA587561-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1kAk748voL9fyaGloPaP/ZYwrkAD6VXrhq89Mm1Z043Kpm4bJ6aSoanr/Zsw?=
 =?us-ascii?Q?xpF3WOivVp/8lSDZdB5cTcXJfPR3vit3aTJLdoCHs6CLjVjFJwYbwmZ8VV2g?=
 =?us-ascii?Q?vYO5s2OOdHaGn5CtSGDaUktll3WtjmH6rMtKhhfmUkpzcEpk4w6VOcNhkpKt?=
 =?us-ascii?Q?zd6sZ11gkVdYiNyYIt+7KkAn7MoZ4cfdp4xoJaBrmrCmgfsNgv7CvRlQiSPm?=
 =?us-ascii?Q?59cKFH6Fh6iEId2PVSSUpaKd9TyRlr1xGhH9eOdDczB0HxmUfA8Y9agYqzeW?=
 =?us-ascii?Q?Srvl7qIrD2o3IWUC7gDWfYQJ2fUisbwzT/OmON0rUlTil6mcpRuPvRGdV1vn?=
 =?us-ascii?Q?KQtyGAKvp5YhED010VHOd1EJ+pexADnePOi20qlceaoH4CKkFglYyNOLPlFr?=
 =?us-ascii?Q?dn4a0FwKu7DQq9w962CX0ls/1anKHfy4P4Fu+IQwXSxNirfeq2RwQWjaLUbV?=
 =?us-ascii?Q?HSBNEQbw3YrwGR3M+qFlIVI3TEscCbrEHv3y//PjKXlh6ITvWB9o5H0bpNcv?=
 =?us-ascii?Q?ZoTB5prlWbsQobN4qQAFHUnDB/SfBP6zlY833uAeiFi98SWhDz1Og+xc7VBR?=
 =?us-ascii?Q?p0BRH9cEE+I+McghIQL2QzswNVBHJL1BO7O5c2xEz+PXm9qt8SuF0enwrorU?=
 =?us-ascii?Q?UYtq9cQDhCnZ+7jBDALi03hPsOvswOmVHx1roR2eAQdjtZXunJZHepnaKETv?=
 =?us-ascii?Q?ncMwagVkA8TIqHQjcN83Y4QaitfHwaGmYmtg2I9YGhFgQYnYVuLYSHSxl78G?=
 =?us-ascii?Q?1lb9XoA1L6qiUwvy6qWSMZGfip1dax61y4SrVTdfc82Pifz/r5uk5oN4kT2s?=
 =?us-ascii?Q?DJgL1dx2Zu8PVRSXSyRymcKfHGScVJZuoRZQfWkKNjfM3C6qNCN8eiW4vNp6?=
 =?us-ascii?Q?uWSrFrU+GOFNhuvEnc83KvSLJJgo02aInTYqIQIRPfwM5ruTYRWs0I2ME6GX?=
 =?us-ascii?Q?47ldqTNtJu6uLq1RD5GK44nH0JGVaZQqVomq+dYc1zHECHpN6Pp5+Q35Ckje?=
 =?us-ascii?Q?H98Bm8VkroEU22fbhcJfHy0Y/Jejkdz+lY1mU3jbLWle5Ih4YMN23h/XACUL?=
 =?us-ascii?Q?PvEpxNzruxzNYPQ4O7akOwAYyGjppxsq3EpPnT1Vdml9I8sN6f2ttQY9Rybm?=
 =?us-ascii?Q?/+jLP9HEUZFGnofKQdcJnSH0juIfetirzm4nNDyjuME/xUfNb0s1UzbBcvJq?=
 =?us-ascii?Q?rrdOB7lYfOJ5pPkzZUQgZGiRjMYWdQjabthN1p3bgfBzSRQaf0bW8R/zqytN?=
 =?us-ascii?Q?1vRTfBOGh2VqaZ7QeEMOOGFsAQFJZOrew4nbQ8tF6E4X3dD4e0S+Dy1XJyTk?=
 =?us-ascii?Q?V0kltmfKnfVc5+VtOCXV5n92WWdvH1V+J9AB7K4yjROqO80zXiExX9WfRnCy?=
 =?us-ascii?Q?ILICtT5FjmqvA0944ftaxmRjih5yp5VHRrpAMi9N1OFrIKSYx+Iq3VlI6E2V?=
 =?us-ascii?Q?hGQj6gj+QB8EbX67E4efbhRY9B86Q6UVzpb8T+Ro4UVprejcypZ0Q9PTjQzF?=
 =?us-ascii?Q?ncRBqKc+ot+u5Lj/4npbxDfV5bbZXMlm1u42BFLZmBqqvN+/lGMiyxG8d3B2?=
 =?us-ascii?Q?WeLrLUSvcvX2uxkLmCg=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 125c0329-c2ba-4ff7-42e5-08dc3e1f84bd
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 20:53:47.2448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i8pBEh8GD/mlwKN7bekTOmBVknR49vL8iJzYocZ5j0/19R2CTbMH6Ac1/zyp4KrbKXzDAzlTDJpgpiEswo811A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8484

On Wed, Mar 06, 2024 at 02:25:37PM -0600, Rob Herring wrote:
> On Tue, Mar 05, 2024 at 12:33:03PM -0500, Frank Li wrote:
> > fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
> > have 1 interrupt.
> > 
> > Increase max interrupt number to 2 and add restriction for platforms except
> > i.MX8QXP and i.MX8QM.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/sound/fsl,spdif.yaml | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > index 56f8c0c8afdea..7f6590708e1ec 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > @@ -31,7 +31,8 @@ properties:
> >      maxItems: 1
> >  
> >    interrupts:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
> >  
> >    dmas:
> >      items:
> > @@ -101,6 +102,21 @@ required:
> >  additionalProperties: false
> >  
> >  allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - fsl,imx8qm-spdif
> > +            - fsl,imx8qxp-spdif
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          minItems: 2
> 
> Nowhere is it explained what the 2 interrupts are or what the order of 
> them is. Is the first interrupt the same as before, and there is a new 
> interrupt for something else? Or it's the same interrupts, but they've 
> just split up into 2?

It is same one and split to tx and rx. Order doesn't matter. They uses one
irq handle.

Frank

> 
> Rob