Received-SPF: pass (google.com: domain of linux-kernel+bounces-94592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 6 Mar 2024 16:19:11 -0500
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Conor Dooley <conor@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <Zejdz0BKwSlsio9S@lizhi-Precision-Tower-5810>
References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com>
 <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com>
 <20240306-pebble-grope-88fdaa95a87c@spud>
 <ZejDQddMp17RD6Yk@lizhi-Precision-Tower-5810>
 <20240306205524.GB587561-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306205524.GB587561-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zC+rAsZ9hrvEv9wLvb9SPvPNDQi3i//bjOf0nOeghCIa8QxHzY+vPiigIGy1?=
 =?us-ascii?Q?BJFMImyQrXntWHXfmrirL2YF3mVx5OLjuTbNCFEs/50lejT/yqn7gxHWEflQ?=
 =?us-ascii?Q?RyuY/dvk65BUgzr61IcHmU63DFzVWY2t3TawmWR0RUVDk6wV2nhf79C3tHXK?=
 =?us-ascii?Q?FP2EcSktjxh8o01WjFDl70lZs8mdVLrJQp498hfH387F+/0Q0de1s7F+K+FJ?=
 =?us-ascii?Q?kCAsjboKiUjew2Rbw6wjtzXB57ikFt58Wj+mq/HNmip2KtD5qAESDDf4MArU?=
 =?us-ascii?Q?b69S6HhzJcTHsyZ6TCbWCFSDDqRda1vpmxIIn1Qd8YLI4tVLC6N9x1ke46dm?=
 =?us-ascii?Q?M6a8qr95F9F0yfivezM5PqvyWQehfelKD3fJ4bkLJ2bElUsAlDj0IqpihJyg?=
 =?us-ascii?Q?LbZFK5wCWbUNwv0bWPHOIE1mpXiuSfFhYzhMR8xcVTV8j5ukbH01hJpc/As0?=
 =?us-ascii?Q?VRABtTxpiXm0NMP4D/mCTqERzHEXg3DcmKoknCLRTQwqveDmux838FWAHEPJ?=
 =?us-ascii?Q?wR4K14FozdZfVfWRDMiD5b0szvLetSvkh12Pbvfv4Iwxq2mI9cDOsytc7kjF?=
 =?us-ascii?Q?fRFRTKD/iuNGR4en3hHl0cYGE0/U9jT9g58Dcj5BEnXwIDIPr94m8KbDbg/l?=
 =?us-ascii?Q?75fQI7CXIXT5nC5bfRtdqaBBAUkScEun6QqWrt2ClzSENJpjJYUEx8DTWAlx?=
 =?us-ascii?Q?G7o+fBXjG/UO8ONzApFNIOXlGovYmY1/h9j0yje4+W6cY5kQjOiMuVbD6bmL?=
 =?us-ascii?Q?qzkVpJOfKhj7UyQ6MJpmDlS7n+sEYscsH17l2blWxA7iD64xPT12c+KQXM4z?=
 =?us-ascii?Q?qAfX1Deww5gN7Jq1ZkFrbMBAoQ5zy3BUmTBFWse1G5be59UhPA8J2ZXMSr/e?=
 =?us-ascii?Q?D6ogpPOt0fIrnTwVtKjxhy0UYalbIVQwge8X4IUa+ftihADzvhqz4acfMy9s?=
 =?us-ascii?Q?O6ePZbKLyTNEzbPJ7CB5VZuzbruGk1MBphaL0lQRA+Pehog6UlqXLVrAs0ll?=
 =?us-ascii?Q?BnzsDgdpco8YijJJOIDH2vm+z/nPiBVgWJIFe1ODPyC32J02QPngdWjlHete?=
 =?us-ascii?Q?SNwlY6sfsTvoEs+SiGx42tPZsDff66w6id495kdBHl1BWMlUDA8jN/knOtMN?=
 =?us-ascii?Q?9blFcctV02ckfLZcsULFS7ex+fiI3Lsy5SpCBkGypzC9Cs8X+cMX+COc5FAW?=
 =?us-ascii?Q?lLM0TC1qo+5NjOeVLXob2V8OGqhfXHBJEyGdq/jRgNChEMa1CRZT7CNB3FA3?=
 =?us-ascii?Q?lB4nuBgGUfpgzACHfl8zrm6z3Yq0quD9TF1jgw2eGYeOARwVc3Sz7KWLnwnU?=
 =?us-ascii?Q?jhxfFcUv+zehId6gx+RkIVMXTKeaUDATUHhBTATMj/MwCUYmquzpSjbqpssm?=
 =?us-ascii?Q?kp8ftlyA141+XDraXpogxtWoAePXp1yqr+qRTh5hFEROoNQU4uyGSIF4R78j?=
 =?us-ascii?Q?9ygIX75wn7SHH1NrNrp+Ll/jO5qn/OhW/rfCkwdJdv8gTapAE1L5WPvgsAkq?=
 =?us-ascii?Q?X228GPyyiPmYqymxUrW5GuZj1h3UH4HII1t6f+D9uZebM0hn1ChttrGRmNKl?=
 =?us-ascii?Q?ao4lR555bU6Df1kRQjbElBoo+2/M4uIycj+r/znw?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fe46367-cedc-44a0-f028-08dc3e2315f3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 21:19:19.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EeJjPHlanpqvjjiJAOfwFKr+qnn8YrI6ICIgSRXpLqju84ehW2A5eDs9bQs8fQFdFMzopIodlrsXmEWua6FeVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8288

On Wed, Mar 06, 2024 at 02:55:24PM -0600, Rob Herring wrote:
> On Wed, Mar 06, 2024 at 02:25:53PM -0500, Frank Li wrote:
> > On Wed, Mar 06, 2024 at 06:45:13PM +0000, Conor Dooley wrote:
> > > On Tue, Mar 05, 2024 at 12:33:04PM -0500, Frank Li wrote:
> > > > Some sai only connect one direction dma (rx/tx) in SOC. For example:
> > > > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> > > > for dma-names.
> > > > 
> > > > Remove description under dmas because no user use index to get dma channel.
> > > > All user use 'dma-names' to get correct dma channel. dma-names already in
> > > > 'required' list.
> > > 
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 13 ++++++-------
> > > >  1 file changed, 6 insertions(+), 7 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > index 2456d958adeef..6f551c68d33db 100644
> > > > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > > @@ -81,15 +81,14 @@ properties:
> > > >  
> > > >    dmas:
> > > >      minItems: 1
> > > > -    items:
> > > > -      - description: DMA controller phandle and request line for RX
> > > > -      - description: DMA controller phandle and request line for TX
> > > > +    maxItems: 2
> > > >  
> > > >    dma-names:
> > > > -    minItems: 1
> > > > -    items:
> > > > -      - const: rx
> > > > -      - const: tx
> > > > +    oneOf:
> > > > +      - items:
> > > > +          - const: rx
> > > > +          - const: tx
> > > > +      - enum: [ rx, tx ]
> > > 
> > > I'm not entirely sure if this was Rob's suggestion, I got the impression
> > > he was suggesting that in the two items case we'd not care about the
> > > order. But while I think this is different to that suggestion it's also
> > > not wrong.
> > 
> > I log this at cover-letter. b4 can't support write change log at every
> > patch yet.
> 
> It never will (probably). That's because it doesn't need to. You can 
> just do it with git. When you edit the commit message, then after the 
> tags, Add '---' and put whatever you want after. That works as long as 
> the commit is applied from a patch as 'git am' will drop it. 

The key problem is that I don't want to lost notes when respin patches. It
is easy to make mistake when I copy old serise change logs.

Previously I use git notes + git-rebase, it work fine. Notes can be kept
when I do rebase and git commit --amend. But one thing is not good. 
git send-email --to-cmd=./script/get_maintainer.sh *.patch. It can't
combine all patches's maitainer to a list. It looks like difference patch
will be difference --to list.

b4 can help some case. But can't keep git-notes information when rebase.
It should be git bugs or feature missed.

> 
> > Rob's suggest was not work. dt-binding check complain too long
> > if there are two dma-names = "rx", "tx". 
> 
> So I'm wrong or you didn't have it correct? No way to tell with your 
> explanation. Let me give you the exact schema:
> 
> dma-names:
>   minItems: 1
>   items:
>     - enum: [ rx, tx ]
>     - const: tx
> 
> This says we can have 1 or 2 entries. The first entry can be either rx 
> or tx. The 2nd entry must be tx. That's what you want. However, '"tx", 
> "tx"' is allowed with the above, but we enforce items to be unique 
> elsewhere. Or I thought we did, but we relaxed '.*-names$' at some 
> point. I'm going to fix that now.

Conor find out my problem. The below code works. I missed maxItems.

  dma-names:
     minItems: 1
     maxItems: 2
     items
       enum: [ rx, tx ]

Frank

> 
> Rob