Received-SPF: pass (google.com: domain of linux-kernel+bounces-94598-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0a8b2f97-47eb-481b-9373-2f39461713d7@intel.com>
Date: Thu, 7 Mar 2024 10:23:45 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 005/130] x86/virt/tdx: Export global metadata read
 infrastructure
To: Yi Sun <yi.sun@linux.intel.com>, <isaku.yamahata@intel.com>,
	<yi.sun@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, <chen.bo@intel.com>, <hang.yuan@intel.com>,
	<tina.zhang@intel.com>, "Kirill A . Shutemov"
	<kirill.shutemov@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <eec524e07ee17961a4deb1cc7a1390c91d8708ff.1708933498.git.isaku.yamahata@intel.com>
 <Zegx6R4W3lVd+5tx@ysun46-mobl.sh.intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <Zegx6R4W3lVd+5tx@ysun46-mobl.sh.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnVBT2hFUHFaQ0lWNktkOGJnS2szdDRsQjVPbE1MUWtQWXZBN3AxbWR1R0h0?=
 =?utf-8?B?SG5RbUJXS3dzaG9MR2E3b3lBbC9CaWNhV1l4WXN6Y1lmb3ptekkxY1RPcTRl?=
 =?utf-8?B?M3hHbEpPQi9rR3ZGQ3pqaW0zRWxRVS9BOHpObmtLMXBEVTJNSktuZEEwVjd0?=
 =?utf-8?B?aWhNMlcrLzZUVGdYU2JnWUtpYzBMN0NlVnFhR1hkMDVOc2VCMHhxamliVC92?=
 =?utf-8?B?RUFaSW9KbHBTU0wrQ0Z2VlJHeVNaMHBpNjV6TjFhbUt1aTZvSjc3UTQxTVBk?=
 =?utf-8?B?UXNPOEttNlNMMHcxY3o2NTVnV2NvK0xrSW1mdVpqMlVPUFdyeWprc1d1Q0dp?=
 =?utf-8?B?TWRQUmI4RTRXSlRNd1VGTi9aUU92YUM4a1FmSGhCaDE4cXB1RDJyeTg5djFY?=
 =?utf-8?B?dVlHelIwN3JvdXF3MTBhUmhJWDdsT2NsNUJpV2RvcEpFakF2R3dzcGpSZldM?=
 =?utf-8?B?NERaRDRvcFc3OVJjdTNoUjZCTHVNVzBEQjArMXVoTldkam1taFZvc3NrNkFF?=
 =?utf-8?B?dHlHL3RRd1grWHlkOG1QM0d2bmVpbjlXcXpxclZqSzVTMGgrQ3pCSkZ5T29N?=
 =?utf-8?B?dkpHZzVrLy9LV3BpQUxaNUpCYmRVQjEva3RZaXJ2Z2VHQ00vRXR5WVIrbkdT?=
 =?utf-8?B?MUo4UUgyYW1IRE5NVEdBRytaanhKcmYyNi9KRU4vbVhWK1BJM0kzL09LM09F?=
 =?utf-8?B?eWdBV2IrUFhFak5oYis4MU9DcU5XM1NGeTFySkZGZTdoWTJGOENMZ2x1V0hk?=
 =?utf-8?B?T0M4S2R4S2l2YUZQTmdUN0RtdEFyM3FkYitSNk9TUVNpQjgrd09YUlYyZ3lu?=
 =?utf-8?B?YVl5c3FZMWJoNEZHK1dXQzZFbkd3MUptaE9GajI2RzlxNVE5S2JmOC9OcXlG?=
 =?utf-8?B?S3kwcjh5eDA1d1Y1eUVId28rR3dxU3NuNkxFYkxsVFpnYk0rUlNpNUYvb29E?=
 =?utf-8?B?c1o0V2x6MTBPUFc1MjNPSG85S3NQNzFzcnFVU3dBNVd6bUVqL2JpVHF4NVpz?=
 =?utf-8?B?RkJXbjUyQTdvTmhLbUQyRDhEemV4MlNrSXorcWhoQUNOWFlKNytsZG0wY2FL?=
 =?utf-8?B?cWErZFRxSm5mdmtMMUljWk9vV0tsQVAzdzhla0NCd2dXcHhwK2orR3ppcVBi?=
 =?utf-8?B?RkJKcFA5aGlYK2lFZHFYZlFVSG9WTjNlWkcveERFczhnQWpnSmUwZm5zc2x6?=
 =?utf-8?B?TXZ0eXdxRGp1eFpIQkZmbGF0d3hJWmVOVE1QM1FYMVlPL3gxb3RycVQ0Y0FB?=
 =?utf-8?B?TXRDa3FYZVAvSVN1NmlVR3cxS3VTSWdwOGtVQUYxWVM4M1VtL3BaL3FVeUg4?=
 =?utf-8?B?enE2MmFXNG5CWVZobHpRcHFWUGJNc3hBZXR1KzA2TzhKcEtkbllOZmRjM21R?=
 =?utf-8?B?TXp5ZC80OWdWd1BaNXBBWG03NzF6R0dsaURHQXJpVjE3Yi9aeWp2TXlOeDJ6?=
 =?utf-8?B?Mjk1b3dHYm9UNlpuNlRQV2d3ZXVhOXlDbUNzQnhodWJnbHBHUWQ0QVJPRWlV?=
 =?utf-8?B?anFMSzNmT01ENC92OGcyMzV0SVJUa0s0UXQvZlRYYi93UkxuY2huZmtBcXlK?=
 =?utf-8?B?enB6TVA3Nkp3QXd1UEE4alR5K2xUVGhXdDgwR3ZLQVh5YkhoZVMzWlVHQTZi?=
 =?utf-8?B?THErQ0lWWWgrUENlZlJXTXJ2RXNMRGFBRDlVVHhBaTRRSkRkTDVid3pnakkr?=
 =?utf-8?B?dURCVG84MWZkaEFHaFdtTzl0NXZUMmc0NVRReHk3MDRzd3RIcFJ1L0Vrd01n?=
 =?utf-8?B?YUFMRVJSVlBSdmI3MFY3VG41b2JpcWgyV290Q3JXeHBnWGJzTUovV0RtZXl5?=
 =?utf-8?B?elhUenFLaXljdUVGSjM5djhlc2liNXY5SGJWUDNoblI2Y2JkeFVDUVdOOWFS?=
 =?utf-8?B?SXJZbEhrOWFJRGdkazFXNklJd1lQdXBsQmtDdTRhVzBGSVQ5VHUzUS9uanBD?=
 =?utf-8?B?OCtIZzJCV1Iranpyck1HZUlMTlR3WlcxYnh3L1YxSzZORWxoeWZtSkFEUlFD?=
 =?utf-8?B?K2xXWldrSkUyZThrYTViWXAvTVpXQmFlME9XN095R0ZVRmEwRHhpZVR4a3lu?=
 =?utf-8?B?WDYrMmlFU0kvRHRDakNkRUtqbDUvQ3dxakhXSm1QcWg3NGU5VGJTM09aOVVz?=
 =?utf-8?Q?6YEV62mL8KzNUGv++lIMNMhum?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0ffe198-f815-45d5-bd29-08dc3e23b9cb
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 21:23:54.3517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2pA+MwAaFxmuckb3QKCt58F/VR6MJADRn3o1H9Zr9V+DSh64zi9lN3EjIx9c4F8cOBS+ASs7Zy2MAQlpZLW3lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7588
X-OriginatorOrg: intel.com


> 
> However, the function cannot be compiled if its definition remains in the
> vmx/tdx/tdx.c file while disabling the CONFIG_TDX_HOST.
> 
> It would be better to move the definition to a shared location,
> allowing the host and guest to share the same code.
> 

No not in this series.  Such change needs to be in your series.

Thanks,
-Kai