Received-SPF: pass (google.com: domain of linux-kernel+bounces-94602-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 6 Mar 2024 22:33:06 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Yangtao Li <frank.li@vivo.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback
 returning void
Message-ID: <h2sjdrgs7hwmbucr3rxlpusnkpj5tgq2fx27gijtrglr5ffhs6@s63cp4isu4mx>
References: <20230712094014.41787-1-frank.li@vivo.com>
 <20231204115517.zxjgi6ateobjj52d@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aobpo24yxtew6zdt"
Content-Disposition: inline
In-Reply-To: <20231204115517.zxjgi6ateobjj52d@pengutronix.de>


--aobpo24yxtew6zdt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Rafael, hello Daniel,

On Mon, Dec 04, 2023 at 12:55:17PM +0100, Uwe Kleine-K=F6nig wrote:
> On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is (mostly) ignored
> > and this typically results in resource leaks. To improve here there is a
> > quest to make the remove callback return void. In the first step of this
> > quest all drivers are converted to .remove_new() which already returns
> > void.
> >=20
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >=20
> > Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
>=20
> Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Can you pick this up?

This patch isn't in next yet. Is this still on someone's radar for
application? Would be great if this patch made it into the mainline
during the upcomming merge window.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--aobpo24yxtew6zdt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXo4REACgkQj4D7WH0S
/k62aQf8DUtqxc5xcDdA1xe6wBwVnuEiYFf9lf8qwNUoBlOCE1hR57BLXVYZI3Cm
DK1IIcg0qZ5+QvAqSn9L7jxPPrKnOQlh8UsToPpyuTCHQ6be5NVxO7aBEajJrwfL
0ahGrTRn7OdgFOLGqJzbuH+aOUUmxfqBnEF9HXm0lzmPKZDubOZGvOb3iHJ5Td9z
Y6h83Y885gY0XKk2H+YHeDzr2vgUmnkEE5M3lxR4lYuRGb7jjei8qy2Jf9NtbGY4
aA4vJmrzVAGASho7N+ZMj2dyqMXTCV426F7c/qWUGmndwhwErhsrLen64mEmibnH
SYxRz9mJ+aVW93brufO7Z0orYdhi5g==
=AEYf
-----END PGP SIGNATURE-----

--aobpo24yxtew6zdt--