Received-SPF: pass (google.com: domain of linux-kernel+bounces-94603-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b81edf65-45bd-4412-b373-16732a0d1abd@infradead.org>
Date: Wed, 6 Mar 2024 13:33:36 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] docs: w1: Remove w1_gpio_platform_data
Content-Language: en-US
To: Ayush Singh <ayushdevel1325@gmail.com>, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
 corbet@lwn.net
References: <20240306194629.356001-1-ayushdevel1325@gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240306194629.356001-1-ayushdevel1325@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/6/24 11:46, Ayush Singh wrote:
> `linux/w1-gpio.h` was removed in a previous patch and should no longer be
> needed for using w1 gpio.
> 
> - Removal Patch: https://lore.kernel.org/all/cover.1701727212.git.u.kleine-koenig@pengutronix.de/
> 
> Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>

Possibly add:
Fixes: 9c0a5b3f9e55 ("w1: gpio: Don't use platform data for driver data")

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  Documentation/w1/masters/w1-gpio.rst | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/w1/masters/w1-gpio.rst b/Documentation/w1/masters/w1-gpio.rst
> index 15236605503b..5d7eebc291bb 100644
> --- a/Documentation/w1/masters/w1-gpio.rst
> +++ b/Documentation/w1/masters/w1-gpio.rst
> @@ -20,7 +20,6 @@ Example (mach-at91)
>  ::
>  
>    #include <linux/gpio/machine.h>
> -  #include <linux/w1-gpio.h>
>  
>    static struct gpiod_lookup_table foo_w1_gpiod_table = {
>  	.dev_id = "w1-gpio",
> @@ -30,14 +29,9 @@ Example (mach-at91)
>  	},
>    };
>  
> -  static struct w1_gpio_platform_data foo_w1_gpio_pdata = {
> -	.ext_pullup_enable_pin	= -EINVAL,
> -  };
> -
>    static struct platform_device foo_w1_device = {
>  	.name			= "w1-gpio",
>  	.id			= -1,
> -	.dev.platform_data	= &foo_w1_gpio_pdata,
>    };
>  
>    ...

-- 
#Randy