Received-SPF: pass (google.com: domain of linux-kernel+bounces-94608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 6 Mar 2024 22:35:37 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Dov Murik <dovmurik@linux.ibm.com>, Ard Biesheuvel <ardb@kernel.org>, 
	Dan Williams <dan.j.williams@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, kernel@pengutronix.de, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove
 callback returning void
Message-ID: <dfw3rfgifkv5qliwzxlziwq5kvud4vdro36v22celda6wasy2d@fpcpgcuo22bo>
References: <cover.1703596577.git.u.kleine-koenig@pengutronix.de>
 <4a97c8e6996c9c95244715310b57ce5af6ccb1ad.1703596577.git.u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="nalqg2xhdoirh5tv"
Content-Disposition: inline
In-Reply-To: <4a97c8e6996c9c95244715310b57ce5af6ccb1ad.1703596577.git.u.kleine-koenig@pengutronix.de>


--nalqg2xhdoirh5tv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Dec 26, 2023 at 02:28:02PM +0100, Uwe Kleine-K=F6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Is this patch still on someone's radar? If a resend would help, please
tell me.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--nalqg2xhdoirh5tv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXo4agACgkQj4D7WH0S
/k5gxQf+K8fES7NTp5SLghXaAI5B67y9x3Yycg/wXPfcgZq3eXDjJAD8zhdKF1Hf
HJUT2i4GJh/uLUtzAjoMjP6/60zVGsFOQO3h3NnHrR5qp37oyC/aKaCa6J3Uwekg
Dva7Ompmdi8aE3L6401B9/30niParIlkJ6OBeNvU3xS7qeajcA1h8FUX/8l50YZF
/zSQPCm77Zl5P73h7CZO2vSVpuvjbHEWbdybduFCrc9cXm/jAslBlOp4CsFYtW7N
NnybBD72TwE2Afu3RpOD3N+Z6s9+fc9yIpmqE2/gcDwOMySAVD3UYcrW6SkLAd1C
HSl22cnHcefGO5ULjeTfBdEkbApVuA==
=YVdu
-----END PGP SIGNATURE-----

--nalqg2xhdoirh5tv--