Received-SPF: pass (google.com: domain of linux-kernel+bounces-94618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Luck, Tony" <tony.luck@intel.com>
To: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>, "Yu, Fenghua"
	<fenghua.yu@intel.com>, "Chatre, Reinette" <reinette.chatre@intel.com>,
	"Shuah Khan" <shuah@kernel.org>, "james.morse@arm.com" <james.morse@arm.com>
CC: "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
Subject: RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages
Thread-Topic: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages
Thread-Index: AQHab7KwshA04b3b7kGAda4tCZ9C1LErPGXQ
Date: Wed, 6 Mar 2024 21:54:02 +0000
Message-ID: <SJ1PR11MB608310C72D7189C139EA6302FC212@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <cover.1709721159.git.maciej.wieczor-retman@intel.com>
 <8a158ada92f06b97a4679721e84e787e94b94647.1709721159.git.maciej.wieczor-retman@intel.com>
In-Reply-To: <8a158ada92f06b97a4679721e84e787e94b94647.1709721159.git.maciej.wieczor-retman@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/FIFQioQUvbYKgki4lVV02I1G8s/rg67uwPxvWpdv7Cj3iT7+HqtLZa11N9o?=
 =?us-ascii?Q?tYUGAZUTNsqrOGhnPZb5nMoaDatX7Z4zANyymJxQuT+OicgZArxIs8UHekUQ?=
 =?us-ascii?Q?pKLrbRvkNJkh4Y7bNyeOJJ12NOG3pTch05opHQyPNOgLZlUVtev2YngkRh5j?=
 =?us-ascii?Q?sJ+KciEbHq44Ob/lltfa8RPHy9VJ9UvaCuSCEG9pc3CJ9vocwOFxpzZGSzWs?=
 =?us-ascii?Q?8ittwEcHJEQvpHCfIdkUMsrsaIKFu+ziQFzP0qCpu5mooD4kYluggx13titZ?=
 =?us-ascii?Q?s9ox9uMThjV1jCQDy8BqbtGe+z21sWUyfbC/MYVEzqDTN4Hfgv8OBLliowM7?=
 =?us-ascii?Q?ndhH6kGoFh1UP3TPB9gD7TG2cdqm+l4WS5OGMOvKOzMs7QgV+O/XyN10Sjme?=
 =?us-ascii?Q?WQNUYXdTlLfsm9kw2fEgV53o7uLOL+RIYFCee1Tqym/rmYOC5iS11NuJUJKD?=
 =?us-ascii?Q?u2kMbWzgneNX0ROEjEtOaN6qFsO2WTSerV+hOB/jjw2WamDSsfsA/jucFY73?=
 =?us-ascii?Q?5P9+i+uswm5khyUWrVX+abNw8VFpWjj2GS4ShOX8N9ddSERXXCjn8OQeu2kZ?=
 =?us-ascii?Q?5CynPpx7aC/InCj2GwAU0PltbX4QyMYhTFfxOaeqK7CFGccaXe3Yy9eYIxGE?=
 =?us-ascii?Q?SjYNLtJjK2NDM3L+m8vzIgocJQ3YYCHzCusvs8OY5Zbosb6/O917VMpdNi5k?=
 =?us-ascii?Q?Ez3b9Vm182F+bbqkC6v1lv/XMgX0nH5Aka8h2wkgkqeh3ePPFQFnoRr2dv0H?=
 =?us-ascii?Q?hmniIFkGdTfSgytzc1gjeO9xZvibrp8T47qrZpIKRbCLsWb8vJzECSfgPH7P?=
 =?us-ascii?Q?YPnf0i6s4HjmGtwFPan0nTnfnGNqjpokeOdrHVz7T+0XLvfGgfP0Kz0Z1S/+?=
 =?us-ascii?Q?mh6u+PHL5l7zlPT6yc8m6xQbw5CF/bvh1MEegDWQs1yrA92e2QHuRK2ByIdS?=
 =?us-ascii?Q?U7Hp+XEJDGtS5XTU448TeRcL4d/TUpD8DH7vAJHPmo1MmWZTsM+u1egSiNgf?=
 =?us-ascii?Q?nZpPY5ovbcdi8mWhBBcgUc1ssisMM6d/OMWSC8hNptp5V2z/VosKnLiSAL7T?=
 =?us-ascii?Q?R67/HljT8mrkzDtVnBGARHW36R2SlOa+RRWdeob4GPJTZrTPUjk7FsmOzfKq?=
 =?us-ascii?Q?EndEWAQkehb1K9arrMMX/py64AACGBFGoxeRP1ly4Jqs3Wcq2ugEn9HsC+5J?=
 =?us-ascii?Q?Ulj9Lx2SVInaZ5HAyStwL1mlnkfDcISdnbAVNafAFLQu3zfWNY9dgwxnMyia?=
 =?us-ascii?Q?GIGBfVw3tJ9FJLg3ayUQiVNydKciZhgg9Z1aHrpl9zBesjtNdNUiPEtcEJfk?=
 =?us-ascii?Q?UTR5IW/UISop8u6E3kyl9xCshebpdRUoGnx87hyyquGgmT2S/+HyC28qjC2W?=
 =?us-ascii?Q?dhkPFeoma3R+gFj53oZ7ekICpTf+49e+wwQ3/8049J97kbGUeTHqO+NLSTsy?=
 =?us-ascii?Q?HeGN9v6h0Akk+TVmpyWDnJfix3n635SisxTJdgojMcfoab+cJ1RpRpQTF6T1?=
 =?us-ascii?Q?LHKFfk3Iw53JBMteUJxSZI3C4D6U/h26DC32FBjGoDfM5rD+vCKL5wFAO2XJ?=
 =?us-ascii?Q?vt8bLRInCOhX3Pl8d8jPqhTrrXEpT4KFRrLbSdyp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66f3e011-a4c0-44a7-8773-08dc3e27ef86
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 21:54:02.2363
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +zguIfIsVgQL4psRXltZbI4Ip5rNNw4YI9iqnVTEewGN9Qm8ulKEnKiaLcBNuubV22fW39QFFKPClHaWJhgAtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5949
X-OriginatorOrg: intel.com

> Figuring out if SNC is enabled is only one part of the problem, the
> other being whether the kernel supports it. As there is no easy
> interface that simply states SNC support in the kernel one can find that
> information by comparing L3 cache sizes from different sources. Cache
> size reported by /sys/devices/system/node/node0/cpu0/cache/index3/size
> will always show the full cache size even if it's split by enabled SNC.
> On the other hand /sys/fs/resctrl/size has information about L3 size,
> that with kernel support is adjusted for enabled SNC.

Early versions of the kernel SNC patch series added an info/l3_MON/snc_ways
file to provide this information. I was talked out of it then:

https://lore.kernel.org/all/f0841866-315b-4727-0a6c-ec60d22ca29c@arm.com/

But that discussion didn't consider the question you discuss here: "Does th=
is
instance of the kernel support SNC?"

So you have a clever solution. But it seems like a roundabout way for
an application to discover whether the kernel has configured resctrl for
SNC mode.

Should the kernel provide an info/ file listing the SNC configuration?

If so, what should it be named? "snc_ways" as a kernel variable was
later replaced by "snc_nodes_per_l3_cache". Is that a good filename?

-Tony