Received-SPF: pass (google.com: domain of linux-kernel+bounces-94656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6d92f593-77d8-4008-af3f-5b5bc790b87b@intel.com>
Date: Thu, 7 Mar 2024 11:25:49 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 008/130] x86/tdx: Warning with 32bit build
 shift-count-overflow
Content-Language: en-US
To: Isaku Yamahata <isaku.yamahata@linux.intel.com>
CC: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	<isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, <erdemaktas@google.com>, Sean Christopherson
	<seanjc@google.com>, Sagi Shahar <sagis@google.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <a50918ba3415be4186a91161fe3bbd839153d8b2.1708933498.git.isaku.yamahata@intel.com>
 <2f6897c0-1b57-45b3-a1f1-9862b0e4c884@intel.com>
 <jvyz3nuz225ry6ss6hs42jyuvrytsnsi2l74cwibtt5sedaimb@v2vilg4mbhws>
 <20240305081219.GC10568@ls.amr.corp.intel.com>
 <75adc31d-6632-4ea1-8191-dad1659e7b33@intel.com>
 <20240306221728.GB368614@ls.amr.corp.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240306221728.GB368614@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVZWUzFKU2lQYzcrLzRkaDdHdWlIY2s2SHhEeVRVL2lYQ1Zoc0RWNklZSWlX?=
 =?utf-8?B?dVNSQXUyQTFybVE3UUYrN3JVSGRSN3FUS1lzcVdBTzVVbjRWaXMvaWFkc3NO?=
 =?utf-8?B?dVE1NXVlMEtmQ1NaRnZaVXFQL1E5MUdHRHNSQkdpK0RMZ3h4OHh5VlQrbkZH?=
 =?utf-8?B?VWpxc04wN1RrbjVtd1BZd3lwMXpYaC8yK1oxYWMwdGpTYjJFblFQN2MyYS9V?=
 =?utf-8?B?N1puN2tsQ21RSllFVlhDSHQ3Mjc4Q0I0R0doMnBtZis4ZjNmWkhySG42aUxI?=
 =?utf-8?B?UHhKcU12UTFJbmRFeWdtMHRHYWkxOG9hSVdMWld4Z3lycFpEbjhQU0c1WnRI?=
 =?utf-8?B?bDJqVmZBb2xwa0RQV0RPdU9aaGIwZGRlZHkxMmROVEdKd24yN1NXZUN6M040?=
 =?utf-8?B?M0FkeXY0VmxieUFqZnlIcjEvSFpuZFZpVmZlMCs2cmI2TDhHRDdUb1NoWVBR?=
 =?utf-8?B?eVV6eHVha2NYYmp1bTBhWmJYRElpUWUyWjJ4SnpLbUMyaTNpOCtuazFhaGVP?=
 =?utf-8?B?YWJ1WUkya05wN0ZOWk10VzRpLzFuRHczLzZCdGk5YlNqVWRJVEY1cStHZXFH?=
 =?utf-8?B?SDFqRm9JdjZtR24waWlOUzBFek9aOEI3OHd5K2l5UHVmTFBqMmgydGtYby95?=
 =?utf-8?B?aTJQMXRUdERpeGhMVklmWGs3UkJFWWJPMEdpSG1ORWI3UkpyeUcvRUhpRGRZ?=
 =?utf-8?B?cytZVmNQM1N4c3lFNlRQVzN1K29CUUVxWi8rdzdCYmxrejdhaWt4UWtIdmtY?=
 =?utf-8?B?UGhDMXNHRVh4K3hXNm5OLzRmcUtEUmk0WWErTVZWOHdhVGVIRWFGMGRlR1k3?=
 =?utf-8?B?aEYwcmo2NnJtZWtaZ2Fnem5XNXlTZDNSbnFYMlM3M2x2b1Z4SHJnWmlSYVZa?=
 =?utf-8?B?L0FBRmRaK21BbGNXNEMrbGtvTkpkbFMvVXJOd2pmYmdUa3RrL1Z4eVFSZStt?=
 =?utf-8?B?aEZ3eGkyeGp1Z1FuQmFzaWovTEpicmpXR1FwYlVvNDBSSkRkUExNS2MwdWRn?=
 =?utf-8?B?R0V0eUhldnd6ZGY3c0k4di9pV3V4aEhFR1plci9xcG5oakZ4RWljSEtoVVFM?=
 =?utf-8?B?L1RJWXRpek5DQUtnc2xIM1hOcVJVV1NOTEtsMXc4SHFmclNvY2JCZFZuaEFH?=
 =?utf-8?B?VGVQeGUxL2IyTTJCdFRSV3E1bk5DMmkvbTFsNS9ZRktsZGpPdjVTVHVRaHQ3?=
 =?utf-8?B?cDRTaW9renkxSTZkWU14c3R6YVdVT243NDBVS3l1OU5Nd1NlUE9kamZKMXN4?=
 =?utf-8?B?U0xTNVVuMG0xM2tTRFgvNHJFb2pCQmpBMytiYkhUVDBBTXZabzhIc1o5ekJW?=
 =?utf-8?B?enBRaHoxK1RkQUU0Mk92bG1iOGcxSlozR2ZrVGVHdDRFY2w4eHFCcTRFM0po?=
 =?utf-8?B?TXFMMENlVkgyUTlycHdZbGN0dmtEY1RiZUVtWVJsSElmaVU0aDkrVGkzVGRh?=
 =?utf-8?B?aXVaOTJUMVdtd21RV0FnbTRoSHBYVnRsS3RJMnM2Z1pPT1BQbS92QyttMjZw?=
 =?utf-8?B?SmFKa0MyYmhGdDJUc0VYdkZrODR1VENIb0ZrODBtVEttSUdUL2xjcDBtaVZZ?=
 =?utf-8?B?Yld0aStNN2RneEJoenVQclhHS3pWbElsSUxDY091ai9Nd0FrSkh5ZlJNa1Jo?=
 =?utf-8?B?TzVmbU1na3ZoV3J3K2RUOGFCcWFLc0pxVnh3VDBBV0pWMWtTRFlNWjZjQ0lF?=
 =?utf-8?B?MUJ2dW1pQWovem1jMzhzcHAraUMyc3BUS2lYT1cwMmxQSGN6RmJiNC9TTmdG?=
 =?utf-8?B?QWoxYkQ0ai9oRVJGL0grVkIwQ1JoWXVKNjBjc3ppV1dBdXA1V0NiK1haREpT?=
 =?utf-8?B?ZFRjZUhPNVp6TlpKS09wK0VrTEozVUNHZkdDMzkrNjAzRWhIRlhHdGgzeHhv?=
 =?utf-8?B?Y3FtTmNHWlNDbGRUaGNTVytNb0c3QWprRWdhVUpZYXlOYUVCVkd2czJCZzlu?=
 =?utf-8?B?bVA2UVgwVHRpd05WbllUdGRQejBTQWZrNVlYZWlMUi95L05ocTMybHY5cUox?=
 =?utf-8?B?eXlFQzRvWFlKZ1prU2NVNUpzbGoyZ0ovMnVYVXFlT3FZYStRV1k1djN1UTRk?=
 =?utf-8?B?MnRTQlFLelA4NHJmbmh0cnFJN3QrYnFOU3gvZERtdzNyUVpFK3hOemhJcUlG?=
 =?utf-8?Q?/DfMSdbXIr1JdGEf8L6D3LM4F?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f0f576f2-af85-4705-274c-08dc3e2c65ac
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 22:25:58.6485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0THpi9X6VBia6CnQAq5TkCXp3EkeqCjVDS/IZKGVQA++vKIYtfU0tB1Y2kFGbsfUueoGqcnh1f+4lhmhhOYmlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6292
X-OriginatorOrg: intel.com


>> Please just clarify (at least):
>>
>>   - Does this problem exist in upstream code?
> 
> No.
> 
>>   - If it does, what is the root cause, and how to reproduce?
> 
> v18 had a problem because it has stub function. v19 doesn't have problem because
> it deleted the stub function.

What is the "stub function"??

If "v19 doesn't have problem", why do you even _need_ this patch??

I am tired of guessing, but I don't care anymore given it's not a 
problem in upstream code.