Received-SPF: pass (google.com: domain of linux-kernel+bounces-94684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 7 Mar 2024 00:04:50 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de
Subject: Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across
 suspends
Message-ID: <8de1d4e3-6d80-45a5-a638-48451d9b5c15@lunn.ch>
References: <20240306171446.859750-1-catalin.popescu@leica-geosystems.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306171446.859750-1-catalin.popescu@leica-geosystems.com>

On Wed, Mar 06, 2024 at 06:14:46PM +0100, Catalin Popescu wrote:
> Unlike other ethernet PHYs from TI, PHY dp83822x has WOL enabled
> at reset.

This is rather odd behaviour. Is this stated in the datasheet?

> @@ -572,11 +584,17 @@ static int dp83826_config_init(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);
>  }
>  
>  static int dp8382x_config_init(struct phy_device *phydev)
>  {
> +	struct dp83822_private *dp83822 = phydev->priv;
> +
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);

Since it is rather odd behaviour, there might be some BIOSes which
disable WoL. So i would not rely on it being enabled by
default. Explicitly enable it.

    Andrew

---
pw-bot: cr